diff mbox

[dpdk-dev] ixgbe: fix ixgbe PCI access endian issue

Message ID 1423703990-29031-1-git-send-email-xuelin.shi@freescale.com (mailing list archive)
State Accepted, archived
Headers show

Commit Message

xuelin.shi@freescale.com Feb. 12, 2015, 1:19 a.m. UTC 
From: Xuelin Shi <xuelin.shi@freescale.com>

ixgbe is little endian, but cpu maybe not.
add necessary conversions.
    rte_cpu_to_le_32(...) for PCI write
    rte_le_to_cpu_32(...) for PCI read.

Signed-off-by: Xuelin Shi <xuelin.shi@freescale.com>
---
 lib/librte_pmd_ixgbe/ixgbe/ixgbe_osdep.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Thomas Monjalon Feb. 20, 2015, 10:53 a.m. UTC | #1 
> ixgbe is little endian, but cpu maybe not.
> add necessary conversions.
>     rte_cpu_to_le_32(...) for PCI write
>     rte_le_to_cpu_32(...) for PCI read.
> 
> Signed-off-by: Xuelin Shi <xuelin.shi@freescale.com>

Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>

Applied, thanks
Helin Zhang March 25, 2015, 6:33 a.m. UTC | #2 
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of
> xuelin.shi@freescale.com
> Sent: Thursday, February 12, 2015 9:20 AM
> To: thomas.monjalon@6wind.com
> Cc: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] ixgbe: fix ixgbe PCI access endian issue
> 
> From: Xuelin Shi <xuelin.shi@freescale.com>
> 
> ixgbe is little endian, but cpu maybe not.
> add necessary conversions.
>     rte_cpu_to_le_32(...) for PCI write
>     rte_le_to_cpu_32(...) for PCI read.
> 
> Signed-off-by: Xuelin Shi <xuelin.shi@freescale.com>
Acked-by: Helin Zhang <helin.zhang@intel.com>

> ---
>  lib/librte_pmd_ixgbe/ixgbe/ixgbe_osdep.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/librte_pmd_ixgbe/ixgbe/ixgbe_osdep.h
> b/lib/librte_pmd_ixgbe/ixgbe/ixgbe_osdep.h
> index 2d40bfd..f8bfb3f 100644
> --- a/lib/librte_pmd_ixgbe/ixgbe/ixgbe_osdep.h
> +++ b/lib/librte_pmd_ixgbe/ixgbe/ixgbe_osdep.h
> @@ -119,11 +119,11 @@ typedef int		bool;
> 
>  static inline uint32_t ixgbe_read_addr(volatile void* addr)  {
> -	return IXGBE_PCI_REG(addr);
> +	return rte_le_to_cpu_32(IXGBE_PCI_REG(addr));
>  }
> 
>  #define IXGBE_PCI_REG_WRITE(reg, value) do { \
> -	IXGBE_PCI_REG((reg)) = (value); \
> +	IXGBE_PCI_REG((reg)) = (rte_cpu_to_le_32(value)); \
>  } while(0)
> 
>  #define IXGBE_PCI_REG_ADDR(hw, reg) \
> --
> 1.9.1
diff mbox

Patch

diff --git a/lib/librte_pmd_ixgbe/ixgbe/ixgbe_osdep.h b/lib/librte_pmd_ixgbe/ixgbe/ixgbe_osdep.h
index 2d40bfd..f8bfb3f 100644
--- a/lib/librte_pmd_ixgbe/ixgbe/ixgbe_osdep.h
+++ b/lib/librte_pmd_ixgbe/ixgbe/ixgbe_osdep.h
@@ -119,11 +119,11 @@  typedef int		bool;
 
 static inline uint32_t ixgbe_read_addr(volatile void* addr)
 {
-	return IXGBE_PCI_REG(addr);
+	return rte_le_to_cpu_32(IXGBE_PCI_REG(addr));
 }
 
 #define IXGBE_PCI_REG_WRITE(reg, value) do { \
-	IXGBE_PCI_REG((reg)) = (value); \
+	IXGBE_PCI_REG((reg)) = (rte_cpu_to_le_32(value)); \
 } while(0)
 
 #define IXGBE_PCI_REG_ADDR(hw, reg) \