[dpdk-dev] lib/librte_ether: change socket_id passed to rte_memzone_reserve
Commit Message
Removes the dependency that this memzone reserve has on the
socket currently running on. Following the socket of the master
core will yield more predictable results when calling this
function after initialisation.
Signed-off-by: Cian Ferriter <cian.ferriter@intel.com>
Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com>
Reviewed-by: Bruce Richardson <bruce.richardson@intel.com>
---
lib/librte_ether/rte_ethdev.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
mode change 100644 => 100755 lib/librte_ether/rte_ethdev.c
Comments
Hi,
2015-01-22 15:05, Cian Ferriter:
> Removes the dependency that this memzone reserve has on the
> socket currently running on. Following the socket of the master
> core will yield more predictable results when calling this
> function after initialisation.
You don't describe what is the problem. In another mail, you say
"The original suggestion also fixes the crash that I was seeing because
of memory being reserved from a numa node with no "--socket-mem" allocated."
Please describe it clearly in the commit log.
You should also explain what this rte_memzone_reserve() is for,
and what are the incidences of your changes.
Thanks
old mode 100644
new mode 100755
@@ -184,7 +184,7 @@ rte_eth_dev_data_alloc(void)
if (rte_eal_process_type() == RTE_PROC_PRIMARY){
mz = rte_memzone_reserve(MZ_RTE_ETH_DEV_DATA,
RTE_MAX_ETHPORTS * sizeof(*rte_eth_dev_data),
- rte_socket_id(), flags);
+ rte_lcore_to_socket_id(rte_get_master_lcore()), flags);
} else
mz = rte_memzone_lookup(MZ_RTE_ETH_DEV_DATA);
if (mz == NULL)