diff mbox

[dpdk-dev,01/10] eal: move internal headers in source directory

Message ID 1416692622-28886-2-git-send-email-thomas.monjalon@6wind.com (mailing list archive)
State Accepted, archived
Headers show

Commit Message

Thomas Monjalon Nov. 22, 2014, 9:43 p.m. UTC
The directory include/ should be reserved to public headers.

Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
---
 lib/librte_eal/bsdapp/eal/Makefile                       | 1 +
 lib/librte_eal/common/{include => }/eal_options.h        | 0
 lib/librte_eal/common/{include => }/eal_private.h        | 0
 lib/librte_eal/linuxapp/eal/Makefile                     | 1 +
 lib/librte_eal/linuxapp/eal/{include => }/eal_pci_init.h | 0
 lib/librte_eal/linuxapp/eal/{include => }/eal_vfio.h     | 0
 6 files changed, 2 insertions(+)
 rename lib/librte_eal/common/{include => }/eal_options.h (100%)
 rename lib/librte_eal/common/{include => }/eal_private.h (100%)
 rename lib/librte_eal/linuxapp/eal/{include => }/eal_pci_init.h (100%)
 rename lib/librte_eal/linuxapp/eal/{include => }/eal_vfio.h (100%)

Comments

Bruce Richardson Nov. 25, 2014, 10:21 a.m. UTC | #1
On Sat, Nov 22, 2014 at 10:43:33PM +0100, Thomas Monjalon wrote:
> The directory include/ should be reserved to public headers.
> 
> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>

Acked-by: Bruce Richardson <bruce.richardson@intel.com>

> ---
>  lib/librte_eal/bsdapp/eal/Makefile                       | 1 +
>  lib/librte_eal/common/{include => }/eal_options.h        | 0
>  lib/librte_eal/common/{include => }/eal_private.h        | 0
>  lib/librte_eal/linuxapp/eal/Makefile                     | 1 +
>  lib/librte_eal/linuxapp/eal/{include => }/eal_pci_init.h | 0
>  lib/librte_eal/linuxapp/eal/{include => }/eal_vfio.h     | 0
>  6 files changed, 2 insertions(+)
>  rename lib/librte_eal/common/{include => }/eal_options.h (100%)
>  rename lib/librte_eal/common/{include => }/eal_private.h (100%)
>  rename lib/librte_eal/linuxapp/eal/{include => }/eal_pci_init.h (100%)
>  rename lib/librte_eal/linuxapp/eal/{include => }/eal_vfio.h (100%)
> 
> diff --git a/lib/librte_eal/bsdapp/eal/Makefile b/lib/librte_eal/bsdapp/eal/Makefile
> index ca943c1..4683fc3 100644
> --- a/lib/librte_eal/bsdapp/eal/Makefile
> +++ b/lib/librte_eal/bsdapp/eal/Makefile
> @@ -36,6 +36,7 @@ LIB = librte_eal.a
>  VPATH += $(RTE_SDK)/lib/librte_eal/common
>  
>  CFLAGS += -I$(SRCDIR)/include
> +CFLAGS += -I$(RTE_SDK)/lib/librte_eal/common
>  CFLAGS += -I$(RTE_SDK)/lib/librte_eal/common/include
>  CFLAGS += -I$(RTE_SDK)/lib/librte_ring
>  CFLAGS += -I$(RTE_SDK)/lib/librte_mempool
> diff --git a/lib/librte_eal/common/include/eal_options.h b/lib/librte_eal/common/eal_options.h
> similarity index 100%
> rename from lib/librte_eal/common/include/eal_options.h
> rename to lib/librte_eal/common/eal_options.h
> diff --git a/lib/librte_eal/common/include/eal_private.h b/lib/librte_eal/common/eal_private.h
> similarity index 100%
> rename from lib/librte_eal/common/include/eal_private.h
> rename to lib/librte_eal/common/eal_private.h
> diff --git a/lib/librte_eal/linuxapp/eal/Makefile b/lib/librte_eal/linuxapp/eal/Makefile
> index c99433e..2480cb0 100644
> --- a/lib/librte_eal/linuxapp/eal/Makefile
> +++ b/lib/librte_eal/linuxapp/eal/Makefile
> @@ -36,6 +36,7 @@ LIB = librte_eal.a
>  VPATH += $(RTE_SDK)/lib/librte_eal/common
>  
>  CFLAGS += -I$(SRCDIR)/include
> +CFLAGS += -I$(RTE_SDK)/lib/librte_eal/common
>  CFLAGS += -I$(RTE_SDK)/lib/librte_eal/common/include
>  CFLAGS += -I$(RTE_SDK)/lib/librte_ring
>  CFLAGS += -I$(RTE_SDK)/lib/librte_mempool
> diff --git a/lib/librte_eal/linuxapp/eal/include/eal_pci_init.h b/lib/librte_eal/linuxapp/eal/eal_pci_init.h
> similarity index 100%
> rename from lib/librte_eal/linuxapp/eal/include/eal_pci_init.h
> rename to lib/librte_eal/linuxapp/eal/eal_pci_init.h
> diff --git a/lib/librte_eal/linuxapp/eal/include/eal_vfio.h b/lib/librte_eal/linuxapp/eal/eal_vfio.h
> similarity index 100%
> rename from lib/librte_eal/linuxapp/eal/include/eal_vfio.h
> rename to lib/librte_eal/linuxapp/eal/eal_vfio.h
> -- 
> 2.1.3
>
diff mbox

Patch

diff --git a/lib/librte_eal/bsdapp/eal/Makefile b/lib/librte_eal/bsdapp/eal/Makefile
index ca943c1..4683fc3 100644
--- a/lib/librte_eal/bsdapp/eal/Makefile
+++ b/lib/librte_eal/bsdapp/eal/Makefile
@@ -36,6 +36,7 @@  LIB = librte_eal.a
 VPATH += $(RTE_SDK)/lib/librte_eal/common
 
 CFLAGS += -I$(SRCDIR)/include
+CFLAGS += -I$(RTE_SDK)/lib/librte_eal/common
 CFLAGS += -I$(RTE_SDK)/lib/librte_eal/common/include
 CFLAGS += -I$(RTE_SDK)/lib/librte_ring
 CFLAGS += -I$(RTE_SDK)/lib/librte_mempool
diff --git a/lib/librte_eal/common/include/eal_options.h b/lib/librte_eal/common/eal_options.h
similarity index 100%
rename from lib/librte_eal/common/include/eal_options.h
rename to lib/librte_eal/common/eal_options.h
diff --git a/lib/librte_eal/common/include/eal_private.h b/lib/librte_eal/common/eal_private.h
similarity index 100%
rename from lib/librte_eal/common/include/eal_private.h
rename to lib/librte_eal/common/eal_private.h
diff --git a/lib/librte_eal/linuxapp/eal/Makefile b/lib/librte_eal/linuxapp/eal/Makefile
index c99433e..2480cb0 100644
--- a/lib/librte_eal/linuxapp/eal/Makefile
+++ b/lib/librte_eal/linuxapp/eal/Makefile
@@ -36,6 +36,7 @@  LIB = librte_eal.a
 VPATH += $(RTE_SDK)/lib/librte_eal/common
 
 CFLAGS += -I$(SRCDIR)/include
+CFLAGS += -I$(RTE_SDK)/lib/librte_eal/common
 CFLAGS += -I$(RTE_SDK)/lib/librte_eal/common/include
 CFLAGS += -I$(RTE_SDK)/lib/librte_ring
 CFLAGS += -I$(RTE_SDK)/lib/librte_mempool
diff --git a/lib/librte_eal/linuxapp/eal/include/eal_pci_init.h b/lib/librte_eal/linuxapp/eal/eal_pci_init.h
similarity index 100%
rename from lib/librte_eal/linuxapp/eal/include/eal_pci_init.h
rename to lib/librte_eal/linuxapp/eal/eal_pci_init.h
diff --git a/lib/librte_eal/linuxapp/eal/include/eal_vfio.h b/lib/librte_eal/linuxapp/eal/eal_vfio.h
similarity index 100%
rename from lib/librte_eal/linuxapp/eal/include/eal_vfio.h
rename to lib/librte_eal/linuxapp/eal/eal_vfio.h