[dpdk-dev,RFC,1/3] eal/bsd: fix fd leak

Message ID 1409062300-17004-2-git-send-email-david.marchand@6wind.com (mailing list archive)
State Accepted, archived

Commit Message

David Marchand Aug. 26, 2014, 2:11 p.m. UTC
  Signed-off-by: David Marchand <david.marchand@6wind.com>
 lib/librte_eal/bsdapp/eal/eal.c |    1 +
 1 file changed, 1 insertion(+)


Thomas Monjalon Sept. 25, 2014, 10:17 a.m. UTC | #1

Is there any BSD users available to test this patch?

I'd like to add this comment in the log:
"The initial implementation simply raised the IOPL of the current thread
when open(2) was called on the device. This behaviour is retained in the
current implementation as legacy support for both i386 and amd64."

Nothing prevents from closing it just after.

But it should be tested with virtio to check iopl permissions.



diff --git a/lib/librte_eal/bsdapp/eal/eal.c b/lib/librte_eal/bsdapp/eal/eal.c
index a296da5..0697b05 100644
--- a/lib/librte_eal/bsdapp/eal/eal.c
+++ b/lib/librte_eal/bsdapp/eal/eal.c
@@ -810,6 +810,7 @@  rte_eal_iopl_init(void)
 	fd = open("/dev/io", O_RDWR);
 	if (fd < 0)
 		return -1;
+	close(fd);
 	return 0;