From patchwork Thu Jan 25 16:17:59 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shahaf Shuler X-Patchwork-Id: 34481 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A98261B1B6; Thu, 25 Jan 2018 17:18:45 +0100 (CET) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0068.outbound.protection.outlook.com [104.47.1.68]) by dpdk.org (Postfix) with ESMTP id 662C41B024; Thu, 25 Jan 2018 17:18:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=3HqC9EV2P6oczpTFjRH4dVRxCvCwY/OHe1MYtpjUeaU=; b=dSo4InWya11vzN8kMA+cTOh7EE6vUEhwndIep7VonVJsQ7kCqpHUbrJK6aVYXFqiPg3PkosEsMROvjDNNIUS9oRDY6Jshc51c1RCMRKCyNtFODpGz322wWNhb0dIoFXA7hKsJPRvcds9x72AinPbcQ2w9cslvucrp54rxFsfgFI= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; Received: from mellanox.com (141.226.120.58) by DB6PR05MB3143.eurprd05.prod.outlook.com (2603:10a6:6:1a::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.444.14; Thu, 25 Jan 2018 16:18:39 +0000 From: Shahaf Shuler To: nelio.laranjeiro@6wind.com, adrien.mazarguil@6wind.com, yskoh@mellanox.com Cc: dev@dpdk.org, stable@dpdk.org, Xueming Li Date: Thu, 25 Jan 2018 18:17:59 +0200 Message-Id: <0bdcde7f31fcbd74224bea27c3db5fb79d2b3fc0.1516896871.git.shahafs@mellanox.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: References: MIME-Version: 1.0 X-Originating-IP: [141.226.120.58] X-ClientProxiedBy: DB6PR0301CA0051.eurprd03.prod.outlook.com (2603:10a6:4:54::19) To DB6PR05MB3143.eurprd05.prod.outlook.com (2603:10a6:6:1a::17) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: b5e28975-f727-405e-cca2-08d5640f4c13 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(2017052603307)(7153060)(7193020); SRVR:DB6PR05MB3143; X-Microsoft-Exchange-Diagnostics: 1; DB6PR05MB3143; 3:nFYMexVnTkDTqenvrj62bMaospQCv/ROHt5M94KarOBdqmG5j7xU9OdL/uRWydE6JHUm2RtFohuqJjvjZxH95DTz3gvohJH8QacPtNmDazguUxsQjimqeG84jJ0k8IHfEWhSuJ9t2BPxYLkI5keylKQyw8WqkPQk04xzOSRHF7dMvCs3qRX7XThiAisbE4nKy0Q0gq6SU7LVRoKH5i9cpN6bXOXvsvTo+XIfHrymCaRfWn9d4g/XQhcqJnW5L/RO; 25:K/V4RiiABFkWUWr7myu7idIYSr8pSOqNHS8BUM1CnZEEf0t5b8VkOIjdguG/YaUu/WcJw9C10gmcw9cSxfLL1cOb9Ygh/lbHLSP3Qj5OmgQ/kyZ6doCN2OpCo10YaSmARlavzECClbP+H0L98MZml74S31BI+/WoX2iMDsBWjHIED01ASx04l71ggJRQL4GUoOKhKlpi8qPHaPZ2ZrwHqVFAqId1e94+cHQl2EDim4Po7fwdkokImtcnE065TOg2ND+ro5qcrkm74DD3WNhP3P/W4mPf3B3L+MGTpDqlgyESXsDKisd46guU6fOLUgGmfZKvbjaYOzPzZjTeCugFwA==; 31:J+WwG7t32mpsBKmCaMF3TIOFq7Cte9JYEsNG70eCScdayNrHefx5ifOZf2shs6IxO45aasX8niMh9h2ASZv6bWpeczJ5ovhvwxNm/bfAx2UcHGMLqgunDYtbXBQ6pzaNxag04mPh03NbNUW274pK/vV83uB9ZB3WnPPy98xU8JFX3DwQYzjVpjMv9w1cJObH8OgXDQK11DL3LIxaH/N0uToeYdzMU6TrBUV+ItT7BYk= X-MS-TrafficTypeDiagnostic: DB6PR05MB3143: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; DB6PR05MB3143; 20:vx68ZrRnhOqo0TaIggURwiC2DzjhTu8nZFkXwvdWjm6/e1yNlNbDb3jIXXVOuekSf3b0KK2JaCfLHcEMlChqQuMHpMCIi9Kgv9BCKWISG5y59t26zWMCObmCwpMWhlzSJc/pVV9a82bl3SqxZ0+LiEBQjVwdDwCo2gw9V/yBYUaq8c6ctAIRbxb1tRvQLF0mAqUQrGiABZddQLzPjYbhr1/etjTEAL9BJ/vkXqqizBuVgNXIyBAlEHRe8XHmbBJwaff8D59UwCCpexc9ft0VS10U2FAMM6eNu0KD47o2DPHxn0V6b+SN5a26Y1oppWqjbRYLdzPhxK4GXpF9FkboN8DMm2vyeDbzUPmILQz3WwvzVRBwqx0Jwy43ChSTdCzdXjcS6wqiU2SWJS740GRlH2L0avLfW1yB6q7OE1ce46lx3jGEOcgUAVbTvX3g6V4Q4e56rl+uuL2wdQryJtxqXxp512RUT8efxkaScvQSxbVMPkIBouBu6J1rFCjHNEwa; 4:t1kSoOgXCPnJe0v4wX0PLQ8dgKiRipbIo0Gi/XBq4r/QhceSauewd8Zu1795ub6UkI9L9s7IDByY5Fm7/F6LLPz8Kpib9rHhmswOlmPhmmQ47mkidmQGC8hNV6XxyY74Ml29O7NGj2kL1kvUdZ6DzIQZp1/b+Cobf/NAChcpegbBeooAfaZJ/LCOJCSP1DUJ0JGd0BRRYTqcZKUzIec5GElBQElYpQ7Sn3q8mBn+yBaFVD9SqAc3Vbr81Ay6fzGkqWR8LsUJNguftZ7IW/Mazg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(5005006)(8121501046)(93006095)(93001095)(3231023)(2400081)(944501161)(10201501046)(3002001)(6055026)(6041288)(20161123558120)(20161123562045)(20161123560045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:DB6PR05MB3143; BCL:0; PCL:0; RULEID:; SRVR:DB6PR05MB3143; X-Forefront-PRVS: 0563F2E8B7 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39860400002)(376002)(396003)(346002)(39380400002)(366004)(189003)(199004)(53936002)(478600001)(21086003)(4326008)(107886003)(6636002)(6666003)(47776003)(25786009)(55016002)(106356001)(69596002)(86362001)(36756003)(2906002)(66066001)(8676002)(16526018)(16586007)(81156014)(81166006)(8936002)(3846002)(105586002)(48376002)(50466002)(26005)(316002)(68736007)(6116002)(51416003)(7696005)(118296001)(76176011)(5660300001)(7736002)(305945005)(97736004)(52116002)(386003)(2950100002)(186003)(50226002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR05MB3143; H:mellanox.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DB6PR05MB3143; 23:8N98JH1IVqBvgOp8Lt/fbdyAYRweKVohqjVauzW1X?= MeLifgQ9cqPhKblLYfhYOFRDcO8gezejKuTRg9/6uEs02LAwPzyvQdE6DYLCOeLYdTh+dDrQlIPmdkYU61tEjbEKTEn9GgQFZAv5EVPyEsXc04OcTt4F+9/+ymqyL93ZmiSWoZakUPVbDv71L5VEswt5ZmXTNu+yNtdmb7c0mzoRVAiDHvPk9Py/w+Lo5PWlc+CoCr37+Jdo2bTNfASNbmqy8YYd1bTh60qYtl2nXmCDCPGYK44ZxahCmK7P15cYGojLCDEH5iqAAfSeo46adT9tfEwe+iCJvTjf3pwI4WlfNs3Bsge+OgeljIJF3PZ8/aAZdy1lnTIrYV3E9uqnraJHK8P8Iz8a1J5QwZV1cMXQDTS+z2GNbj6P64KBRjwPl6mU0/p9FrmhJMo+pUAI7arGlYSn3EmI5cPrTyXYAj7iixvfbwKnzilhl1XLq4pGIx7yYgr8k1ISYGnIhFnnVKHlR1Y3PnpwqO4hrzB77E22z/i27Y6L5akmu0Rwdeqz+pFI1D6YofH+tbwj0bKq9TFS2u49PJF929KYEkyC7e8ju/E9ufC5utc80hL2WJF3YZ9TviUU+y8uur1j1XMfoaSrOdBpgzAVvPE0opFn+5JUEDjq5T9PornK74SbiJNPicpO1gMiPESD2fhasYf4CYGdM61JlzQ9anwf41IiK/uTz19SVUMgCNouX2J6sHFBRMUyWpOMkXYzZjNwYaKEN8egvvOwRVibkuurcgX5ejU16x/bjreYr5zqNJBVKtQO7cyPKf7N9XnHbriS4vfbGtKZ9V5axlv0gacw19s7j9M6DxGQa6TfgGsczurlzl9wJSS/EGz/QhDiwTLxQ2C67HKEUQiEsNYsIXATYtIlOIodCJv4Jge6LdBPqDcB0uCNldfKJsGGwNBFRc1dL1cgVUJEOqK+RIqqVO4VT9KQ2v5Y2SujqMqDVnB2wDH/asCi7s50bDqRgqfH6zM+TPtycm1UWI1iR/OMwjZzLcEjPlW4s3zm7D2wPOt8Q02s8Waq6m2sFhH/Qt6q3xKZKxbeuS0kViHtD71M+IC1huwDlnx5lXDqJfO2rxvhDPgjEYz6QIKh2zZIpP5fHAIkiMMSJzyNJzn9OH/Mxrf9mk7ufpd0A== X-Microsoft-Exchange-Diagnostics: 1; DB6PR05MB3143; 6:IkM5/bxoUuN8mAP4w4BABxQZqusffuHRl5j78xSyAyy8BM3OsKyEm2HXB36G/qCwDTYfvb577SaY086vh/M89pkS0LGkidwbGFP1RRGiZcgeRc3qQLGrGcCr1R2pMVLyMyf44k8hnDhHufYy+aN1lG956yu+GtMJn9214lDLD8XgFJzw8bIuYGxerL9v4dFivVsKDzx+bPz7Nl1XhGhUH8qUey5lwTqFHUZRYDKjRezl4AaSrWsItM+dKKHv/u+c5XF/aLeRyEzYl+QaLCoQaEZtlBXY2exDzN2sWjm8z31Xp0UwVh0rA/AS+YgUiQL3H1spNtsY0+j3P2avRLOzoO03RqwbwynOdHqejxuUfuQ=; 5:DX/I7BhtqIDWl2rNBk6qLHeFJ7SiUwHJeaIfPIr19PJn7pBJeLGaJyU3AwpsILhk+odEDIUgknMJpI9QSNBVNmTgCeSo9L+igcGvHTd5PBmoP6IQwpRgso8DkwIoeh+y8IP8IxOEzkG6+6PTOgKtXZHdber9CzpKItjsKOaPxS8=; 24:p1spklKPAUCE9pMZdwx0bS80gkqQ7oCgDdyRXjz9TtccY+Xb/kVYJqcxBNJtpdqVHyIzDIbTQxBhtGYX128swW2bTadTiXEJBmkWzGRBkbo=; 7:B0VwE4F8NZwZbcV1M6/+NeYHHFsMh9Z81wjJ138CxDcIGIJDNOaIw9xHcKYwDGv4cQnNpajjnJfBSMxW7xWrhAdGwRxxTcRvO4tVG6ECtHxL+/37AIxLnk8zCDQzXe8uKmI3tG61FFaYVDiNth/7hRlOZbx3wxZjAso56FBp5SJQcWasBnl1JAkGnu0RuS/n7lGskHWQnFnFKbGCPKPxzu96tE9CsQm/3Oxo644e7ncz+qcmkjA4GSPktViY0YDB SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jan 2018 16:18:39.9883 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b5e28975-f727-405e-cca2-08d5640f4c13 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR05MB3143 Subject: [dpdk-dev] [PATCH v2 2/6] net/mlx5: fix secondary process mempool registration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Secondary process is not allowed to register mempools on the flight. The code will return invalid memory key for such case. Fixes: 87ec44ce1651 ("net/mlx5: add operations for secondary process") Cc: stable@dpdk.org Signed-off-by: Shahaf Shuler Signed-off-by: Xueming Li Acked-by: Nelio Laranjeiro --- doc/guides/nics/mlx5.rst | 6 +++++- drivers/net/mlx5/mlx5_mr.c | 12 ++++++++++-- 2 files changed, 15 insertions(+), 3 deletions(-) diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index bdc2216c0..2e6d1e45a 100644 --- a/doc/guides/nics/mlx5.rst +++ b/doc/guides/nics/mlx5.rst @@ -106,7 +106,11 @@ Limitations - Inner RSS for VXLAN frames is not supported yet. - Hardware checksum RX offloads for VXLAN inner header are not supported yet. -- Forked secondary process not supported. +- For secondary process: + + - Forked secondary process not supported. + - All mempools must be initialized before rte_eth_dev_start(). + - Flow pattern without any specific vlan will match for vlan packets as well: When VLAN spec is not specified in the pattern, the matching rule will be created with VLAN as a wild card. diff --git a/drivers/net/mlx5/mlx5_mr.c b/drivers/net/mlx5/mlx5_mr.c index 2776dc700..cb625dc61 100644 --- a/drivers/net/mlx5/mlx5_mr.c +++ b/drivers/net/mlx5/mlx5_mr.c @@ -141,8 +141,16 @@ priv_txq_mp2mr_reg(struct priv *priv, struct mlx5_txq_data *txq, DEBUG("%p: discovered new memory pool \"%s\" (%p)", (void *)txq_ctrl, mp->name, (void *)mp); mr = priv_mr_get(priv, mp); - if (mr == NULL) - mr = priv_mr_new(priv, mp); + if (mr == NULL) { + if (rte_eal_process_type() != RTE_PROC_PRIMARY) { + DEBUG("Using unregistered mempool 0x%p(%s) in secondary process," + " please create mempool before rte_eth_dev_start()", + (void *)mp, mp->name); + return NULL; + } else { + mr = priv_mr_new(priv, mp); + } + } if (unlikely(mr == NULL)) { DEBUG("%p: unable to configure MR, ibv_reg_mr() failed.", (void *)txq_ctrl);