From patchwork Fri Sep 1 08:07:04 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adrien Mazarguil X-Patchwork-Id: 28248 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id E2B799B5F; Fri, 1 Sep 2017 10:08:35 +0200 (CEST) Received: from mail-wr0-f173.google.com (mail-wr0-f173.google.com [209.85.128.173]) by dpdk.org (Postfix) with ESMTP id 3FA227D5B for ; Fri, 1 Sep 2017 10:08:24 +0200 (CEST) Received: by mail-wr0-f173.google.com with SMTP id y15so4500699wrc.2 for ; Fri, 01 Sep 2017 01:08:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id:in-reply-to:references; bh=uewsOv6lo3UdytZ0dopTPq1jQfKteHFsm22VGrhSgWU=; b=oMRsScPFk2lzZgVgxSnREFQENjtLDbhX8ZO4PPpmL8tk1FI/li6oKfBRFHtAwCZ4bl 3v50cVyI+b6ez8JPRv0M92Zucd6hfhUv2FnEdGc38nXCFmD8gA6sjUnfI+8rim6Ni/G3 WDSzb9C/e+xsVqBAonjPjAXoR1rkB4Mbl4rLavxqwb8W0lhDiWse/Ne18M00ITZ1J0dx D6yuvPfvinPMGpxHB4OjwlsS2aXeSboNFEKmeBY2h1n2HgZN6Riz83zAHbrgcvd8Ghk+ Gbw0JxAFG9k4F8Go/qWx4o+k/D5VQJer2XeboDLE+XcGtgoJy+70aq6VudUm9gL/wxVF EvIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=uewsOv6lo3UdytZ0dopTPq1jQfKteHFsm22VGrhSgWU=; b=Djh8xMVqizFQRJFnbwfomX3npkc9MjiNAl6/pzn/DzgZKpZ0X+4Wwq6ZgC4HEYcJPL Wg46Dx5JAekCn5mLsBmrp9ZfRzovAU9tsEx17wxEanYGOta4w6l/a4AdhjXgQzy+++Yt z2qod9K+YqLonJfatlkuKPdC3AKZY92R4joKiXuW5JmlN/hiuJp/EjOg0Uwgsy/B4z4S wRWA4ikxasKS1/+zmCP+BiY6VOCczfQfD/ll3PNwaXA5pfDzzR9U/x3Rl0VBvd1b2hHf eY7aypE1oP6WhAEB6Ezv2yYXGDESxLV/rn2bt4UDnjQpmygPaIJWZVS8vn1z4lEWpUrK AdAA== X-Gm-Message-State: AHPjjUgIEayzlt22Ert4Yj6LtCJwfAojwZxM6Sstg/IQkrokMc6ehtaL WGici68OJSAqO8LvONs= X-Google-Smtp-Source: ADKCNb4/vah9n4JR1lcbAxwxbrrgVX+Pq3oMy8WcQu88Kr+2J6g3jNmrwCIxR3qAFQQq5tNDLi6L9g== X-Received: by 10.223.172.108 with SMTP id v99mr641931wrc.170.1504253303717; Fri, 01 Sep 2017 01:08:23 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id 26sm2117096wrx.43.2017.09.01.01.08.22 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 01 Sep 2017 01:08:23 -0700 (PDT) From: Adrien Mazarguil To: dev@dpdk.org Date: Fri, 1 Sep 2017 10:07:04 +0200 Message-Id: <0921ad7c9d50479a6286edf3a901ccb346ef3b00.1504252977.git.adrien.mazarguil@6wind.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: References: Subject: [dpdk-dev] [PATCH v2 49/51] net/mlx4: clean up includes and comments X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add missing includes and sort them, then update/remove comments around them for consistency. Signed-off-by: Adrien Mazarguil --- drivers/net/mlx4/mlx4.c | 40 ++++++++++++++++++++++++--------------- drivers/net/mlx4/mlx4.h | 3 +-- drivers/net/mlx4/mlx4_flow.c | 5 +++++ drivers/net/mlx4/mlx4_flow.h | 3 +-- 4 files changed, 32 insertions(+), 19 deletions(-) diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c index e8f7048..317d0e6 100644 --- a/drivers/net/mlx4/mlx4.c +++ b/drivers/net/mlx4/mlx4.c @@ -31,29 +31,41 @@ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ -/* System headers. */ +/** + * @file + * mlx4 driver initialization. + */ + +#include +#include +#include #include +#include #include #include -#include -#include #include -#include #include -#include -#include -#include -#include +/* Verbs headers do not support -pedantic. */ +#ifdef PEDANTIC +#pragma GCC diagnostic ignored "-Wpedantic" +#endif +#include +#ifdef PEDANTIC +#pragma GCC diagnostic error "-Wpedantic" +#endif + +#include #include -#include #include -#include -#include +#include +#include +#include #include -#include +#include +#include +#include -/* PMD headers. */ #include "mlx4.h" #include "mlx4_flow.h" #include "mlx4_rxtx.h" @@ -73,8 +85,6 @@ const char *pmd_mlx4_init_params[] = { NULL, }; -/* Device configuration. */ - /** * DPDK callback for Ethernet device configuration. * diff --git a/drivers/net/mlx4/mlx4.h b/drivers/net/mlx4/mlx4.h index 94b5f1e..1cd4db3 100644 --- a/drivers/net/mlx4/mlx4.h +++ b/drivers/net/mlx4/mlx4.h @@ -37,8 +37,7 @@ #include #include -/* Verbs header. */ -/* ISO C doesn't support unnamed structs/unions, disabling -pedantic. */ +/* Verbs headers do not support -pedantic. */ #ifdef PEDANTIC #pragma GCC diagnostic ignored "-Wpedantic" #endif diff --git a/drivers/net/mlx4/mlx4_flow.c b/drivers/net/mlx4/mlx4_flow.c index 5616b83..e2798f6 100644 --- a/drivers/net/mlx4/mlx4_flow.c +++ b/drivers/net/mlx4/mlx4_flow.c @@ -31,6 +31,11 @@ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ +/** + * @file + * Flow API operations for mlx4 driver. + */ + #include #include #include diff --git a/drivers/net/mlx4/mlx4_flow.h b/drivers/net/mlx4/mlx4_flow.h index a24ae31..fbb775d 100644 --- a/drivers/net/mlx4/mlx4_flow.h +++ b/drivers/net/mlx4/mlx4_flow.h @@ -37,8 +37,7 @@ #include #include -/* Verbs header. */ -/* ISO C doesn't support unnamed structs/unions, disabling -pedantic. */ +/* Verbs headers do not support -pedantic. */ #ifdef PEDANTIC #pragma GCC diagnostic ignored "-Wpedantic" #endif