Message ID | cover.1631953295.git.wangyunjian@huawei.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7AF90A0C4B; Sat, 18 Sep 2021 10:33:55 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0B53B40041; Sat, 18 Sep 2021 10:33:55 +0200 (CEST) Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by mails.dpdk.org (Postfix) with ESMTP id 548454003D for <dev@dpdk.org>; Sat, 18 Sep 2021 10:33:53 +0200 (CEST) Received: from dggemv704-chm.china.huawei.com (unknown [172.30.72.56]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4HBPGZ4bQbz8tDp for <dev@dpdk.org>; Sat, 18 Sep 2021 16:33:10 +0800 (CST) Received: from dggpemm500008.china.huawei.com (7.185.36.136) by dggemv704-chm.china.huawei.com (10.3.19.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.8; Sat, 18 Sep 2021 16:33:46 +0800 Received: from localhost (10.174.242.157) by dggpemm500008.china.huawei.com (7.185.36.136) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.8; Sat, 18 Sep 2021 16:33:45 +0800 From: Yunjian Wang <wangyunjian@huawei.com> To: <dev@dpdk.org> CC: <haiyue.wang@intel.com>, <beilei.xing@intel.com>, <qiming.yang@intel.com>, <qi.z.zhang@intel.com>, <dingxiaoxiong@huawei.com>, Yunjian Wang <wangyunjian@huawei.com> Date: Sat, 18 Sep 2021 16:33:03 +0800 Message-ID: <cover.1631953295.git.wangyunjian@huawei.com> X-Mailer: git-send-email 1.9.5.msysgit.1 In-Reply-To: <cover.1631877273.git.wangyunjian@huawei.com> References: <cover.1631877273.git.wangyunjian@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.174.242.157] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemm500008.china.huawei.com (7.185.36.136) X-CFilter-Loop: Reflected Subject: [dpdk-dev] [PATCH v2 0/4] delete HW rings when releasing queues for some drivers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
delete HW rings when releasing queues for some drivers
|
|
Message
Yunjian Wang
Sept. 18, 2021, 8:33 a.m. UTC
This series for deleting HW rings when releasing queues for igb, ixgbe, i40e, ice & em drivers. --- v2: * Update commit log Yunjian Wang (4): net/e1000: delete HW rings when releasing queues net/ice: delete HW rings when releasing queues net/i40e: delete HW rings when releasing queues net/ixgbe: delete HW rings when releasing queues drivers/net/e1000/em_rxtx.c | 8 ++++++-- drivers/net/e1000/igb_rxtx.c | 9 +++++++-- drivers/net/i40e/i40e_fdir.c | 3 --- drivers/net/i40e/i40e_rxtx.c | 8 ++++++-- drivers/net/i40e/i40e_rxtx.h | 2 ++ drivers/net/ice/ice_rxtx.c | 6 ++++-- drivers/net/ice/ice_rxtx.h | 2 ++ drivers/net/ixgbe/ixgbe_rxtx.c | 6 ++++-- drivers/net/ixgbe/ixgbe_rxtx.h | 2 ++ 9 files changed, 33 insertions(+), 13 deletions(-)
Comments
On Sat, Sep 18, 2021 at 10:34 AM Yunjian Wang <wangyunjian@huawei.com> wrote: > > This series for deleting HW rings when releasing queues for > igb, ixgbe, i40e, ice & em drivers. > > --- > v2: > * Update commit log > > Yunjian Wang (4): > net/e1000: delete HW rings when releasing queues > net/ice: delete HW rings when releasing queues > net/i40e: delete HW rings when releasing queues > net/ixgbe: delete HW rings when releasing queues > > drivers/net/e1000/em_rxtx.c | 8 ++++++-- > drivers/net/e1000/igb_rxtx.c | 9 +++++++-- > drivers/net/i40e/i40e_fdir.c | 3 --- > drivers/net/i40e/i40e_rxtx.c | 8 ++++++-- > drivers/net/i40e/i40e_rxtx.h | 2 ++ > drivers/net/ice/ice_rxtx.c | 6 ++++-- > drivers/net/ice/ice_rxtx.h | 2 ++ > drivers/net/ixgbe/ixgbe_rxtx.c | 6 ++++-- > drivers/net/ixgbe/ixgbe_rxtx.h | 2 ++ > 9 files changed, 33 insertions(+), 13 deletions(-) > - In net/ice (at least), the fdir rxq/txq memzones can be aligned on the same scheme. Looking at the remaining drivers (net/cnxk, net/cxgbe and net/octeontx2), we could apply the same principle of keeping a reference to mz in internal driver structures. Afterwards, I see no need to keep rte_eth_dma_zone_free() (it's internal, so we can remove and it's easy to re-add if a need arises). Wdyt? - Is this worth backporting to stable branches?
> -----Original Message----- > From: David Marchand <david.marchand@redhat.com> > Sent: Monday, September 20, 2021 15:25 > To: Yunjian Wang <wangyunjian@huawei.com>; Wang, Haiyue <haiyue.wang@intel.com>; Yigit, Ferruh > <ferruh.yigit@intel.com> > Cc: dev <dev@dpdk.org>; Xing, Beilei <beilei.xing@intel.com>; Yang, Qiming <qiming.yang@intel.com>; > Zhang, Qi Z <qi.z.zhang@intel.com>; dingxiaoxiong@huawei.com; Renata Saiakhova > <Renata.Saiakhova@ekinops.com> > Subject: Re: [dpdk-dev] [PATCH v2 0/4] delete HW rings when releasing queues for some drivers > > On Sat, Sep 18, 2021 at 10:34 AM Yunjian Wang <wangyunjian@huawei.com> wrote: > > > > This series for deleting HW rings when releasing queues for > > igb, ixgbe, i40e, ice & em drivers. > > > > --- > > v2: > > * Update commit log > > > > Yunjian Wang (4): > > net/e1000: delete HW rings when releasing queues > > net/ice: delete HW rings when releasing queues > > net/i40e: delete HW rings when releasing queues > > net/ixgbe: delete HW rings when releasing queues > > > > drivers/net/e1000/em_rxtx.c | 8 ++++++-- > > drivers/net/e1000/igb_rxtx.c | 9 +++++++-- > > drivers/net/i40e/i40e_fdir.c | 3 --- > > drivers/net/i40e/i40e_rxtx.c | 8 ++++++-- > > drivers/net/i40e/i40e_rxtx.h | 2 ++ > > drivers/net/ice/ice_rxtx.c | 6 ++++-- > > drivers/net/ice/ice_rxtx.h | 2 ++ > > drivers/net/ixgbe/ixgbe_rxtx.c | 6 ++++-- > > drivers/net/ixgbe/ixgbe_rxtx.h | 2 ++ > > 9 files changed, 33 insertions(+), 13 deletions(-) > > > > - In net/ice (at least), the fdir rxq/txq memzones can be aligned on > the same scheme. > Looking at the remaining drivers (net/cnxk, net/cxgbe and > net/octeontx2), we could apply the same principle of keeping a > reference to mz in internal driver structures. > Afterwards, I see no need to keep rte_eth_dma_zone_free() (it's > internal, so we can remove and it's easy to re-add if a need arises). > > Wdyt? Yes, this makes dma_zone management clean. And good for hotplug design. Then the function 'rte_eth_dma_zone_reserve' can also be simplified, no need to lookup and check, just call 'rte_memzone_reserve_aligned' directly ? mz = rte_memzone_lookup(z_name); if (mz) { if ((socket_id != SOCKET_ID_ANY && socket_id != mz->socket_id) || size > mz->len || ((uintptr_t)mz->addr & (align - 1)) != 0) { RTE_ETHDEV_LOG(ERR, "memzone %s does not justify the requested attributes\n", mz->name); return NULL; } return mz; } > > > - Is this worth backporting to stable branches? > +1 > > -- > David Marchand