mbox series

[v2,0/5] ethdev: add API to dump device internal flow info

Message ID cover.1579257283.git.jackmin@mellanox.com (mailing list archive)
Headers show
Series ethdev: add API to dump device internal flow info | expand

Message

Xiaoyu Min Jan. 17, 2020, 11:55 a.m. UTC
This serial patchs is based on RFC [1] and the comments on it.

A new rte flow API is added to dump device internal representation
information for the offloaded rte flows.

This is very helpful for user and developer to debug flow offloading
stuff, i.e, to check whether PMD offloads the rte flow in a correct way
from HW perspective.

The output file is in vendor specific format. An external vendor
provided tool may be needed in order to get human readable info.

[1]: https://patches.dpdk.org/cover/64597/

v2:
  * Bump MLX5 PMD glue version to 20.02.0
  * MLX5 PMD validate port id
  * Code improvement per review comments

Xiaoyu Min (2):
  ethdev: add API to dump device internal flow info
  net/mlx5: support flow dump API

Xueming Li (3):
  app/testpmd: new flow dump CLI
  net/mlx5: add socket server for external tools
  doc: update mlx5 document for flow dump feature

 app/test-pmd/cmdline_flow.c              |  91 +++++++++
 app/test-pmd/config.c                    |  27 +++
 app/test-pmd/testpmd.h                   |   1 +
 doc/guides/nics/mlx5.rst                 |  28 +++
 drivers/net/mlx5/Makefile                |   8 +-
 drivers/net/mlx5/meson.build             |   5 +-
 drivers/net/mlx5/mlx5.c                  |   2 +
 drivers/net/mlx5/mlx5.h                  |   9 +
 drivers/net/mlx5/mlx5_devx_cmds.c        |  35 ++++
 drivers/net/mlx5/mlx5_flow.c             |  24 +++
 drivers/net/mlx5/mlx5_glue.c             |  13 ++
 drivers/net/mlx5/mlx5_glue.h             |   1 +
 drivers/net/mlx5/mlx5_socket.c           | 231 +++++++++++++++++++++++
 lib/librte_ethdev/rte_ethdev_version.map |   3 +
 lib/librte_ethdev/rte_flow.c             |  16 ++
 lib/librte_ethdev/rte_flow.h             |  21 +++
 lib/librte_ethdev/rte_flow_driver.h      |   5 +
 17 files changed, 518 insertions(+), 2 deletions(-)
 create mode 100644 drivers/net/mlx5/mlx5_socket.c

Comments

Ferruh Yigit Jan. 17, 2020, 7:26 p.m. UTC | #1
On 1/17/2020 11:55 AM, Xiaoyu Min wrote:
> This serial patchs is based on RFC [1] and the comments on it.
> 
> A new rte flow API is added to dump device internal representation
> information for the offloaded rte flows.
> 
> This is very helpful for user and developer to debug flow offloading
> stuff, i.e, to check whether PMD offloads the rte flow in a correct way
> from HW perspective.
> 
> The output file is in vendor specific format. An external vendor
> provided tool may be needed in order to get human readable info.
> 
> [1]: https://patches.dpdk.org/cover/64597/
> 
> v2:
>   * Bump MLX5 PMD glue version to 20.02.0
>   * MLX5 PMD validate port id
>   * Code improvement per review comments
> 
> Xiaoyu Min (2):
>   ethdev: add API to dump device internal flow info
>   net/mlx5: support flow dump API
> 
> Xueming Li (3):
>   app/testpmd: new flow dump CLI
>   net/mlx5: add socket server for external tools
>   doc: update mlx5 document for flow dump feature

Series applied to dpdk-next-net/master, thanks.
Thomas Monjalon Jan. 19, 2020, 9:08 p.m. UTC | #2
17/01/2020 20:26, Ferruh Yigit:
> On 1/17/2020 11:55 AM, Xiaoyu Min wrote:
> > Xiaoyu Min (2):
> >   ethdev: add API to dump device internal flow info
> >   net/mlx5: support flow dump API
> > 
> > Xueming Li (3):
> >   app/testpmd: new flow dump CLI
> >   net/mlx5: add socket server for external tools
> >   doc: update mlx5 document for flow dump feature
> 
> Series applied to dpdk-next-net/master, thanks.

I think we are missing an update of the testpmd doc.
Xiaoyu Min Jan. 20, 2020, 1:40 a.m. UTC | #3
On Sun, 20-01-19, 22:08, Thomas Monjalon wrote:
> 17/01/2020 20:26, Ferruh Yigit:
> > On 1/17/2020 11:55 AM, Xiaoyu Min wrote:
> > > Xiaoyu Min (2):
> > >   ethdev: add API to dump device internal flow info
> > >   net/mlx5: support flow dump API
> > > 
> > > Xueming Li (3):
> > >   app/testpmd: new flow dump CLI
> > >   net/mlx5: add socket server for external tools
> > >   doc: update mlx5 document for flow dump feature
> > 
> > Series applied to dpdk-next-net/master, thanks.
> 
> I think we are missing an update of the testpmd doc.
> 
Yes, you are right. I'll update testpmd doc.

-Jack