| Message ID | cover.1555926274.git.dekelp@mellanox.com (mailing list archive) |
|---|---|
| Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3A6801B469; Mon, 22 Apr 2019 13:26:17 +0200 (CEST) Received: from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129]) by dpdk.org (Postfix) with ESMTP id 222B81B43B for <dev@dpdk.org>; Mon, 22 Apr 2019 13:26:15 +0200 (CEST) Received: from Internal Mail-Server by MTLPINE1 (envelope-from dekelp@mellanox.com) with ESMTPS (AES256-SHA encrypted); 22 Apr 2019 14:26:10 +0300 Received: from mtl-vdi-280.wap.labs.mlnx. (mtl-vdi-280.wap.labs.mlnx [10.128.130.87]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id x3MBQA04026285; Mon, 22 Apr 2019 14:26:10 +0300 From: Dekel Peled <dekelp@mellanox.com> To: adrien.mazarguil@6wind.com, wenzhuo.lu@intel.com, jingjing.wu@intel.com, bernard.iremonger@intel.com, yskoh@mellanox.com, shahafs@mellanox.com, arybchenko@solarflare.com Cc: dev@dpdk.org, orika@mellanox.com, dekelp@mellanox.com Date: Mon, 22 Apr 2019 14:22:50 +0300 Message-Id: <cover.1555926274.git.dekelp@mellanox.com> X-Mailer: git-send-email 1.7.1 In-Reply-To: <cover.1554896841.git.dekelp@mellanox.com> References: <cover.1554896841.git.dekelp@mellanox.com> Subject: [dpdk-dev] [PATCH v5 0/3] add actions to modify header fields X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
| Series |
add actions to modify header fields
|
|
Message
Dekel Peled
April 22, 2019, 11:22 a.m. UTC
Patch [1] implemented set of header modification actions in MLX PMD, based on ethdev and testpmd updates included in [2].
This series implements support of additional header modification actions, in ethdev, testpmd, and MLX5 PMD.
Original work by Xiaoyu Min.
[1] http://patches.dpdk.org/patch/49310/
[2] http://mails.dpdk.org/archives/dev/2018-August/109672.html
---
v2: apply code review comments.
v3: apply additional code review comments.
- Update documentation of new commands.
- Use common general struct for all commands.
v4: apply checkpatch comments.
v5: apply additional code review comments.
- Add 8, 16, 32 bit types to union.
- Update struct name and documentation.
---
Dekel Peled (3):
ethdev: add actions to modify TCP header fields
app/testpmd: add actions to modify TCP header fields
net/mlx5: update modify header using Direct Verbs
app/test-pmd/cmdline_flow.c | 100 ++++++++++++
doc/guides/prog_guide/rte_flow.rst | 68 ++++++++
doc/guides/testpmd_app_ug/testpmd_funcs.rst | 16 ++
drivers/net/mlx5/mlx5_flow.h | 10 +-
drivers/net/mlx5/mlx5_flow_dv.c | 239 ++++++++++++++++++++++++++++
drivers/net/mlx5/mlx5_prm.h | 12 ++
lib/librte_ethdev/rte_flow.c | 4 +
lib/librte_ethdev/rte_flow.h | 61 +++++++
8 files changed, 509 insertions(+), 1 deletion(-)
Comments
Hi, Please review/comment on v5 of this series so it can be accepted. http://patches.dpdk.org/cover/52974/ Regards, Dekel > -----Original Message----- > From: Dekel Peled <dekelp@mellanox.com> > Sent: Monday, April 22, 2019 2:23 PM > To: Adrien Mazarguil <adrien.mazarguil@6wind.com>; > wenzhuo.lu@intel.com; jingjing.wu@intel.com; > bernard.iremonger@intel.com; Yongseok Koh <yskoh@mellanox.com>; > Shahaf Shuler <shahafs@mellanox.com>; arybchenko@solarflare.com > Cc: dev@dpdk.org; Ori Kam <orika@mellanox.com>; Dekel Peled > <dekelp@mellanox.com> > Subject: [PATCH v5 0/3] add actions to modify header fields > > Patch [1] implemented set of header modification actions in MLX PMD, > based on ethdev and testpmd updates included in [2]. > This series implements support of additional header modification actions, in > ethdev, testpmd, and MLX5 PMD. > > Original work by Xiaoyu Min. > > [1] http://patches.dpdk.org/patch/49310/ > [2] http://mails.dpdk.org/archives/dev/2018-August/109672.html > > --- > v2: apply code review comments. > v3: apply additional code review comments. > - Update documentation of new commands. > - Use common general struct for all commands. > v4: apply checkpatch comments. > v5: apply additional code review comments. > - Add 8, 16, 32 bit types to union. > - Update struct name and documentation. > --- > > Dekel Peled (3): > ethdev: add actions to modify TCP header fields > app/testpmd: add actions to modify TCP header fields > net/mlx5: update modify header using Direct Verbs > > app/test-pmd/cmdline_flow.c | 100 ++++++++++++ > doc/guides/prog_guide/rte_flow.rst | 68 ++++++++ > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 16 ++ > drivers/net/mlx5/mlx5_flow.h | 10 +- > drivers/net/mlx5/mlx5_flow_dv.c | 239 > ++++++++++++++++++++++++++++ > drivers/net/mlx5/mlx5_prm.h | 12 ++ > lib/librte_ethdev/rte_flow.c | 4 + > lib/librte_ethdev/rte_flow.h | 61 +++++++ > 8 files changed, 509 insertions(+), 1 deletion(-) > > -- > 1.8.3.1
Hi Adrien, I understand that you might have some reservations about patch http://patches.dpdk.org/patch/52975/. I'm preparing v6, with update documentation according to comments from Thomas. In v5 I modified the struct rte_flow_integer_action, according to your comments in previous versions. Please reply with any additional comments so I can push this series forward. Regards, Dekel > -----Original Message----- > From: Dekel Peled > Sent: Sunday, June 2, 2019 11:18 AM > To: Adrien Mazarguil <adrien.mazarguil@6wind.com>; > wenzhuo.lu@intel.com; jingjing.wu@intel.com; > bernard.iremonger@intel.com; Yongseok Koh <yskoh@mellanox.com>; > Shahaf Shuler <shahafs@mellanox.com>; arybchenko@solarflare.com; Yigit, > Ferruh <ferruh.yigit@intel.com> > Cc: dev@dpdk.org; Ori Kam <orika@mellanox.com> > Subject: RE: [PATCH v5 0/3] add actions to modify header fields > > Hi, > > Please review/comment on v5 of this series so it can be accepted. > http://patches.dpdk.org/cover/52974/ > > Regards, > Dekel > > > -----Original Message----- > > From: Dekel Peled <dekelp@mellanox.com> > > Sent: Monday, April 22, 2019 2:23 PM > > To: Adrien Mazarguil <adrien.mazarguil@6wind.com>; > > wenzhuo.lu@intel.com; jingjing.wu@intel.com; > > bernard.iremonger@intel.com; Yongseok Koh <yskoh@mellanox.com>; > Shahaf > > Shuler <shahafs@mellanox.com>; arybchenko@solarflare.com > > Cc: dev@dpdk.org; Ori Kam <orika@mellanox.com>; Dekel Peled > > <dekelp@mellanox.com> > > Subject: [PATCH v5 0/3] add actions to modify header fields > > > > Patch [1] implemented set of header modification actions in MLX PMD, > > based on ethdev and testpmd updates included in [2]. > > This series implements support of additional header modification > > actions, in ethdev, testpmd, and MLX5 PMD. > > > > Original work by Xiaoyu Min. > > > > [1] http://patches.dpdk.org/patch/49310/ > > [2] http://mails.dpdk.org/archives/dev/2018-August/109672.html > > > > --- > > v2: apply code review comments. > > v3: apply additional code review comments. > > - Update documentation of new commands. > > - Use common general struct for all commands. > > v4: apply checkpatch comments. > > v5: apply additional code review comments. > > - Add 8, 16, 32 bit types to union. > > - Update struct name and documentation. > > --- > > > > Dekel Peled (3): > > ethdev: add actions to modify TCP header fields > > app/testpmd: add actions to modify TCP header fields > > net/mlx5: update modify header using Direct Verbs > > > > app/test-pmd/cmdline_flow.c | 100 ++++++++++++ > > doc/guides/prog_guide/rte_flow.rst | 68 ++++++++ > > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 16 ++ > > drivers/net/mlx5/mlx5_flow.h | 10 +- > > drivers/net/mlx5/mlx5_flow_dv.c | 239 > > ++++++++++++++++++++++++++++ > > drivers/net/mlx5/mlx5_prm.h | 12 ++ > > lib/librte_ethdev/rte_flow.c | 4 + > > lib/librte_ethdev/rte_flow.h | 61 +++++++ > > 8 files changed, 509 insertions(+), 1 deletion(-) > > > > -- > > 1.8.3.1
Hi Adrien (again ;-) To clarify, I'm working on v6 but will not send it yet. I'm waiting for your comments on v5, and will send v6 only after getting all comments. Regards, Dekel > -----Original Message----- > From: Dekel Peled > Sent: Tuesday, June 4, 2019 8:13 AM > To: Adrien Mazarguil <adrien.mazarguil@6wind.com> > Cc: dev@dpdk.org; Ori Kam <orika@mellanox.com>; Thomas Monjalon > <thomasm@mellanox.com> > Subject: RE: [PATCH v5 0/3] add actions to modify header fields > > Hi Adrien, > > I understand that you might have some reservations about patch > http://patches.dpdk.org/patch/52975/. > I'm preparing v6, with update documentation according to comments from > Thomas. > In v5 I modified the struct rte_flow_integer_action, according to your > comments in previous versions. > Please reply with any additional comments so I can push this series forward. > > Regards, > Dekel > > > -----Original Message----- > > From: Dekel Peled > > Sent: Sunday, June 2, 2019 11:18 AM > > To: Adrien Mazarguil <adrien.mazarguil@6wind.com>; > > wenzhuo.lu@intel.com; jingjing.wu@intel.com; > > bernard.iremonger@intel.com; Yongseok Koh <yskoh@mellanox.com>; > Shahaf > > Shuler <shahafs@mellanox.com>; arybchenko@solarflare.com; Yigit, > > Ferruh <ferruh.yigit@intel.com> > > Cc: dev@dpdk.org; Ori Kam <orika@mellanox.com> > > Subject: RE: [PATCH v5 0/3] add actions to modify header fields > > > > Hi, > > > > Please review/comment on v5 of this series so it can be accepted. > > http://patches.dpdk.org/cover/52974/ > > > > Regards, > > Dekel > > > > > -----Original Message----- > > > From: Dekel Peled <dekelp@mellanox.com> > > > Sent: Monday, April 22, 2019 2:23 PM > > > To: Adrien Mazarguil <adrien.mazarguil@6wind.com>; > > > wenzhuo.lu@intel.com; jingjing.wu@intel.com; > > > bernard.iremonger@intel.com; Yongseok Koh <yskoh@mellanox.com>; > > Shahaf > > > Shuler <shahafs@mellanox.com>; arybchenko@solarflare.com > > > Cc: dev@dpdk.org; Ori Kam <orika@mellanox.com>; Dekel Peled > > > <dekelp@mellanox.com> > > > Subject: [PATCH v5 0/3] add actions to modify header fields > > > > > > Patch [1] implemented set of header modification actions in MLX PMD, > > > based on ethdev and testpmd updates included in [2]. > > > This series implements support of additional header modification > > > actions, in ethdev, testpmd, and MLX5 PMD. > > > > > > Original work by Xiaoyu Min. > > > > > > [1] http://patches.dpdk.org/patch/49310/ > > > [2] http://mails.dpdk.org/archives/dev/2018-August/109672.html > > > > > > --- > > > v2: apply code review comments. > > > v3: apply additional code review comments. > > > - Update documentation of new commands. > > > - Use common general struct for all commands. > > > v4: apply checkpatch comments. > > > v5: apply additional code review comments. > > > - Add 8, 16, 32 bit types to union. > > > - Update struct name and documentation. > > > --- > > > > > > Dekel Peled (3): > > > ethdev: add actions to modify TCP header fields > > > app/testpmd: add actions to modify TCP header fields > > > net/mlx5: update modify header using Direct Verbs > > > > > > app/test-pmd/cmdline_flow.c | 100 ++++++++++++ > > > doc/guides/prog_guide/rte_flow.rst | 68 ++++++++ > > > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 16 ++ > > > drivers/net/mlx5/mlx5_flow.h | 10 +- > > > drivers/net/mlx5/mlx5_flow_dv.c | 239 > > > ++++++++++++++++++++++++++++ > > > drivers/net/mlx5/mlx5_prm.h | 12 ++ > > > lib/librte_ethdev/rte_flow.c | 4 + > > > lib/librte_ethdev/rte_flow.h | 61 +++++++ > > > 8 files changed, 509 insertions(+), 1 deletion(-) > > > > > > -- > > > 1.8.3.1