mbox series

[v5,00/18] NXP DPAA ETH driver enhancement and fixes

Message ID 20241001110325.4173762-1-hemant.agrawal@nxp.com (mailing list archive)
Headers
Series NXP DPAA ETH driver enhancement and fixes |

Message

Hemant Agrawal Oct. 1, 2024, 11:03 a.m. UTC 
v5: fix individual patch compilation and checkpatch warning
v4: fix clang compilation issues
v3: addressed Ferruh's comments 
 - dropped Tx rate limit API patch
 - added one small bug fix
 - fixed removal/add of fman_offline type

v2: address review comments
 - improve commit message
 - add documentarion for new functions
 - make IEEE1588 config runtime

This series adds several enhancement to the NXP DPAA Ethernet driver.

Primarily:
1. timestamp and IEEE 1588 support
2. OH and ONIC based virtual port config in DPAA
3. frame display and debugging infra


Gagandeep Singh (3):
  bus/dpaa: fix PFDRs leaks due to FQRNIs
  net/dpaa: support mempool debug
  net/dpaa: improve the dpaa port cleanup

Hemant Agrawal (5):
  bus/dpaa: fix VSP for 1G fm1-mac9 and 10
  bus/dpaa: fix the fman details status
  bus/dpaa: add port buffer manager stats
  net/dpaa: implement detailed packet parsing
  net/dpaa: enhance DPAA frame display

Jun Yang (2):
  net/dpaa: share MAC FMC scheme and CC parse
  net/dpaa: improve dpaa errata A010022 handling

Rohit Raj (3):
  net/dpaa: fix typecasting ch ID to u32
  bus/dpaa: add OH port mode for dpaa eth
  bus/dpaa: add ONIC port mode for the DPAA eth

Vanshika Shukla (5):
  net/dpaa: support Tx confirmation to enable PTP
  net/dpaa: add support to separate Tx conf queues
  net/dpaa: support Rx/Tx timestamp read
  net/dpaa: support IEEE 1588 PTP
  net/dpaa: fix reallocate_mbuf handling

 doc/guides/nics/dpaa.rst                  |  64 ++-
 doc/guides/nics/features/dpaa.ini         |   2 +
 drivers/bus/dpaa/base/fman/fman.c         | 583 +++++++++++++++++++---
 drivers/bus/dpaa/base/fman/fman_hw.c      | 102 +++-
 drivers/bus/dpaa/base/fman/netcfg_layer.c |  19 +-
 drivers/bus/dpaa/base/qbman/qman.c        |  46 +-
 drivers/bus/dpaa/dpaa_bus.c               |  37 +-
 drivers/bus/dpaa/include/fman.h           | 112 ++++-
 drivers/bus/dpaa/include/fsl_fman.h       |  12 +
 drivers/bus/dpaa/include/fsl_qman.h       |   4 +-
 drivers/bus/dpaa/version.map              |   4 +
 drivers/net/dpaa/dpaa_ethdev.c            | 428 +++++++++++++---
 drivers/net/dpaa/dpaa_ethdev.h            |  68 ++-
 drivers/net/dpaa/dpaa_flow.c              |  66 +--
 drivers/net/dpaa/dpaa_fmc.c               | 421 ++++++++++------
 drivers/net/dpaa/dpaa_ptp.c               | 118 +++++
 drivers/net/dpaa/dpaa_rxtx.c              | 378 ++++++++++++--
 drivers/net/dpaa/dpaa_rxtx.h              | 152 +++---
 drivers/net/dpaa/meson.build              |   1 +
 19 files changed, 2105 insertions(+), 512 deletions(-)
 create mode 100644 drivers/net/dpaa/dpaa_ptp.c

Comments

Ferruh Yigit Oct. 2, 2024, 12:41 a.m. UTC | #1 
On 10/1/2024 12:03 PM, Hemant Agrawal wrote:
> v5: fix individual patch compilation and checkpatch warning
> v4: fix clang compilation issues
> v3: addressed Ferruh's comments 
>  - dropped Tx rate limit API patch
>  - added one small bug fix
>  - fixed removal/add of fman_offline type
> 
> v2: address review comments
>  - improve commit message
>  - add documentarion for new functions
>  - make IEEE1588 config runtime
> 
> This series adds several enhancement to the NXP DPAA Ethernet driver.
> 
> Primarily:
> 1. timestamp and IEEE 1588 support
> 2. OH and ONIC based virtual port config in DPAA
> 3. frame display and debugging infra
> 
> 
> Gagandeep Singh (3):
>   bus/dpaa: fix PFDRs leaks due to FQRNIs
>   net/dpaa: support mempool debug
>   net/dpaa: improve the dpaa port cleanup
> 
> Hemant Agrawal (5):
>   bus/dpaa: fix VSP for 1G fm1-mac9 and 10
>   bus/dpaa: fix the fman details status
>   bus/dpaa: add port buffer manager stats
>   net/dpaa: implement detailed packet parsing
>   net/dpaa: enhance DPAA frame display
> 
> Jun Yang (2):
>   net/dpaa: share MAC FMC scheme and CC parse
>   net/dpaa: improve dpaa errata A010022 handling
> 
> Rohit Raj (3):
>   net/dpaa: fix typecasting ch ID to u32
>   bus/dpaa: add OH port mode for dpaa eth
>   bus/dpaa: add ONIC port mode for the DPAA eth
> 
> Vanshika Shukla (5):
>   net/dpaa: support Tx confirmation to enable PTP
>   net/dpaa: add support to separate Tx conf queues
>   net/dpaa: support Rx/Tx timestamp read
>   net/dpaa: support IEEE 1588 PTP
>   net/dpaa: fix reallocate_mbuf handling
>

Adding implied ack from Hemant:
For series,
Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>


Series applied to dpdk-next-net/main, thanks.
David Marchand Oct. 4, 2024, 2:03 p.m. UTC | #2 
On Tue, Oct 1, 2024 at 1:03 PM Hemant Agrawal <hemant.agrawal@nxp.com> wrote:
>
> v5: fix individual patch compilation and checkpatch warning
> v4: fix clang compilation issues
> v3: addressed Ferruh's comments
>  - dropped Tx rate limit API patch
>  - added one small bug fix
>  - fixed removal/add of fman_offline type
>
> v2: address review comments
>  - improve commit message
>  - add documentarion for new functions
>  - make IEEE1588 config runtime
>
> This series adds several enhancement to the NXP DPAA Ethernet driver.
>
> Primarily:
> 1. timestamp and IEEE 1588 support
> 2. OH and ONIC based virtual port config in DPAA
> 3. frame display and debugging infra
>
>
> Gagandeep Singh (3):
>   bus/dpaa: fix PFDRs leaks due to FQRNIs
>   net/dpaa: support mempool debug
>   net/dpaa: improve the dpaa port cleanup
>
> Hemant Agrawal (5):
>   bus/dpaa: fix VSP for 1G fm1-mac9 and 10
>   bus/dpaa: fix the fman details status
>   bus/dpaa: add port buffer manager stats
>   net/dpaa: implement detailed packet parsing
>   net/dpaa: enhance DPAA frame display
>
> Jun Yang (2):
>   net/dpaa: share MAC FMC scheme and CC parse
>   net/dpaa: improve dpaa errata A010022 handling
>
> Rohit Raj (3):
>   net/dpaa: fix typecasting ch ID to u32
>   bus/dpaa: add OH port mode for dpaa eth
>   bus/dpaa: add ONIC port mode for the DPAA eth
>
> Vanshika Shukla (5):
>   net/dpaa: support Tx confirmation to enable PTP
>   net/dpaa: add support to separate Tx conf queues
>   net/dpaa: support Rx/Tx timestamp read
>   net/dpaa: support IEEE 1588 PTP
>   net/dpaa: fix reallocate_mbuf handling
>
>  doc/guides/nics/dpaa.rst                  |  64 ++-
>  doc/guides/nics/features/dpaa.ini         |   2 +
>  drivers/bus/dpaa/base/fman/fman.c         | 583 +++++++++++++++++++---
>  drivers/bus/dpaa/base/fman/fman_hw.c      | 102 +++-
>  drivers/bus/dpaa/base/fman/netcfg_layer.c |  19 +-
>  drivers/bus/dpaa/base/qbman/qman.c        |  46 +-
>  drivers/bus/dpaa/dpaa_bus.c               |  37 +-
>  drivers/bus/dpaa/include/fman.h           | 112 ++++-
>  drivers/bus/dpaa/include/fsl_fman.h       |  12 +
>  drivers/bus/dpaa/include/fsl_qman.h       |   4 +-
>  drivers/bus/dpaa/version.map              |   4 +
>  drivers/net/dpaa/dpaa_ethdev.c            | 428 +++++++++++++---
>  drivers/net/dpaa/dpaa_ethdev.h            |  68 ++-
>  drivers/net/dpaa/dpaa_flow.c              |  66 +--
>  drivers/net/dpaa/dpaa_fmc.c               | 421 ++++++++++------
>  drivers/net/dpaa/dpaa_ptp.c               | 118 +++++
>  drivers/net/dpaa/dpaa_rxtx.c              | 378 ++++++++++++--
>  drivers/net/dpaa/dpaa_rxtx.h              | 152 +++---
>  drivers/net/dpaa/meson.build              |   1 +
>  19 files changed, 2105 insertions(+), 512 deletions(-)
>  create mode 100644 drivers/net/dpaa/dpaa_ptp.c

Please Hemant, I see this series reintroduces \n issue in
drivers/bus/dpaa/base/fman (use of macro FMAN_ERR).

Can you send fixes against next-net ?
Thanks.