Message ID | 20240408130924.232154-1-mtahhan@redhat.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9EAD443DA3; Mon, 8 Apr 2024 15:09:34 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 14BB5402C9; Mon, 8 Apr 2024 15:09:34 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 4A18540041 for <dev@dpdk.org>; Mon, 8 Apr 2024 15:09:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712581771; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=aoGU0hkbmSqtkK37Rq1+ihDOG1QlbXPY1TLwp7N6g2s=; b=J7kBS/6Ti6mnqLXCvSQN+u7E3WUpsdCWZIRE5AhQKuuaneAfGI7ALMsWqUlBkbwMP8xxFs E0or8UA3kVmfwDbnFnOWbd9iETihSbNmNUhff+fdSKNfoZD34PJqo63ekPlbxieUml3mVM Xe4GIiLmuSenLVDku5NUyAADX0UF5CE= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-653-qb8Q4KbsPASoqP-rkfx9NQ-1; Mon, 08 Apr 2024 09:09:29 -0400 X-MC-Unique: qb8Q4KbsPASoqP-rkfx9NQ-1 Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-430d32a0a64so47825091cf.3 for <dev@dpdk.org>; Mon, 08 Apr 2024 06:09:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712581769; x=1713186569; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=aoGU0hkbmSqtkK37Rq1+ihDOG1QlbXPY1TLwp7N6g2s=; b=ZtQNXms7gZqCXCoYp6A6EQOtKM15uXkWYltzvsYBv1sw7NV/T0SAPS8UEYULAOluAm qYy64vuz7iSyUTP0lt+kgNY3d4CaVRReVLlGfzRKkTKR752c387RjcZjg/gOzM87abYv cT2znQNQCAbT0UzRywekG3e4TY6MKtXtJe5s80YUbbgYcuVtLDT9d228iPcwaXfcORrr zcgB+ruQpL4beVxhPw1VK1KIUx2jijSd12TrpC7EHwp0Dg6VcmZa9xdl7Z2tZ/49+yGY vrOKWO24LaOvxWvZlp6tBgIN199qaPiKXoQt+eR7hAby9/LkYuN1U6xGD1LzLXYjLMHR 8aFA== X-Gm-Message-State: AOJu0YxLpFNX2w7vTVRD8c7/cTmW6aohuN57ETxx5uuruX0pDCStGCGA 380vNC3KqMCkH1omtveZhVOP/qTjrwwfERu0j0rSNn1NE3DrQXs5INHeC5npOE9fzYgQzdkybMa Y450WIdE6Eu/0rsc3vxE6DgDrPxSXYZNZV5kmYLch X-Received: by 2002:a05:622a:60b:b0:432:e8c4:2e6b with SMTP id z11-20020a05622a060b00b00432e8c42e6bmr11246122qta.19.1712581769123; Mon, 08 Apr 2024 06:09:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG/0pYN/h7yb8ixgZqbaJtEtdjIoJUN6IuJM49GCZQbA2KgS5I7Ak8p1G5D2Wv82UJSZYLBeg== X-Received: by 2002:a05:622a:60b:b0:432:e8c4:2e6b with SMTP id z11-20020a05622a060b00b00432e8c42e6bmr11246097qta.19.1712581768807; Mon, 08 Apr 2024 06:09:28 -0700 (PDT) Received: from nfvsdn-06.redhat.com (nat-pool-232-132.redhat.com. [66.187.232.132]) by smtp.gmail.com with ESMTPSA id kg18-20020a05622a761200b00434c9e59ab4sm20945qtb.25.2024.04.08.06.09.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Apr 2024 06:09:27 -0700 (PDT) From: Maryam Tahhan <mtahhan@redhat.com> To: ferruh.yigit@amd.com, stephen@networkplumber.org, lihuisong@huawei.com, fengchengwen@huawei.com, liuyonglong@huawei.com, david.marchand@redhat.com, shibin.koikkara.reeny@intel.com, ciara.loftus@intel.com Cc: dev@dpdk.org, Maryam Tahhan <mtahhan@redhat.com> Subject: [v14 0/3] net/af_xdp: fix multi interface support for K8s Date: Mon, 8 Apr 2024 09:09:19 -0400 Message-ID: <20240408130924.232154-1-mtahhan@redhat.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org |
Series |
net/af_xdp: fix multi interface support for K8s
|
|
Message
Maryam Tahhan
April 8, 2024, 1:09 p.m. UTC
The original `use_cni` implementation was limited to
supporting only a single netdev in a DPDK pod. This patchset
aims to fix this limitation transparently to the end user.
It will also enable compatibility with the latest AF_XDP
Device Plugin.
Signed-off-by: Maryam Tahhan <mtahhan@redhat.com>
---
v14:
* Fixup bpf_map_update_elem() in compat.h to use xsk fd as the
third argument.
v13:
* Fixup checkpatch issues.
v12:
* Ensure backwards compability with libbpf versions that don't support
xsk_socket__update_xskmap().
v11:
* Fixed up typos picked up by checkpatch.
v10:
* Add UDS acronym
* Update `use_cni` in docs with ``use_cni``
* Remove reference to limitations and simply document behaviour
before and after DPDK 23.11.
v9:
* Fixup checkpatch issues.
v8:
* Go back to using `use_cni` vdev argument
* Introduce `use_map_pinning` vdev param.
* Rename `uds_path` to `dp_path` so that it can be used
with map pinning as well as `use_cni`.
* Set `dp_path` internally in the AF_XDP PMD if it's
not configured by the user.
* Clean up the original `use_cni` documentation separately
to coding changes.
v7:
* Give a more descriptive commit msg headline.
* Fixup typos in documentation.
v6:
* Add link to PR 81 in commit message
* Add release notes changes to this patchset
v5:
* Fix alignment for ETH_AF_XDP_USE_DP_UDS_PATH_ARG
* Remove use_cni references in af_xdp.rst
v4:
* Rename af_xdp_cni.rst to af_xdp_dp.rst
* Removed all incorrect references to CNI throughout af_xdp
PMD file.
* Fixed Typos in af_xdp_dp.rst
v3:
* Remove `use_cni` vdev argument as it's no longer needed.
* Update incorrect CNI references for the AF_XDP DP in the
documentation.
* Update the documentation to run a simple example with the
AF_XDP DP plugin in K8s.
v2:
* Rename sock_path to uds_path.
* Update documentation to reflect when CAP_BPF is needed.
* Fix testpmd arguments in the provided example for Pods.
* Use AF_XDP API to update the xskmap entry.
---
Maryam Tahhan (3):
docs: AF_XDP Device Plugin
net/af_xdp: fix multi interface support for K8s
net/af_xdp: support AF_XDP DP pinned maps
doc/guides/howto/af_xdp_cni.rst | 253 ------------------
doc/guides/howto/af_xdp_dp.rst | 340 +++++++++++++++++++++++++
doc/guides/howto/index.rst | 2 +-
doc/guides/nics/af_xdp.rst | 44 +++-
doc/guides/rel_notes/release_24_07.rst | 17 ++
drivers/net/af_xdp/compat.h | 15 ++
drivers/net/af_xdp/meson.build | 4 +
drivers/net/af_xdp/rte_eth_af_xdp.c | 170 +++++++++----
8 files changed, 543 insertions(+), 302 deletions(-)
delete mode 100644 doc/guides/howto/af_xdp_cni.rst
create mode 100644 doc/guides/howto/af_xdp_dp.rst
--
2.41.0
Comments
> > The original `use_cni` implementation was limited to > supporting only a single netdev in a DPDK pod. This patchset > aims to fix this limitation transparently to the end user. > It will also enable compatibility with the latest AF_XDP > Device Plugin. > > Signed-off-by: Maryam Tahhan <mtahhan@redhat.com> Thanks Maryam. For the series, Acked-by: Ciara Loftus <ciara.loftus@intel.com> > --- > v14: > * Fixup bpf_map_update_elem() in compat.h to use xsk fd as the > third argument. > > v13: > * Fixup checkpatch issues. > > v12: > * Ensure backwards compability with libbpf versions that don't support > xsk_socket__update_xskmap(). > > v11: > * Fixed up typos picked up by checkpatch. > > v10: > * Add UDS acronym > * Update `use_cni` in docs with ``use_cni`` > * Remove reference to limitations and simply document behaviour > before and after DPDK 23.11. > > v9: > * Fixup checkpatch issues. > > v8: > * Go back to using `use_cni` vdev argument > * Introduce `use_map_pinning` vdev param. > * Rename `uds_path` to `dp_path` so that it can be used > with map pinning as well as `use_cni`. > * Set `dp_path` internally in the AF_XDP PMD if it's > not configured by the user. > * Clean up the original `use_cni` documentation separately > to coding changes. > > v7: > * Give a more descriptive commit msg headline. > * Fixup typos in documentation. > > v6: > * Add link to PR 81 in commit message > * Add release notes changes to this patchset > > v5: > * Fix alignment for ETH_AF_XDP_USE_DP_UDS_PATH_ARG > * Remove use_cni references in af_xdp.rst > > v4: > * Rename af_xdp_cni.rst to af_xdp_dp.rst > * Removed all incorrect references to CNI throughout af_xdp > PMD file. > * Fixed Typos in af_xdp_dp.rst > > v3: > * Remove `use_cni` vdev argument as it's no longer needed. > * Update incorrect CNI references for the AF_XDP DP in the > documentation. > * Update the documentation to run a simple example with the > AF_XDP DP plugin in K8s. > > v2: > * Rename sock_path to uds_path. > * Update documentation to reflect when CAP_BPF is needed. > * Fix testpmd arguments in the provided example for Pods. > * Use AF_XDP API to update the xskmap entry. > --- > > Maryam Tahhan (3): > docs: AF_XDP Device Plugin > net/af_xdp: fix multi interface support for K8s > net/af_xdp: support AF_XDP DP pinned maps > > doc/guides/howto/af_xdp_cni.rst | 253 ------------------ > doc/guides/howto/af_xdp_dp.rst | 340 +++++++++++++++++++++++++ > doc/guides/howto/index.rst | 2 +- > doc/guides/nics/af_xdp.rst | 44 +++- > doc/guides/rel_notes/release_24_07.rst | 17 ++ > drivers/net/af_xdp/compat.h | 15 ++ > drivers/net/af_xdp/meson.build | 4 + > drivers/net/af_xdp/rte_eth_af_xdp.c | 170 +++++++++---- > 8 files changed, 543 insertions(+), 302 deletions(-) > delete mode 100644 doc/guides/howto/af_xdp_cni.rst > create mode 100644 doc/guides/howto/af_xdp_dp.rst > > -- > 2.41.0
Recheck-request: iol-unit-arm64-testing On 4/8/2024 2:09 PM, Maryam Tahhan wrote: > The original `use_cni` implementation was limited to > supporting only a single netdev in a DPDK pod. This patchset > aims to fix this limitation transparently to the end user. > It will also enable compatibility with the latest AF_XDP > Device Plugin. > > Signed-off-by: Maryam Tahhan <mtahhan@redhat.com>
On 4/8/2024 2:19 PM, Loftus, Ciara wrote: >> The original `use_cni` implementation was limited to >> supporting only a single netdev in a DPDK pod. This patchset >> aims to fix this limitation transparently to the end user. >> It will also enable compatibility with the latest AF_XDP >> Device Plugin. >> >> Signed-off-by: Maryam Tahhan <mtahhan@redhat.com> > Thanks Maryam. > > For the series, > Acked-by: Ciara Loftus <ciara.loftus@intel.com> > Series applied to dpdk-next-net/main, thanks.