From patchwork Wed Mar 13 12:59:30 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxime Coquelin X-Patchwork-Id: 774 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CA83243C9F; Wed, 13 Mar 2024 13:59:40 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8B4B740A84; Wed, 13 Mar 2024 13:59:40 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 06084402B8 for ; Wed, 13 Mar 2024 13:59:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710334778; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=vFW0/X4ABNNkkRq8FEn0lEcUEdO6lsVkVLWsxEPr0B0=; b=g13xtkC225G0LOfixh/icvAN9q2hBeNMvjWw3P0XPWanh7vqlA88fIRtTeiQtG2wr80s6Z HnPH4URdhC9WsVhc33iSgb/5ps+tyFsWd2+/K3PyHGNrBqoVpxjYlTzcrjuanUd4GJv/LK fni4BVh3pAtsIVyKtCODBeJwFfSSi5g= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-451-3O7kMoUzNAOUJ9HzVGOZlA-1; Wed, 13 Mar 2024 08:59:37 -0400 X-MC-Unique: 3O7kMoUzNAOUJ9HzVGOZlA-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 933BA3C02460; Wed, 13 Mar 2024 12:59:36 +0000 (UTC) Received: from max-p1.redhat.com (unknown [10.39.208.24]) by smtp.corp.redhat.com (Postfix) with ESMTP id 012E9492BC6; Wed, 13 Mar 2024 12:59:34 +0000 (UTC) From: Maxime Coquelin To: dev@dpdk.org, david.marchand@redhat.com, chenbox@nvidia.com, schalla@marvell.com Cc: Maxime Coquelin Subject: [PATCH v2 0/2] net/virtio: vhost-vdpa fixes Date: Wed, 13 Mar 2024 13:59:30 +0100 Message-ID: <20240313125932.1878279-1-maxime.coquelin@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org While investigating vhost-vdpa initialization issue with mlx5 vDPA, we found two issues fixed by following patches. In this v2, the control queue issue mentioned in v1 is fixed. It turned out to the control queue being enabled only if multiqueue was negotiated. It is fixed by enabling it at device startup, and disabling it at stop time. We still have an issue on one of our setup with mlx5, where the mlx5 device sets VIRTIO_CONFIG_S_FAILED status, it is currently being investigated. Changes in v2: -------------- - Fix cvq enablement - Fix typo in commit message (David) Maxime Coquelin (2): net/virtio: fix vDPA device init advertising control queue net/virtio: fix notification area initialization .../net/virtio/virtio_user/virtio_user_dev.c | 27 +++++++++++++------ 1 file changed, 19 insertions(+), 8 deletions(-)