From patchwork Mon Mar 11 23:21:08 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yoan Picchi X-Patchwork-Id: 761 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 77E9C43C5A; Tue, 12 Mar 2024 00:21:23 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 46AB24013F; Tue, 12 Mar 2024 00:21:23 +0100 (CET) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mails.dpdk.org (Postfix) with ESMTP id 5F8054013F for ; Tue, 12 Mar 2024 00:21:22 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BB3D3FEC; Mon, 11 Mar 2024 16:21:58 -0700 (PDT) Received: from octeon10-1.usa.Arm.com (unknown [10.118.91.161]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A4A863F64C; Mon, 11 Mar 2024 16:21:21 -0700 (PDT) From: Yoan Picchi To: Cc: dev@dpdk.org, nd@arm.com, Yoan Picchi Subject: [PATCH v6 0/4] hash: add SVE support for bulk key lookup Date: Mon, 11 Mar 2024 23:21:08 +0000 Message-Id: <20240311232112.736613-1-yoan.picchi@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231020165159.1649282-1-yoan.picchi@arm.com> References: <20231020165159.1649282-1-yoan.picchi@arm.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This patchset adds SVE support for the signature comparison in the cuckoo hash lookup and improves the existing NEON implementation. These optimizations required changes to the data format and signature of the relevant functions to support dense hitmasks (no padding) and having the primary and secondary hitmasks interleaved instead of being in their own array each. Benchmarking the cuckoo hash perf test, I observed this effect on speed: There are no significant changes on Intel (ran on Sapphire Rapids) Neon is up to 7-10% faster (ran on ampere altra) 128b SVE is about 3-5% slower than the optimized neon (ran on a graviton 3 cloud instance) 256b SVE is about 0-3% slower than the optimized neon (ran on a graviton 3 cloud instance) V2->V3: Remove a redundant if in the test Change a couple int to uint16_t in compare_signatures_dense Several codding-style fix V3->V4: Rebase V4->V5: Commit message V5->V6: Move the arch-specific code into new arch-specific files Isolate the data struture refactor from adding SVE Yoan Picchi (4): hash: pack the hitmask for hash in bulk lookup hash: optimize compare signature for NEON test/hash: check bulk lookup of keys after collision hash: add SVE support for bulk key lookup .mailmap | 2 + app/test/test_hash.c | 99 ++++++++--- lib/hash/arch/arm/compare_signatures.h | 117 +++++++++++++ lib/hash/arch/common/compare_signatures.h | 38 +++++ lib/hash/arch/x86/compare_signatures.h | 53 ++++++ lib/hash/rte_cuckoo_hash.c | 197 ++++++++++++---------- lib/hash/rte_cuckoo_hash.h | 1 + 7 files changed, 392 insertions(+), 115 deletions(-) create mode 100644 lib/hash/arch/arm/compare_signatures.h create mode 100644 lib/hash/arch/common/compare_signatures.h create mode 100644 lib/hash/arch/x86/compare_signatures.h