mbox series

[v6,0/6] changes for 24.03

Message ID 20240207171350.242156-1-hernan.vargas@intel.com (mailing list archive)
Headers
Series changes for 24.03 |

Message

Hernan Vargas Feb. 7, 2024, 5:13 p.m. UTC 
  v6: Rework total_num_queues in separate commit. Fix typo in comment.
v5: Created separate commit for doc fix. Cosmetic uppercase changes.
v4: Targeting 24.03. Updated FPGA PMD based on review comments.
v3: Made changes requested during review.
v2: Targeting 23.11. Update in commits 1,2 based on review comments.
v1: Targeting 23.07 if possible. Add support for AGX100 (N6000) and corner case fixes.

Hernan Vargas (6):
  doc: fix fpga 5gnr configuration values
  baseband/fpga_5gnr_fec: renaming for consistency
  baseband/fpga_5gnr_fec: add Vista Creek variant
  baseband/fpga_5gnr_fec: rework total number queues
  baseband/fpga_5gnr_fec: add AGX100 support
  baseband/fpga_5gnr_fec: cosmetic comment changes

 doc/guides/bbdevs/fpga_5gnr_fec.rst           |   76 +-
 drivers/baseband/fpga_5gnr_fec/agx100_pmd.h   |  273 ++
 .../baseband/fpga_5gnr_fec/fpga_5gnr_fec.h    |  353 +--
 .../fpga_5gnr_fec/rte_fpga_5gnr_fec.c         | 2270 ++++++++++++-----
 .../fpga_5gnr_fec/rte_pmd_fpga_5gnr_fec.h     |   27 +-
 drivers/baseband/fpga_5gnr_fec/vc_5gnr_pmd.h  |  139 +
 6 files changed, 2204 insertions(+), 934 deletions(-)
 create mode 100644 drivers/baseband/fpga_5gnr_fec/agx100_pmd.h
 create mode 100644 drivers/baseband/fpga_5gnr_fec/vc_5gnr_pmd.h

Comments

Maxime Coquelin Feb. 8, 2024, 10:45 a.m. UTC | #1 
On 2/7/24 18:13, Hernan Vargas wrote:
> v6: Rework total_num_queues in separate commit. Fix typo in comment.
> v5: Created separate commit for doc fix. Cosmetic uppercase changes.
> v4: Targeting 24.03. Updated FPGA PMD based on review comments.
> v3: Made changes requested during review.
> v2: Targeting 23.11. Update in commits 1,2 based on review comments.
> v1: Targeting 23.07 if possible. Add support for AGX100 (N6000) and corner case fixes.
> 
> Hernan Vargas (6):
>    doc: fix fpga 5gnr configuration values
>    baseband/fpga_5gnr_fec: renaming for consistency
>    baseband/fpga_5gnr_fec: add Vista Creek variant
>    baseband/fpga_5gnr_fec: rework total number queues
>    baseband/fpga_5gnr_fec: add AGX100 support
>    baseband/fpga_5gnr_fec: cosmetic comment changes
> 
>   doc/guides/bbdevs/fpga_5gnr_fec.rst           |   76 +-
>   drivers/baseband/fpga_5gnr_fec/agx100_pmd.h   |  273 ++
>   .../baseband/fpga_5gnr_fec/fpga_5gnr_fec.h    |  353 +--
>   .../fpga_5gnr_fec/rte_fpga_5gnr_fec.c         | 2270 ++++++++++++-----
>   .../fpga_5gnr_fec/rte_pmd_fpga_5gnr_fec.h     |   27 +-
>   drivers/baseband/fpga_5gnr_fec/vc_5gnr_pmd.h  |  139 +
>   6 files changed, 2204 insertions(+), 934 deletions(-)
>   create mode 100644 drivers/baseband/fpga_5gnr_fec/agx100_pmd.h
>   create mode 100644 drivers/baseband/fpga_5gnr_fec/vc_5gnr_pmd.h
> 

The series does not apply, and 3-way merge does not work.
could you please rebase on top of next-baseband?

Thanks,
Maxime
Hernan Vargas Feb. 8, 2024, 4:56 p.m. UTC | #2 
Hi Maxime,

I just submitted v7 of this series rebased on top of next-baseband.

Thanks,
Hernan

> -----Original Message-----
> From: Maxime Coquelin <maxime.coquelin@redhat.com>
> Sent: Thursday, February 8, 2024 4:45 AM
> To: Vargas, Hernan <hernan.vargas@intel.com>; dev@dpdk.org;
> gakhil@marvell.com; Rix, Tom <trix@redhat.com>
> Cc: Chautru, Nicolas <nicolas.chautru@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>
> Subject: Re: [PATCH v6 0/6] changes for 24.03
> 
> 
> 
> On 2/7/24 18:13, Hernan Vargas wrote:
> > v6: Rework total_num_queues in separate commit. Fix typo in comment.
> > v5: Created separate commit for doc fix. Cosmetic uppercase changes.
> > v4: Targeting 24.03. Updated FPGA PMD based on review comments.
> > v3: Made changes requested during review.
> > v2: Targeting 23.11. Update in commits 1,2 based on review comments.
> > v1: Targeting 23.07 if possible. Add support for AGX100 (N6000) and corner
> case fixes.
> >
> > Hernan Vargas (6):
> >    doc: fix fpga 5gnr configuration values
> >    baseband/fpga_5gnr_fec: renaming for consistency
> >    baseband/fpga_5gnr_fec: add Vista Creek variant
> >    baseband/fpga_5gnr_fec: rework total number queues
> >    baseband/fpga_5gnr_fec: add AGX100 support
> >    baseband/fpga_5gnr_fec: cosmetic comment changes
> >
> >   doc/guides/bbdevs/fpga_5gnr_fec.rst           |   76 +-
> >   drivers/baseband/fpga_5gnr_fec/agx100_pmd.h   |  273 ++
> >   .../baseband/fpga_5gnr_fec/fpga_5gnr_fec.h    |  353 +--
> >   .../fpga_5gnr_fec/rte_fpga_5gnr_fec.c         | 2270 ++++++++++++-----
> >   .../fpga_5gnr_fec/rte_pmd_fpga_5gnr_fec.h     |   27 +-
> >   drivers/baseband/fpga_5gnr_fec/vc_5gnr_pmd.h  |  139 +
> >   6 files changed, 2204 insertions(+), 934 deletions(-)
> >   create mode 100644 drivers/baseband/fpga_5gnr_fec/agx100_pmd.h
> >   create mode 100644 drivers/baseband/fpga_5gnr_fec/vc_5gnr_pmd.h
> >
> 
> The series does not apply, and 3-way merge does not work.
> could you please rebase on top of next-baseband?
> 
> Thanks,
> Maxime
Maxime Coquelin Feb. 9, 2024, 10:01 a.m. UTC | #3 
On 2/8/24 17:56, Vargas, Hernan wrote:
> Hi Maxime,
> 
> I just submitted v7 of this series rebased on top of next-baseband.

Thanks, that's all good.
The next-baseband PR for -rc1 will be ready once github actions run has
completed:
https://github.com/DPDK/dpdk/actions/runs/7842210322

Maxime
> Thanks,
> Hernan
> 
>> -----Original Message-----
>> From: Maxime Coquelin <maxime.coquelin@redhat.com>
>> Sent: Thursday, February 8, 2024 4:45 AM
>> To: Vargas, Hernan <hernan.vargas@intel.com>; dev@dpdk.org;
>> gakhil@marvell.com; Rix, Tom <trix@redhat.com>
>> Cc: Chautru, Nicolas <nicolas.chautru@intel.com>; Zhang, Qi Z
>> <qi.z.zhang@intel.com>
>> Subject: Re: [PATCH v6 0/6] changes for 24.03
>>
>>
>>
>> On 2/7/24 18:13, Hernan Vargas wrote:
>>> v6: Rework total_num_queues in separate commit. Fix typo in comment.
>>> v5: Created separate commit for doc fix. Cosmetic uppercase changes.
>>> v4: Targeting 24.03. Updated FPGA PMD based on review comments.
>>> v3: Made changes requested during review.
>>> v2: Targeting 23.11. Update in commits 1,2 based on review comments.
>>> v1: Targeting 23.07 if possible. Add support for AGX100 (N6000) and corner
>> case fixes.
>>>
>>> Hernan Vargas (6):
>>>     doc: fix fpga 5gnr configuration values
>>>     baseband/fpga_5gnr_fec: renaming for consistency
>>>     baseband/fpga_5gnr_fec: add Vista Creek variant
>>>     baseband/fpga_5gnr_fec: rework total number queues
>>>     baseband/fpga_5gnr_fec: add AGX100 support
>>>     baseband/fpga_5gnr_fec: cosmetic comment changes
>>>
>>>    doc/guides/bbdevs/fpga_5gnr_fec.rst           |   76 +-
>>>    drivers/baseband/fpga_5gnr_fec/agx100_pmd.h   |  273 ++
>>>    .../baseband/fpga_5gnr_fec/fpga_5gnr_fec.h    |  353 +--
>>>    .../fpga_5gnr_fec/rte_fpga_5gnr_fec.c         | 2270 ++++++++++++-----
>>>    .../fpga_5gnr_fec/rte_pmd_fpga_5gnr_fec.h     |   27 +-
>>>    drivers/baseband/fpga_5gnr_fec/vc_5gnr_pmd.h  |  139 +
>>>    6 files changed, 2204 insertions(+), 934 deletions(-)
>>>    create mode 100644 drivers/baseband/fpga_5gnr_fec/agx100_pmd.h
>>>    create mode 100644 drivers/baseband/fpga_5gnr_fec/vc_5gnr_pmd.h
>>>
>>
>> The series does not apply, and 3-way merge does not work.
>> could you please rebase on top of next-baseband?
>>
>> Thanks,
>> Maxime
>