[v7,00/19] Replace use of PMD logtype

Message ID 20240203041125.285232-1-stephen@networkplumber.org (mailing list archive)
Headers
Series Replace use of PMD logtype |

Message

Stephen Hemminger Feb. 3, 2024, 4:10 a.m. UTC
  Many of the uses of PMD logtype have already been fixed.
But there are still some leftovers, mostly places where
drivers had a logtype but did not use them.

Note: this is not an ABI break, but could break out of
      tree drivers that never updated to use dynamic logtype.
      DPDK never guaranteed that that would not happen.

v7 - drop changes to newlines
     drop changes related to RTE_LOG_DP
     rebase now that other stuff has changed

Stephen Hemminger (19):
  common/sfc_efx: remove use of PMD logtype
  mempool/dpaa2: use driver logtype not PMD
  net/dpaa: use dedicated logtype not PMD
  net/dpaa2: used dedicated logtype not PMD
  net/mrvl: do not use PMD logtype
  net/mvpp2: use dedicated logtype
  net/nfb: use dynamic logtype
  net/vmxnet3: used dedicated logtype not PMD
  raw/cnxk: replace PMD logtype with dynamic type
  crypto/scheduler: replace use of logtype PMD
  crypto/armv8: do not use PMD logtype
  crypto/caam_jr: use dedicated logtype
  crypto/ccp: do not use PMD logtype
  crypto/dpaa_sec, crypto/dpaa2_sec: use dedicated logtype
  event/dpaa, event/dpaa2: use dedicated logtype
  event/dlb2: use dedicated logtype
  event/skeleton: replace logtype PMD with dynamic type
  examples/fips_validation: replace use of PMD logtype
  log: remove PMD log type

 drivers/common/cnxk/roc_platform.h            | 16 ++++---
 drivers/common/sfc_efx/sfc_efx.c              | 11 +----
 drivers/common/sfc_efx/sfc_efx_log.h          |  2 +-
 drivers/crypto/armv8/rte_armv8_pmd.c          |  4 +-
 drivers/crypto/caam_jr/caam_jr.c              |  5 +--
 drivers/crypto/ccp/rte_ccp_pmd.c              | 11 +++--
 drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c   |  6 +--
 drivers/crypto/dpaa_sec/dpaa_sec.c            | 30 ++++++-------
 drivers/crypto/scheduler/scheduler_pmd.c      |  4 +-
 drivers/event/dlb2/dlb2.c                     |  5 +--
 drivers/event/dpaa/dpaa_eventdev.c            |  2 +-
 drivers/event/dpaa2/dpaa2_eventdev.c          |  4 +-
 drivers/event/dpaa2/dpaa2_eventdev_selftest.c |  6 +--
 drivers/event/skeleton/skeleton_eventdev.c    |  4 +-
 drivers/event/skeleton/skeleton_eventdev.h    |  8 +++-
 drivers/mempool/dpaa2/dpaa2_hw_mempool.c      |  4 +-
 drivers/net/dpaa/dpaa_ethdev.c                |  6 +--
 drivers/net/dpaa2/dpaa2_ethdev.c              |  2 +-
 drivers/net/dpaa2/dpaa2_sparser.c             |  4 +-
 drivers/net/mvpp2/mrvl_ethdev.c               |  7 ++-
 drivers/net/nfb/nfb.h                         |  5 +++
 drivers/net/nfb/nfb_ethdev.c                  | 20 ++++-----
 drivers/net/nfb/nfb_rx.c                      | 10 ++---
 drivers/net/nfb/nfb_rx.h                      |  2 +-
 drivers/net/nfb/nfb_tx.c                      | 10 ++---
 drivers/net/nfb/nfb_tx.h                      |  2 +-
 drivers/net/vmxnet3/vmxnet3_ethdev.c          |  2 +-
 drivers/raw/cnxk_bphy/cnxk_bphy.c             |  3 +-
 drivers/raw/cnxk_bphy/cnxk_bphy_cgx.c         |  2 +-
 drivers/raw/cnxk_bphy/cnxk_bphy_cgx_test.c    | 31 +++++++------
 drivers/raw/cnxk_bphy/rte_pmd_bphy.h          |  6 +++
 drivers/raw/cnxk_gpio/cnxk_gpio.c             | 21 ++++-----
 drivers/raw/cnxk_gpio/cnxk_gpio.h             |  5 +++
 drivers/raw/cnxk_gpio/cnxk_gpio_selftest.c    | 17 ++++---
 examples/fips_validation/fips_dev_self_test.c | 44 +++++++++----------
 lib/log/log.c                                 |  2 +-
 lib/log/rte_log.h                             |  2 +-
 37 files changed, 166 insertions(+), 159 deletions(-)
  

Comments

David Marchand Feb. 12, 2024, 2:45 p.m. UTC | #1
On Sat, Feb 3, 2024 at 5:11 AM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> Many of the uses of PMD logtype have already been fixed.
> But there are still some leftovers, mostly places where
> drivers had a logtype but did not use them.
>
> Note: this is not an ABI break, but could break out of
>       tree drivers that never updated to use dynamic logtype.
>       DPDK never guaranteed that that would not happen.
>
> v7 - drop changes to newlines
>      drop changes related to RTE_LOG_DP
>      rebase now that other stuff has changed

Series applied.

Edits I did:
- fixed crypto/armv8 (compilation broken because of typo),
- fixed one missed use of PMD in crypto/caam_jr,
- fixed net/nfb build (thanks to Thomas for reporting),
- preferred per level macros instead of CAAM_JR_LOG, like in the rest
of the crypto/caam_jr driver,
- dropped more unrelated changes on \n in crypto/dpaa*,
- I also reorganised the commits, fixed (well dropped) wrong commit
title, typos, tried to use more consistent wording,
  
Stephen Hemminger Feb. 12, 2024, 4:45 p.m. UTC | #2
On Mon, 12 Feb 2024 15:45:13 +0100
David Marchand <david.marchand@redhat.com> wrote:

> Edits I did:
> - fixed crypto/armv8 (compilation broken because of typo),
> - fixed one missed use of PMD in crypto/caam_jr,
> - fixed net/nfb build (thanks to Thomas for reporting),
> - preferred per level macros instead of CAAM_JR_LOG, like in the rest
> of the crypto/caam_jr driver,
> - dropped more unrelated changes on \n in crypto/dpaa*,
> - I also reorganised the commits, fixed (well dropped) wrong commit
> title, typos, tried to use more consistent wording,
> 
> 


Great thanks.