From patchwork Tue Nov 14 08:41:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jie Hai X-Patchwork-Id: 401 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A75EF43325; Tue, 14 Nov 2023 09:47:18 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F01BB402E6; Tue, 14 Nov 2023 09:47:14 +0100 (CET) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by mails.dpdk.org (Postfix) with ESMTP id F3F3A4027B for ; Tue, 14 Nov 2023 09:47:11 +0100 (CET) Received: from kwepemd100004.china.huawei.com (unknown [172.30.72.54]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4SV0Dd4Dq6zPpGQ for ; Tue, 14 Nov 2023 16:42:57 +0800 (CST) Received: from localhost.localdomain (10.67.165.2) by kwepemd100004.china.huawei.com (7.221.188.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.2.1258.23; Tue, 14 Nov 2023 16:47:09 +0800 From: Jie Hai To: CC: , , Subject: [PATCH v2 00/22] replace strtok with reentrant version Date: Tue, 14 Nov 2023 16:41:11 +0800 Message-ID: <20231114084133.3573959-1-haijie1@huawei.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20231113104550.2138654-1-haijie1@huawei.com> References: <20231113104550.2138654-1-haijie1@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.67.165.2] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemd100004.china.huawei.com (7.221.188.31) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Multiple threads calling the same function may cause condition race issues, which often leads to abnormal behavior and can cause more serious vulnerabilities such as abnormal termination, denial of service, and compromised data integrity. This patchset replaces strtok with strtok_s in app, example, lib and drivers. And adds check for use of strtok in checkpatches.sh. --- v2: 1. fix commit log. 2. add check in checkpatches.sh. 3. replace strtok_r with strtok_s. 4. add Acked-by. -- Jie Hai (22): app/graph: replace strtok with reentrant version app/bbdev: replace strtok with reentrant version app/compress-perf: replace strtok with reentrant version app/crypto-perf: replace strtok with reentrant version app/dma-perf: replace strtok with reentrant version app/test-fib: replace strtok with reentrant version app/flow-perf: replace strtok with reentrant version app/test-mldev: replace strtok with reentrant version dmadev: replace strtok with reentrant version eal: replace strtok with reentrant version ethdev: replace strtok with reentrant version eventdev: replace strtok with reentrant version security: replace strtok with reentrant version telemetry: replace strtok with reentrant version bus/fslmc: replace strtok with reentrant version common/cnxk: replace strtok with reentrant version event/cnxk: replace strtok with reentrant version net/ark: replace strtok with reentrant version raw/cnxk_gpio: replace strtok with reentrant version examples/l2fwd-crypto: replace strtok with reentrant version examples/vhost: replace strtok with reentrant version devtools: check for some reentrant function app/graph/graph.c | 5 ++- app/graph/utils.c | 15 +++++--- app/test-bbdev/test_bbdev_vector.c | 25 +++++++----- .../comp_perf_options_parse.c | 16 ++++---- app/test-crypto-perf/cperf_options_parsing.c | 16 ++++---- .../cperf_test_vector_parsing.c | 10 +++-- app/test-dma-perf/main.c | 13 ++++--- app/test-fib/main.c | 10 ++--- app/test-flow-perf/main.c | 22 ++++++----- app/test-mldev/ml_options.c | 18 ++++----- devtools/checkpatches.sh | 8 ++++ drivers/bus/fslmc/fslmc_bus.c | 5 ++- drivers/bus/fslmc/portal/dpaa2_hw_dpio.c | 4 +- drivers/common/cnxk/cnxk_telemetry_nix.c | 12 +++--- drivers/event/cnxk/cnxk_eventdev.c | 10 +++-- drivers/event/cnxk/cnxk_tim_evdev.c | 11 +++--- drivers/net/ark/ark_pktchkr.c | 10 ++--- drivers/net/ark/ark_pktgen.c | 10 ++--- drivers/raw/cnxk_gpio/cnxk_gpio.c | 6 +-- examples/l2fwd-crypto/main.c | 6 +-- examples/vhost/main.c | 3 +- lib/dmadev/rte_dmadev.c | 4 +- lib/eal/common/eal_common_memory.c | 8 ++-- lib/ethdev/rte_ethdev_telemetry.c | 6 ++- lib/eventdev/rte_event_eth_rx_adapter.c | 38 +++++++++---------- lib/eventdev/rte_eventdev.c | 18 ++++----- lib/security/rte_security.c | 3 +- lib/telemetry/telemetry.c | 5 ++- 28 files changed, 177 insertions(+), 140 deletions(-)