From patchwork Mon Nov 13 10:45:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jie Hai X-Patchwork-Id: 393 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1C533430AB; Mon, 13 Nov 2023 11:50:52 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B9D20402E7; Mon, 13 Nov 2023 11:50:51 +0100 (CET) Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by mails.dpdk.org (Postfix) with ESMTP id EFB404021F for ; Mon, 13 Nov 2023 11:50:49 +0100 (CET) Received: from kwepemd100004.china.huawei.com (unknown [172.30.72.56]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4STR2p6sGyz1P89y for ; Mon, 13 Nov 2023 18:47:30 +0800 (CST) Received: from localhost.localdomain (10.67.165.2) by kwepemd100004.china.huawei.com (7.221.188.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.2.1258.23; Mon, 13 Nov 2023 18:50:47 +0800 From: Jie Hai To: CC: , , Subject: [PATCH 00/21] replace strtok with strtok_r Date: Mon, 13 Nov 2023 18:45:29 +0800 Message-ID: <20231113104550.2138654-1-haijie1@huawei.com> X-Mailer: git-send-email 2.30.0 MIME-Version: 1.0 X-Originating-IP: [10.67.165.2] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemd100004.china.huawei.com (7.221.188.31) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Multiple threads calling the same function may cause condition race issues, which often leads to abnormal behavior and can cause more serious vulnerabilities such as abnormal termination, denial of service, and compromised data integrity. The strtok() is non-reentrant, it is better to replace it with a reentrant function. Jie Hai (21): app/graph: replace strtok with strtok_r app/test-bbdev: replace strtok with strtok_r app/test-compress-perf: replace strtok with strtok_r app/test-crypto-perf: replace strtok with strtok_r app/test-dma-perf: replace strtok with strtok_r app/test-fib: replace strtok with strtok_r app/dpdk-test-flow-perf: replace strtok with strtok_r app/test-mldev: replace strtok with strtok_r lib/dmadev: replace strtok with strtok_r lib/eal: replace strtok with strtok_r lib/ethdev: replace strtok with strtok_r lib/eventdev: replace strtok with strtok_r lib/telemetry: replace strtok with strtok_r lib/telemetry: replace strtok with strtok_r bus/fslmc: replace strtok with strtok_r common/cnxk: replace strtok with strtok_r event/cnxk: replace strtok with strtok_r net/ark: replace strtok with strtok_r raw/cnxk_gpio: replace strtok with strtok_r examples/l2fwd-crypto: replace strtok with strtok_r examples/vhost: replace strtok with strtok_r app/graph/graph.c | 5 ++- app/graph/utils.c | 15 +++++--- app/test-bbdev/test_bbdev_vector.c | 25 +++++++----- .../comp_perf_options_parse.c | 16 ++++---- app/test-crypto-perf/cperf_options_parsing.c | 16 ++++---- .../cperf_test_vector_parsing.c | 10 +++-- app/test-dma-perf/main.c | 13 ++++--- app/test-fib/main.c | 10 ++--- app/test-flow-perf/main.c | 22 ++++++----- app/test-mldev/ml_options.c | 18 ++++----- drivers/bus/fslmc/fslmc_bus.c | 5 ++- drivers/bus/fslmc/portal/dpaa2_hw_dpio.c | 4 +- drivers/common/cnxk/cnxk_telemetry_nix.c | 12 +++--- drivers/event/cnxk/cnxk_eventdev.c | 10 +++-- drivers/event/cnxk/cnxk_tim_evdev.c | 11 +++--- drivers/net/ark/ark_pktchkr.c | 10 ++--- drivers/net/ark/ark_pktgen.c | 10 ++--- drivers/raw/cnxk_gpio/cnxk_gpio.c | 6 +-- examples/l2fwd-crypto/main.c | 6 +-- examples/vhost/main.c | 3 +- lib/dmadev/rte_dmadev.c | 4 +- lib/eal/common/eal_common_memory.c | 8 ++-- lib/ethdev/rte_ethdev_telemetry.c | 6 ++- lib/eventdev/rte_event_eth_rx_adapter.c | 38 +++++++++---------- lib/eventdev/rte_eventdev.c | 18 ++++----- lib/security/rte_security.c | 3 +- lib/telemetry/telemetry.c | 5 ++- 27 files changed, 169 insertions(+), 140 deletions(-)