mbox series

[v2,00/16] verify strdup return value

Message ID 20231110100117.8350-1-fengchengwen@huawei.com (mailing list archive)
Headers
Series verify strdup return value |

Message

fengchengwen Nov. 10, 2023, 10:01 a.m. UTC 
  This patchset mainly fix the return value of strdup not checked which
may lead to segment fault. It also include two commits which fix memory
leak of strdup.

Chengwen Feng (16):
  eal: verify strdup return value
  bus/dpaa: verify strdup return value
  bus/fslmc: verify strdup return value
  bus/vdev: verify strdup return value
  dma/idxd: verify strdup return value
  event/cnxk: verify strdup return value
  net/failsafe: fix memory leak when parse args
  net/nfp: verify strdup return value
  app/dumpcap: verify strdup return value
  app/pdump: verify strdup return value
  app/test: verify strdup return value
  app/test-crypto-perf: verify strdup return value
  app/test-dma-perf: verify strdup return value
  app/testpmd: verify strdup return value
  examples/qos_sched: fix memory leak when parse args
  examples/vhost: verify strdup return value

---
v2: fix 0-day warning of app/dumpcap commit.

 app/dumpcap/main.c                           |  5 ++++
 app/pdump/main.c                             |  3 +++
 app/test-crypto-perf/cperf_options_parsing.c |  4 ++++
 app/test-dma-perf/main.c                     |  2 ++
 app/test-pmd/cmdline.c                       |  2 ++
 app/test/process.h                           |  5 +++-
 drivers/bus/dpaa/dpaa_bus.c                  |  4 ++++
 drivers/bus/fslmc/fslmc_bus.c                |  4 ++++
 drivers/bus/vdev/vdev.c                      |  4 ++++
 drivers/dma/idxd/idxd_bus.c                  | 10 ++++++--
 drivers/event/cnxk/cnxk_eventdev.c           |  3 +++
 drivers/net/failsafe/failsafe_args.c         |  2 +-
 drivers/net/nfp/nfp_ipsec.c                  |  5 ++++
 examples/qos_sched/args.c                    |  4 +++-
 examples/vhost/main.c                        |  3 +++
 lib/eal/common/eal_common_options.c          | 24 ++++++++++++++++++--
 lib/eal/linux/eal_dev.c                      |  3 +++
 17 files changed, 80 insertions(+), 7 deletions(-)

Comments

fengchengwen Jan. 15, 2024, 2:57 a.m. UTC | #1 
Friendly ping.

On 2023/11/10 18:01, Chengwen Feng wrote:
> This patchset mainly fix the return value of strdup not checked which
> may lead to segment fault. It also include two commits which fix memory
> leak of strdup.
> 
> Chengwen Feng (16):
>   eal: verify strdup return value
>   bus/dpaa: verify strdup return value
>   bus/fslmc: verify strdup return value
>   bus/vdev: verify strdup return value
>   dma/idxd: verify strdup return value
>   event/cnxk: verify strdup return value
>   net/failsafe: fix memory leak when parse args
>   net/nfp: verify strdup return value
>   app/dumpcap: verify strdup return value
>   app/pdump: verify strdup return value
>   app/test: verify strdup return value
>   app/test-crypto-perf: verify strdup return value
>   app/test-dma-perf: verify strdup return value
>   app/testpmd: verify strdup return value
>   examples/qos_sched: fix memory leak when parse args
>   examples/vhost: verify strdup return value
> 
> ---
> v2: fix 0-day warning of app/dumpcap commit.
> 
>  app/dumpcap/main.c                           |  5 ++++
>  app/pdump/main.c                             |  3 +++
>  app/test-crypto-perf/cperf_options_parsing.c |  4 ++++
>  app/test-dma-perf/main.c                     |  2 ++
>  app/test-pmd/cmdline.c                       |  2 ++
>  app/test/process.h                           |  5 +++-
>  drivers/bus/dpaa/dpaa_bus.c                  |  4 ++++
>  drivers/bus/fslmc/fslmc_bus.c                |  4 ++++
>  drivers/bus/vdev/vdev.c                      |  4 ++++
>  drivers/dma/idxd/idxd_bus.c                  | 10 ++++++--
>  drivers/event/cnxk/cnxk_eventdev.c           |  3 +++
>  drivers/net/failsafe/failsafe_args.c         |  2 +-
>  drivers/net/nfp/nfp_ipsec.c                  |  5 ++++
>  examples/qos_sched/args.c                    |  4 +++-
>  examples/vhost/main.c                        |  3 +++
>  lib/eal/common/eal_common_options.c          | 24 ++++++++++++++++++--
>  lib/eal/linux/eal_dev.c                      |  3 +++
>  17 files changed, 80 insertions(+), 7 deletions(-)
>
Thomas Monjalon Feb. 18, 2024, 4:01 p.m. UTC | #2 
10/11/2023 11:01, Chengwen Feng:
> This patchset mainly fix the return value of strdup not checked which
> may lead to segment fault. It also include two commits which fix memory
> leak of strdup.
> 
> Chengwen Feng (16):
>   eal: verify strdup return value
>   bus/dpaa: verify strdup return value
>   bus/fslmc: verify strdup return value
>   bus/vdev: verify strdup return value
>   dma/idxd: verify strdup return value
>   event/cnxk: verify strdup return value
>   net/failsafe: fix memory leak when parse args
>   net/nfp: verify strdup return value
>   app/dumpcap: verify strdup return value
>   app/pdump: verify strdup return value
>   app/test: verify strdup return value
>   app/test-crypto-perf: verify strdup return value
>   app/test-dma-perf: verify strdup return value
>   app/testpmd: verify strdup return value
>   examples/qos_sched: fix memory leak when parse args
>   examples/vhost: verify strdup return value

Applied, with small change in EAL as suggested by Huisong, thanks.