From patchwork Tue May 23 12:48:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Baum X-Patchwork-Id: 127203 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D894A42B81; Tue, 23 May 2023 14:48:36 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EA0BA42D36; Tue, 23 May 2023 14:48:29 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2084.outbound.protection.outlook.com [40.107.93.84]) by mails.dpdk.org (Postfix) with ESMTP id C719842D33 for ; Tue, 23 May 2023 14:48:28 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AqdqToBfidwV76INS8z9aqmzK9IRg4kWoCMo+WtoMFej+OR8JToFcGLzLdoAWMr09k2NjA4jvzbzGaqdq449yfA1+Egw7XydxVAtcCmplhwtB2OZLZyXoVvOL4ygsYExqigd/mmIWBxGCELKFQv5etroCV6INWegBn/ridfDIu+UalPokEH+IuJwGLnyFGXKyaog1DOvCDpgZJrhZXdO7N6r4EvzlPBlwXknDWpUEXhHv5uKlb4a+01zURYQTh++jLd3IsDOPamXPqRW3mU0cLTaBaNQoWx6HYeynuuTYfskJm9sApWg1lytqqEdd7qxf++69jJzOwgWGGeI4JSuBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FyoQyaUoDjyJOno3lxYEYzvyWAo1NsAfU9ERtIf0TSM=; b=Jx4k9bW+o4x0nl5w9q8X55pJncA3LeOk2RaS6jJjXKQAdG19TFX8uhNVbkASyHM389sPrPMNgKNMwar1klUNLHtkLTThJQrNiPn4u1+4DiB1Q1m9FHY3uBsbM9Csb7GPnibazBdJ8klXRTx0InQgtV0L+NCDYKUJh6Iskap9UxInY20p+j+iCQaH8WvijX4y5QeCQUFmDPITXN2XzayXSs4L6W6qIh9BF2oph0qPQTNkGnyul+h59jVN4noqZH5RG2F4BVgqGJAZz6zR3fGFecxgajeyhqBXoUjsqmfK7Qbh/yNx5tE7dapy6eIkr7PB1/t+Oc5TC5dG2+XYf15osA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FyoQyaUoDjyJOno3lxYEYzvyWAo1NsAfU9ERtIf0TSM=; b=f7j6jRoVOzIz4wcGj6n9dtaZR8pF5bMuG4Kbk0QU8p6HaP6OOOtSwIQc29rRq3QwFTAEBVs7ZMOxKWeR2C112jT5ifcX2dNn9BCMqy93xK70I5FiessEAvspo6P9wK5T5qEUShnHV20uWecs+C+wp6Rxwnmb0P86Je3klgLpaXg1bRy6vddOEvFkz2dbuP8KZcKUBMek7XGYQjQWvMJdQaDkvRFxIIeSn5B2hFF8VGcrTOWs3ZBtWKKKWt1dB9A9gFhYBGtJAzqHQGG+CZYMszE/dCYNB7MQEo914jc8qagf18LwhYFfxQcDZ3uD5L3x/ig16/tlxwT9b1Iziq7StQ== Received: from CY5PR22CA0087.namprd22.prod.outlook.com (2603:10b6:930:65::6) by SJ2PR12MB8650.namprd12.prod.outlook.com (2603:10b6:a03:544::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.28; Tue, 23 May 2023 12:48:26 +0000 Received: from CY4PEPF0000C96B.namprd02.prod.outlook.com (2603:10b6:930:65:cafe::d3) by CY5PR22CA0087.outlook.office365.com (2603:10b6:930:65::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.29 via Frontend Transport; Tue, 23 May 2023 12:48:26 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CY4PEPF0000C96B.mail.protection.outlook.com (10.167.241.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.7 via Frontend Transport; Tue, 23 May 2023 12:48:26 +0000 Received: from rnnvmail202.nvidia.com (10.129.68.7) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Tue, 23 May 2023 05:48:12 -0700 Received: from rnnvmail203.nvidia.com (10.129.68.9) by rnnvmail202.nvidia.com (10.129.68.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Tue, 23 May 2023 05:48:12 -0700 Received: from nvidia.com (10.127.8.13) by mail.nvidia.com (10.129.68.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37 via Frontend Transport; Tue, 23 May 2023 05:48:10 -0700 From: Michael Baum To: CC: Ori Kam , Aman Singh , "Yuying Zhang" , Ferruh Yigit , "Thomas Monjalon" Subject: [PATCH v4 0/5] ethdev: modify field API for multiple headers Date: Tue, 23 May 2023 15:48:00 +0300 Message-ID: <20230523124805.3846360-1-michaelba@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230522192804.3759072-1-michaelba@nvidia.com> References: <20230522192804.3759072-1-michaelba@nvidia.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000C96B:EE_|SJ2PR12MB8650:EE_ X-MS-Office365-Filtering-Correlation-Id: 8c247cd9-94ce-4d96-dad5-08db5b8c007f X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LPguQ/1bIpwvdHNd7lgMGcChANBuOByhA4Mc5HrEmyZKuLtyPaKzyCvnoZd2mNeo0jhh29UIcg+CD+mEeSFcrPmQVSzzHOPvUf6yAhyQolsHxgSGEruJSsbdzcJ5eh82/mO/D0W1hTUVQAu4ql04S050jHVCMEV7tn5XaolnYAVtqsgNmmQtGYHEiyOEsEjR2guKY0lyidxzSCfsBVmN4fG2ll+86alOmSXeI+nY+BCPusqERPvkFXeAaM4ykOTW2VhJrRYhLHlMGZsVVcKlHrNUOYe6kYy2DsdBWZ7BQjfA2/CRd9QR7K3Bzmgjhc78FQRJafW4qKekwQOxcSaLxnHAYtN5xsdOzrhD2V/QaiOcG0XMjeYTiGR588zLz7QOiHPTBWtLbdIayxQ7jN4SC8VipBQt+woZ1mZIoGrNgo8C5U1mUo8v+6UeoKJ+xlfOrkn2IFIz1jZwmwRmJ1WCRGx85242V6FPRUtDdNxsZbZbwQF2qou0HPycTB5qTxH7ENyY8VgYkXl/Ik3WwaymxI09Ea+ywbwmfMHRlYlzVlOg5T+PMW5eAv5yS6TZ53e2Rgt/7dhE7ZyCVFC7TpM2GtuOMAgpH//f1mTonsVK4D9ohUpD9L+rwYFmFB1SAVk5lZk1gCb+4uEitxySthRmQbsmq6P0LIYyCcihbZMYgMOrewl2KZOwzbHuoFxE+r3DfH8XV1GUw8TvZziJgiaKL2JWjbIi5/OLc9VG76WUlXXfljbpgAzGWxPzosEAcWnismDJZ5JdPxHSHqm3gXcTgA== X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230028)(4636009)(396003)(136003)(346002)(376002)(39860400002)(451199021)(46966006)(36840700001)(40470700004)(8936002)(8676002)(5660300002)(47076005)(83380400001)(6286002)(186003)(1076003)(356005)(7636003)(426003)(2616005)(26005)(86362001)(82740400003)(36860700001)(336012)(40460700003)(70206006)(41300700001)(40480700001)(6666004)(55016003)(7696005)(478600001)(966005)(6916009)(4326008)(70586007)(36756003)(316002)(82310400005)(54906003)(2906002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2023 12:48:26.3891 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8c247cd9-94ce-4d96-dad5-08db5b8c007f X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000C96B.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB8650 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This patch-set extend the modify field action API to support both multiple MPLS and GENEVE option headers. In current API, the header type is provided by rte_flow_field_id enumeration and the encapsulation level (inner/outer/tunnel) is specified by data.level field. However, there is no way to specify header inside encapsulation level. For example, for this packet: eth / mpls / mpls / mpls / ipv4 / udp the both second and third MPLS headers cannot be modified using this API. RFC: https://patchwork.dpdk.org/project/dpdk/cover/20230420092145.522389-1-michaelba@nvidia.com/ v2: - Change "sub_level" name to "tag_index". - Squash PMD changes into API changes patch. - Remove PMD private patch from the patch-set. v3: - Add TAG array API change to release notes. - Improve comment and documentation. v4: - Add "Acked-by" labels. - Add PMD adjustment for TAG array API change. Michael Baum (5): doc: fix blank lines in modify field action description doc: fix blank line in asynchronous operations description doc: fix wrong indentation in RSS action description ethdev: add GENEVE TLV option modification support ethdev: add MPLS header modification support app/test-pmd/cmdline_flow.c | 70 +++++++++++++++++++++++- doc/guides/prog_guide/rte_flow.rst | 59 ++++++++++++++++----- doc/guides/rel_notes/release_23_07.rst | 7 +++ drivers/net/mlx5/mlx5_flow.c | 34 ++++++++++++ drivers/net/mlx5/mlx5_flow.h | 23 ++++++++ drivers/net/mlx5/mlx5_flow_dv.c | 29 +++++----- drivers/net/mlx5/mlx5_flow_hw.c | 43 +++++++++------ lib/ethdev/rte_flow.h | 73 ++++++++++++++++++++++++-- 8 files changed, 288 insertions(+), 50 deletions(-)