mbox series

[v2,0/5] fix Rx data buffer size

Message ID 20230414054744.1399735-1-wenjun1.wu@intel.com (mailing list archive)
Headers
Series fix Rx data buffer size |

Message

Wenjun Wu April 14, 2023, 5:47 a.m. UTC 
  This patch set fixes RX data buffer size in ice, i40e, iavf and idpf driver.

1. Limit the maximum buffer size to no more than 16K - 128.
2. Align max buffer size to 128, or replace RTE_ALIGN with
RTE_ALIGN_FLOOR according to [1].

[1] Commit c9c45beb1b97 ("net/iavf: fix Rx queue buffer size alignment")

---
v2: fix commit log

Wenjun Wu (5):
  net/i40e: fix Rx data buffer size
  net/ice: fix Rx data buffer size
  net/iavf: fix Rx data buffer size
  net/idpf: fix Rx data buffer size
  net/cpfl: fix Rx data buffer size

 drivers/common/idpf/idpf_common_rxtx.h | 3 +++
 drivers/net/cpfl/cpfl_rxtx.c           | 3 ++-
 drivers/net/i40e/i40e_rxtx.c           | 2 ++
 drivers/net/i40e/i40e_rxtx.h           | 3 +++
 drivers/net/iavf/iavf_rxtx.c           | 1 +
 drivers/net/iavf/iavf_rxtx.h           | 3 +++
 drivers/net/ice/ice_dcf_ethdev.c       | 3 ++-
 drivers/net/ice/ice_rxtx.c             | 3 ++-
 drivers/net/ice/ice_rxtx.h             | 3 +++
 drivers/net/idpf/idpf_rxtx.c           | 6 ++++--
 10 files changed, 25 insertions(+), 5 deletions(-)

Comments

Qi Zhang April 26, 2023, 2:50 a.m. UTC | #1 
> -----Original Message-----
> From: Wu, Wenjun1 <wenjun1.wu@intel.com>
> Sent: Friday, April 14, 2023 1:48 PM
> To: dev@dpdk.org; Zhang, Yuying <yuying.zhang@intel.com>; Xing, Beilei
> <beilei.xing@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>; Yang,
> Qiming <qiming.yang@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: Wu, Wenjun1 <wenjun1.wu@intel.com>
> Subject: [PATCH v2 0/5] fix Rx data buffer size
> 
> This patch set fixes RX data buffer size in ice, i40e, iavf and idpf driver.
> 
> 1. Limit the maximum buffer size to no more than 16K - 128.

Confirmed with author, this target to align with hardware spec, added related explanation in commit log.

> 2. Align max buffer size to 128, or replace RTE_ALIGN with
> RTE_ALIGN_FLOOR according to [1].
> 
> [1] Commit c9c45beb1b97 ("net/iavf: fix Rx queue buffer size alignment")
> 
> ---
> v2: fix commit log
> 
> Wenjun Wu (5):
>   net/i40e: fix Rx data buffer size
>   net/ice: fix Rx data buffer size
>   net/iavf: fix Rx data buffer size
>   net/idpf: fix Rx data buffer size
>   net/cpfl: fix Rx data buffer size
> 
>  drivers/common/idpf/idpf_common_rxtx.h | 3 +++
>  drivers/net/cpfl/cpfl_rxtx.c           | 3 ++-
>  drivers/net/i40e/i40e_rxtx.c           | 2 ++
>  drivers/net/i40e/i40e_rxtx.h           | 3 +++
>  drivers/net/iavf/iavf_rxtx.c           | 1 +
>  drivers/net/iavf/iavf_rxtx.h           | 3 +++
>  drivers/net/ice/ice_dcf_ethdev.c       | 3 ++-
>  drivers/net/ice/ice_rxtx.c             | 3 ++-
>  drivers/net/ice/ice_rxtx.h             | 3 +++
>  drivers/net/idpf/idpf_rxtx.c           | 6 ++++--
>  10 files changed, 25 insertions(+), 5 deletions(-)
> 
> --
> 2.34.1

Acked-by: Qi Zhang <qi.z.zhang@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi