From patchwork Thu Mar 23 11:37:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Sexton, Rory" X-Patchwork-Id: 125453 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2A0D042825; Thu, 23 Mar 2023 12:37:49 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BE8214021E; Thu, 23 Mar 2023 12:37:48 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 9E4364021D for ; Thu, 23 Mar 2023 12:37:47 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1679571467; x=1711107467; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=Orj1CDuek1mVEGI6wFdY0I/EUVdml1fGDC50A0hgy7o=; b=POuGZ9yS7K0mCIxwbsCZX2PcG88YvCMtHxXnZbaZn4ULh7BhVEPf3e2W d+BliKSCGXCSipcE/MDd8GnGDjle3SQTnpZ8XnpqWtRes2roDh9XjSbah Ev6Q6IFc7S1bepkV1YxsCUD7Hv6RVxy4/xUZu7Avluc5mmK11Qmd7IbOg HQmZzv0bbM0VoqHM4zV3ohGTrjtcJKjyNQeyNYHEyJGYA1DjcEMWpLuEK KVClW8fuBMArsQTGVqoRFjfqUEaq0JsyqcG1DvkkU7uKGjCluMOZgxSsH iLtNioYXWa+mNwt5As2eHEZzPZCKd4Urr5CIxlGSAha52nof1FTJxyrp6 w==; X-IronPort-AV: E=McAfee;i="6600,9927,10657"; a="323310589" X-IronPort-AV: E=Sophos;i="5.98,283,1673942400"; d="scan'208";a="323310589" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Mar 2023 04:37:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10657"; a="806220479" X-IronPort-AV: E=Sophos;i="5.98,283,1673942400"; d="scan'208";a="806220479" Received: from silpixa00401024.ir.intel.com (HELO silpixa00401024.default.svc.cluster.local) ([10.237.223.91]) by orsmga004.jf.intel.com with ESMTP; 23 Mar 2023 04:37:45 -0700 From: Rory Sexton To: honnappa.nagarahalli@arm.com, konstantin.v.ananyev@yandex.ru Cc: dev@dpdk.org, Rory Sexton Subject: [RFC 0/1] ring: add callback infrastructire to ring library Date: Thu, 23 Mar 2023 11:37:42 +0000 Message-Id: <20230323113743.4086730-1-rory.sexton@intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This is an RFC proposing the addition of a callback infrastructure to the ring library, particularly in the ring dequeue functions, but they could also be added to the enqueue functions if desired. Callbacks in the ring dequeue functions would be beneficial for a number of reasons including but not limited to the following: - would allow users to register specific functions to be called on dequeue of a ring avoiding the need to call the function within application code on several threads reading from said ring. - would mirror the callback functionality offered by the ethdev library for threads that read exclusively from a ring and process packets based off that, thus allowing for the same threads to read from either a NIC i/f or directly from a ring without needing a different codepath. The addition of callbacks wouldn't impact the reading of rings by more than 1 cycle when no callbacks are registered. They could also additionally be compiled in/out as desired to give more confidence in maintaining performance when callbacks are not required. This RFC is to give a feel for what the additional APIs would be and how they would be integrated within the ring dequeue functions. As such only function declarations are present. If there is a willingness within the community to add callback infrastructure to the ring library I will implement further code. Rory Sexton (1): ring: add infrastructure to allow callbacks within the ring library lib/ring/rte_ring.h | 133 ++++++++++++++++++++++++++++++++++++++- lib/ring/rte_ring_core.h | 3 + 2 files changed, 135 insertions(+), 1 deletion(-)