Message ID | 20221121223208.1147154-1-okaya@kernel.org (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8A77AA056D; Mon, 21 Nov 2022 23:32:17 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2DA9242D35; Mon, 21 Nov 2022 23:32:17 +0100 (CET) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mails.dpdk.org (Postfix) with ESMTP id 3ABF340DF6 for <dev@dpdk.org>; Mon, 21 Nov 2022 23:32:15 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9BAE5614BA for <dev@dpdk.org>; Mon, 21 Nov 2022 22:32:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EA236C433C1; Mon, 21 Nov 2022 22:32:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669069934; bh=E4pkzY/rhciteGDTIx9m+T/RDyvtAMBSHsXQxQqE9I0=; h=From:To:Cc:Subject:Date:From; b=uUsu3AS+093jtAd7o3AhKWdtg4Qi4vMHg2QI6RUBeEPc+/KuQf7yXoD/vyoeUYX8U WHtsRaQ8TH6y8Qq6L+2EYDM9qEK+x9LxYDs6K3gMfIqOZ40fr5fv8PY70WlTwt9K2/ gkmK8jyRxpM8k1jIfXEDD05bimotitJTxuwg6vewZMDsSWUu5sGwlj8XWx63M/50U9 OOPL2KfPKNxu5579u1ZP49ReVUgeIxWTEmaMVyDAvZhYfFm8JlQU5AM+N9lPYZLUq8 FdBi9CDxDWqn4nhvxqX9a2ByOY0aYE+bf4/090pBFm99azkU9HlByFQWkrELO9wpqr W49AluZ15H8og== From: okaya@kernel.org To: dev@dpdk.org Cc: Sinan Kaya <okaya@kernel.org> Subject: [PATCH v2 00/11] codeql fixes for various subsystems Date: Mon, 21 Nov 2022 17:31:59 -0500 Message-Id: <20221121223208.1147154-1-okaya@kernel.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org |
Series |
codeql fixes for various subsystems
|
|
Message
Sinan Kaya
Nov. 21, 2022, 10:31 p.m. UTC
From: Sinan Kaya <okaya@kernel.org>
Following up the codeql reported problems first submitted
by Stephen Hemminger here:
https://lore.kernel.org/all/20220527161210.77212d0b@hermes.local/t/
Posting a series of fixes about potential null pointer accesses.
Changes from v1:
- Remove braces around single line statements
- use NULL comparisons
Sinan Kaya (11):
ethdev: check return result of rte_eth_dev_info_get
net/tap: check if name is null
memzone: check result of rte_fbarray_get
memzone: check result of malloc_elem_from_data
malloc: malloc_elem_join_adjacent_free can return null
malloc: check result of rte_mem_virt2memseg_list
malloc: check result of rte_fbarray_get
malloc: check result of rte_mem_virt2memseg
malloc: check result of malloc_elem_free
malloc: check result of elem_start_pt
bus/vdev: check result of rte_vdev_device_name
drivers/net/tap/rte_eth_tap.c | 3 +++
lib/eal/common/eal_common_memalloc.c | 5 ++++-
lib/eal/common/eal_common_memzone.c | 10 +++++++++-
lib/eal/common/malloc_elem.c | 14 +++++++++++---
lib/eal/common/malloc_heap.c | 9 ++++++++-
lib/ethdev/ethdev_vdev.h | 2 ++
lib/ethdev/rte_class_eth.c | 4 +++-
7 files changed, 40 insertions(+), 7 deletions(-)
Comments
Hello, On Mon, Nov 21, 2022 at 11:32 PM <okaya@kernel.org> wrote: > > From: Sinan Kaya <okaya@kernel.org> > > Following up the codeql reported problems first submitted > by Stephen Hemminger here: > > https://lore.kernel.org/all/20220527161210.77212d0b@hermes.local/t/ > > Posting a series of fixes about potential null pointer accesses. > > Changes from v1: > - Remove braces around single line statements > - use NULL comparisons Thanks for the fixes, but it looks like the v2 series is truncated. Can you resend it so it passes through the CI? Thanks.
On Tue, 2022-11-22 at 16:24 +0100, David Marchand wrote: > Thanks for the fixes, but it looks like the v2 series is truncated. > > Can you resend it so it passes through the CI? Sure