mbox series

[v9,0/3] add Intel uncore api to be called through l3fwd-power

Message ID 20221006093803.2076768-1-tadhg.kearney@intel.com (mailing list archive)
Headers show
Series add Intel uncore api to be called through l3fwd-power | expand

Message

Tadhg Kearney Oct. 6, 2022, 9:38 a.m. UTC 
This is targeting 22.11 and aims to add an API to DPDK power library to
allow uncore frequency adjustment. This will be called through the l3fwd-power
app and gives the ability to set the minimum and maximum uncore frequency to
both min, max or specific frequency index.

Signed-off-by: tadhgkearney <tadhg.kearney@intel.com>
Reviewed-by: David Hunt <david.hunt@intel.com>
Acked-by: David Hunt <david.hunt@intel.com>
---

v2:
Fix compilation warnings and errors.
v3:
Remove addition of x86 global macros.
Add 2 new API's for getting package and die numbers from system.
Address comments from mailing list.
Improve efficiency of code and code quality.
v4:
Fix compilation warnings and errors.
v5:
Improve error message for uncore access not working.
v6:
Fix uncore exit being called if uncore option not selected.
v7:
Address mailing list comments.
v8:
Address mailing list comments.
v9:
Fix build errors.

Tadhg Kearney (3):
  power: add Intel uncore frequency control API to power library
  l3fwd-power: add option to call uncore API
  test/power: add unit tests for uncore API

 app/test/meson.build                          |   2 +
 app/test/test_power_intel_uncore.c            | 301 ++++++++++++
 doc/guides/prog_guide/power_man.rst           |  54 +++
 doc/guides/rel_notes/release_22_11.rst        |   6 +
 .../sample_app_ug/l3_forward_power_man.rst    |  29 ++
 examples/l3fwd-power/main.c                   | 126 ++++-
 lib/power/meson.build                         |   2 +
 lib/power/rte_power_intel_uncore.c            | 451 ++++++++++++++++++
 lib/power/rte_power_intel_uncore.h            | 194 ++++++++
 lib/power/version.map                         |  11 +
 10 files changed, 1174 insertions(+), 2 deletions(-)
 create mode 100644 app/test/test_power_intel_uncore.c
 create mode 100644 lib/power/rte_power_intel_uncore.c
 create mode 100644 lib/power/rte_power_intel_uncore.h

Comments

Thomas Monjalon Oct. 10, 2022, 12:52 p.m. UTC | #1 
06/10/2022 11:38, Tadhg Kearney:
> This is targeting 22.11 and aims to add an API to DPDK power library to
> allow uncore frequency adjustment. This will be called through the l3fwd-power
> app and gives the ability to set the minimum and maximum uncore frequency to
> both min, max or specific frequency index.
> 
> Signed-off-by: tadhgkearney <tadhg.kearney@intel.com>
> Reviewed-by: David Hunt <david.hunt@intel.com>
> Acked-by: David Hunt <david.hunt@intel.com>

I did some edits to make it more comfortable to my eyes.
Applied, thanks.

I really would like 2 follow-ups please:
- some general clean-up in power library code and doc.
- some discussion about how we can make this library more generic.