[v2,0/2] cryptodev: add SM3 and SM4 algorithms

  ShangMi 4 (SM4) is a block cipher used in the Chinese National Standard for
Wireless LAN WAPI and also used with Transport Layer Security.
ShangMi 3 (SM3) is a cryptographic hash function used in the
Chinese National Standard.

This patcheset adds both to the Cryptodev.

v2:
- Fixed incorrect sm3 string
- Added full name of the algorithm

Arek Kusztal (2):
  cryptodev: add sm4 encryption algorithm
  cryptodev: add sm3 hash algorithm

 doc/guides/cryptodevs/features/default.ini |  4 ++++
 doc/guides/rel_notes/release_22_11.rst     |  9 +++++++++
 lib/cryptodev/rte_crypto_sym.h             | 13 +++++++++++--
 lib/cryptodev/rte_cryptodev.c              |  8 ++++++--
 4 files changed, 30 insertions(+), 4 deletions(-)
  

> -----Original Message-----
> From: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> Sent: Wednesday, September 28, 2022 6:48 PM
> To: dev@dpdk.org
> Cc: Akhil Goyal <gakhil@marvell.com>; kai.ji@intel.com; Arek Kusztal
> <arkadiuszx.kusztal@intel.com>
> Subject: [EXT] [PATCH v2 0/2] cryptodev: add SM3 and SM4 algorithms
> 
> External Email
> 
> ----------------------------------------------------------------------
> ShangMi 4 (SM4) is a block cipher used in the Chinese National Standard for
> Wireless LAN WAPI and also used with Transport Layer Security.
> ShangMi 3 (SM3) is a cryptographic hash function used in the Chinese
> National Standard.
> 
> This patcheset adds both to the Cryptodev.
> 
> v2:
> - Fixed incorrect sm3 string
> - Added full name of the algorithm
> 
> Arek Kusztal (2):
>   cryptodev: add sm4 encryption algorithm
>   cryptodev: add sm3 hash algorithm
> 
>  doc/guides/cryptodevs/features/default.ini |  4 ++++
>  doc/guides/rel_notes/release_22_11.rst     |  9 +++++++++
>  lib/cryptodev/rte_crypto_sym.h             | 13 +++++++++++--
>  lib/cryptodev/rte_cryptodev.c              |  8 ++++++--
>  4 files changed, 30 insertions(+), 4 deletions(-)
> 
> --
> 2.13.6

Series Acked-by: Anoob Joseph <anoobj@marvell.com>
  

> ShangMi 4 (SM4) is a block cipher used in the Chinese National Standard for
> Wireless LAN WAPI and also used with Transport Layer Security.
> ShangMi 3 (SM3) is a cryptographic hash function used in the
> Chinese National Standard.
> 
> This patcheset adds both to the Cryptodev.
> 
> v2:
> - Fixed incorrect sm3 string
> - Added full name of the algorithm
> 
> Arek Kusztal (2):
>   cryptodev: add sm4 encryption algorithm
>   cryptodev: add sm3 hash algorithm
> 
>  doc/guides/cryptodevs/features/default.ini |  4 ++++
>  doc/guides/rel_notes/release_22_11.rst     |  9 +++++++++
>  lib/cryptodev/rte_crypto_sym.h             | 13 +++++++++++--
>  lib/cryptodev/rte_cryptodev.c              |  8 ++++++--
>  4 files changed, 30 insertions(+), 4 deletions(-)
> 
Hi Arek,

Why are the QAT implementation patches removed from this series?
We cannot simply add enums which are not being used anywhere.

Regards,
Akhil
  

> -----Original Message-----
> From: Akhil Goyal <gakhil@marvell.com>
> Sent: Thursday, September 29, 2022 9:25 PM
> To: Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>; dev@dpdk.org
> Cc: Ji, Kai <kai.ji@intel.com>
> Subject: RE: [EXT] [PATCH v2 0/2] cryptodev: add SM3 and SM4 algorithms
> 
> > ShangMi 4 (SM4) is a block cipher used in the Chinese National
> > Standard for Wireless LAN WAPI and also used with Transport Layer Security.
> > ShangMi 3 (SM3) is a cryptographic hash function used in the Chinese
> > National Standard.
> >
> > This patcheset adds both to the Cryptodev.
> >
> > v2:
> > - Fixed incorrect sm3 string
> > - Added full name of the algorithm
> >
> > Arek Kusztal (2):
> >   cryptodev: add sm4 encryption algorithm
> >   cryptodev: add sm3 hash algorithm
> >
> >  doc/guides/cryptodevs/features/default.ini |  4 ++++
> >  doc/guides/rel_notes/release_22_11.rst     |  9 +++++++++
> >  lib/cryptodev/rte_crypto_sym.h             | 13 +++++++++++--
> >  lib/cryptodev/rte_cryptodev.c              |  8 ++++++--
> >  4 files changed, 30 insertions(+), 4 deletions(-)
> >
> Hi Arek,
> 
> Why are the QAT implementation patches removed from this series?
> We cannot simply add enums which are not being used anywhere.
I wanted to push qat patches and tests to rc2. I this option cannot be accepted I will send v3 with qat patches before rc1 deadline.
> 
> Regards,
> Akhil
  

> > > ShangMi 4 (SM4) is a block cipher used in the Chinese National
> > > Standard for Wireless LAN WAPI and also used with Transport Layer Security.
> > > ShangMi 3 (SM3) is a cryptographic hash function used in the Chinese
> > > National Standard.
> > >
> > > This patcheset adds both to the Cryptodev.
> > >
> > > v2:
> > > - Fixed incorrect sm3 string
> > > - Added full name of the algorithm
> > >
> > > Arek Kusztal (2):
> > >   cryptodev: add sm4 encryption algorithm
> > >   cryptodev: add sm3 hash algorithm
> > >
> > >  doc/guides/cryptodevs/features/default.ini |  4 ++++
> > >  doc/guides/rel_notes/release_22_11.rst     |  9 +++++++++
> > >  lib/cryptodev/rte_crypto_sym.h             | 13 +++++++++++--
> > >  lib/cryptodev/rte_cryptodev.c              |  8 ++++++--
> > >  4 files changed, 30 insertions(+), 4 deletions(-)
> > >
> > Hi Arek,
> >
> > Why are the QAT implementation patches removed from this series?
> > We cannot simply add enums which are not being used anywhere.
> I wanted to push qat patches and tests to rc2. I this option cannot be accepted I
> will send v3 with qat patches before rc1 deadline.

We can take the QAT patches in RC2. But atleast we should have plans for the implementation to be merged.
I will merge the patches today. Please make sure the implementation is applied in RC2.

Regards,
Akhil
  

> -----Original Message-----
> From: Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>
> Sent: Friday, September 30, 2022 2:06 PM
> To: Akhil Goyal <gakhil@marvell.com>; dev@dpdk.org
> Cc: Ji, Kai <kai.ji@intel.com>
> Subject: RE: [EXT] [PATCH v2 0/2] cryptodev: add SM3 and SM4 algorithms
> 
> 
> 
> > -----Original Message-----
> > From: Akhil Goyal <gakhil@marvell.com>
> > Sent: Thursday, September 29, 2022 9:25 PM
> > To: Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>; dev@dpdk.org
> > Cc: Ji, Kai <kai.ji@intel.com>
> > Subject: RE: [EXT] [PATCH v2 0/2] cryptodev: add SM3 and SM4 algorithms
> >
> > > ShangMi 4 (SM4) is a block cipher used in the Chinese National
> > > Standard for Wireless LAN WAPI and also used with Transport Layer Security.
> > > ShangMi 3 (SM3) is a cryptographic hash function used in the Chinese
> > > National Standard.
> > >
> > > This patcheset adds both to the Cryptodev.
> > >
> > > v2:
> > > - Fixed incorrect sm3 string
> > > - Added full name of the algorithm
> > >
> > > Arek Kusztal (2):
> > >   cryptodev: add sm4 encryption algorithm
> > >   cryptodev: add sm3 hash algorithm
> > >
> > >  doc/guides/cryptodevs/features/default.ini |  4 ++++
> > >  doc/guides/rel_notes/release_22_11.rst     |  9 +++++++++
> > >  lib/cryptodev/rte_crypto_sym.h             | 13 +++++++++++--
> > >  lib/cryptodev/rte_cryptodev.c              |  8 ++++++--
> > >  4 files changed, 30 insertions(+), 4 deletions(-)
> > >
> > Hi Arek,
> >
> > Why are the QAT implementation patches removed from this series?
> > We cannot simply add enums which are not being used anywhere.
> I wanted to push qat patches and tests to rc2. I this option cannot be accepted I
> will send v3 with qat patches before rc1 deadline.
> >
This series along with PMD changes applied to dpdk-next-crypto

Thanks.