From patchwork Tue Aug 2 00:39:46 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Claudio Fontana X-Patchwork-Id: 114491 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9E1B9A00C3; Tue, 2 Aug 2022 02:40:00 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5A7CD40141; Tue, 2 Aug 2022 02:40:00 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by mails.dpdk.org (Postfix) with ESMTP id 24501400D7 for ; Tue, 2 Aug 2022 02:39:59 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E195B1FB0F; Tue, 2 Aug 2022 00:39:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1659400798; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=V+OhVo2dgSb1mvxnNN204/dJ8E6srgaRHKe1nuVmQiU=; b=ieY1GADv6NGgvJ0AYIzi4/uuoiNQF4OrmYt/kUCO5Ohb+AyyYRsBHoMLv4n8+niBeOdI/Z lizcwk4aDgIQ8igFeYhjC4iaNH7RR8Lr/Z+43MbTJpgzBviQ9a7daAsHHYk7PRYr9ptQsb zW6sLwCTlK9vzDoGdmyyBedwPvXBO4s= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1659400798; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=V+OhVo2dgSb1mvxnNN204/dJ8E6srgaRHKe1nuVmQiU=; b=afsgPZTNIHhg6WbaRv3Oeb58gPDy9q+PIACJ2OyxxiouFAyJGgMR5teONLrPJnzfNCuxMg X+vgmbSDbksxDiDg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A581613A72; Tue, 2 Aug 2022 00:39:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id G/nmJV5y6GK1MAAAMHmgww (envelope-from ); Tue, 02 Aug 2022 00:39:58 +0000 From: Claudio Fontana To: Maxime Coquelin , Chenbo Xia Cc: dev@dpdk.org, Claudio Fontana Subject: [PATCH v2 0/2] vhost fixes for OVS SIGSEGV in PMD Date: Tue, 2 Aug 2022 02:39:46 +0200 Message-Id: <20220802003948.22693-1-cfontana@suse.de> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This is an alternative, more general fix compared with PATCH v1. The series fixes a segmentation fault in the OVS PMD thread when resynchronizing with QEMU after the guest application has been killed with SIGKILL (patch 1/2), The segmentation fault can be caused by the guest DPDK application, which is able this way to crash the OVS process on the host, see the backtrace in patch 1/2. Patch 2/2 is an additional improvement in the current error handling. --- Changes from v1: * patch 1/2: instead of only fixing virtio_dev_tx_split, put the check for nr_vec == 0 inside desc_to_mbuf and mbuf_to_desc, so that in no case they attempt to read and dereference addresses from the buf_vec[] array when it does not contain any valid elements. --- For your review and comments, Claudio Claudio Fontana (2): vhost: check for nr_vec == 0 in desc_to_mbuf, mbuf_to_desc vhost: improve error handling in desc_to_mbuf lib/vhost/virtio_net.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-)