From patchwork Fri Jun 3 10:13:27 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bruce Richardson X-Patchwork-Id: 112290 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EB3EAA055B; Fri, 3 Jun 2022 12:13:45 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 87D0D40694; Fri, 3 Jun 2022 12:13:45 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 68AE540691 for ; Fri, 3 Jun 2022 12:13:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1654251223; x=1685787223; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=qJAECSqjwX6yplvkJN6MUbOM++7yiso7iR6e0xznB18=; b=Rb6vJ1B8V15ZDOE8EGghqIP5uE41vHSSoePYNYTloe9E3z2Jz2GxhjgE ja/Rn8kvemCJdSzuKGdgN/U5CQ8wVT9XQ3xpSxVt7lnTM2q2CbwHceZ73 EQYFEQpwOWuf6Cbb/ay5kKw04c0msjNPz73Jto64wmjoDkksrdvolBC9u waBSi68plhbemC2k0yvC7FLSrTgXyjYeIU62mhMjnZEh60FxeUsDAHfqQ 3Wx5qLwEIIcjXXcUkwPAUHEw+KF5miHeuxVr11/u5PANQVhRWWGQQer9x IXKaXYdsxBedT49S/yA+f7v6mzxolBnTbdqzkI82Qo5MPJjPWuDha4TOF w==; X-IronPort-AV: E=McAfee;i="6400,9594,10366"; a="275020787" X-IronPort-AV: E=Sophos;i="5.91,274,1647327600"; d="scan'208";a="275020787" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jun 2022 03:13:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,274,1647327600"; d="scan'208";a="530957164" Received: from silpixa00401026.ir.intel.com ([10.243.22.135]) by orsmga003.jf.intel.com with ESMTP; 03 Jun 2022 03:13:39 -0700 From: Bruce Richardson To: dev@dpdk.org Cc: david.marchand@redhat.com, Bruce Richardson Subject: [PATCH v3 0/4] clean up zero-length arrays Date: Fri, 3 Jun 2022 11:13:27 +0100 Message-Id: <20220603101331.1030993-1-bruce.richardson@intel.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220602150834.643745-1-bruce.richardson@intel.com> References: <20220602150834.643745-1-bruce.richardson@intel.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This patchset adds a coccinelle script to clean-up zero-length arrays in structures. The final patches are the result of running that script on the DPDK repository. V3: Fixed issues in mlx5 drivers: * fixed incorrect coccinelle replacement of 2-D zero-length arrays * undid removal of "0" in tx elts[] which caused issues with Werror-pedantic V2: rebased to fix apply conflict Bruce Richardson (4): cocci: add script for zero-length arrays in structs drivers: replace zero-length arrays with undimensioned ones lib: replace zero-length arrays with undimensioned ones app: examples: replace zero-length arrays with undimensioned ones app/test/test_table_tables.c | 2 +- devtools/cocci/zero_length_array.cocci | 21 +++++++++++++++++++ drivers/bus/dpaa/include/netcfg.h | 4 ++-- drivers/bus/vmbus/rte_vmbus_reg.h | 4 ++-- drivers/common/cnxk/roc_se.h | 2 +- drivers/common/dpaax/caamflib/desc/ipsec.h | 2 +- drivers/common/dpaax/dpaax_iova_table.h | 2 +- drivers/common/mlx5/mlx5_prm.h | 10 ++++----- drivers/crypto/ipsec_mb/ipsec_mb_private.h | 4 ++-- drivers/crypto/virtio/virtio_ring.h | 4 ++-- drivers/crypto/virtio/virtqueue.h | 2 +- drivers/net/atlantic/hw_atl/hw_atl_utils.h | 2 +- drivers/net/cxgbe/clip_tbl.h | 2 +- drivers/net/cxgbe/l2t.h | 2 +- drivers/net/cxgbe/mps_tcam.h | 2 +- drivers/net/cxgbe/smt.h | 2 +- drivers/net/enic/base/vnic_devcmd.h | 2 +- drivers/net/hinic/hinic_pmd_tx.h | 2 +- drivers/net/nfp/nfpcore/nfp_nsp.h | 2 +- drivers/net/virtio/virtio_ring.h | 4 ++-- drivers/net/virtio/virtio_user/vhost_kernel.c | 2 +- drivers/net/virtio/virtio_user/vhost_vdpa.c | 2 +- drivers/net/virtio/virtqueue.h | 2 +- drivers/regex/mlx5/mlx5_rxp.h | 4 ++-- examples/ip_reassembly/main.c | 2 +- examples/ptpclient/ptpclient.c | 4 ++-- lib/cryptodev/cryptodev_pmd.h | 2 +- lib/cryptodev/rte_cryptodev.h | 2 +- lib/eventdev/rte_event_timer_adapter.h | 2 +- lib/ip_frag/ip_reassembly.h | 2 +- lib/ipsec/sa.h | 2 +- lib/rib/rte_rib.c | 2 +- lib/rib/rte_rib6.c | 2 +- lib/table/rte_swx_table_learner.c | 4 ++-- lib/table/rte_table_hash_key16.c | 4 ++-- lib/table/rte_table_hash_key32.c | 4 ++-- lib/table/rte_table_hash_key8.c | 4 ++-- lib/vhost/rte_vhost.h | 4 ++-- 38 files changed, 74 insertions(+), 53 deletions(-) create mode 100644 devtools/cocci/zero_length_array.cocci --- 2.34.1