mbox series

[0/3] ethdev: update modify field flow action

Message ID 20211001195223.31909-1-viacheslavo@nvidia.com (mailing list archive)
Headers
Series ethdev: update modify field flow action |

Message

Slava Ovsiienko Oct. 1, 2021, 7:52 p.m. UTC 
  ethdev: update modify field flow action

The generic modify field flow action introduced in [1] has
some issues related to the immediate source operand:

  - immediate source can be presented either as an unsigned
    64-bit integer or pointer to data pattern in memory.
    There was no explicit pointer field defined in the union

  - the byte ordering for 64-bit integer was not specified.
    Many fields have lesser lengths and byte ordering
    is crucial.

  - how the bit offset is applied to the immediate source
    field was not defined and documented

  - 64-bit integer size is not enough to provide MAC and
    IPv6 addresses

In order to cover the issues and exclude any ambiguities
the following is done:

  - introduce the explicit pointer field
    in rte_flow_action_modify_data structure

  - replace the 64-bit unsigned integer with 16-byte array

  - update the modify field flow action documentation

[1] commit 73b68f4c54a0 ("ethdev: introduce generic modify flow action")
[2] RFC: http://patches.dpdk.org/project/dpdk/patch/20210910141609.8410-1-viacheslavo@nvidia.com/
[3] Deprecation notice: http://patches.dpdk.org/project/dpdk/patch/20210803085754.643180-1-orika@nvidia.com/


Signed-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>

Viacheslav Ovsiienko (3):
  ethdev: update modify field flow action
  app/testpmd: update modify field flow action support
  app/testpmd: fix hex string parser in flow commands

 app/test-pmd/cmdline_flow.c            | 60 ++++++++++++++++++--------
 doc/guides/prog_guide/rte_flow.rst     |  8 ++++
 doc/guides/rel_notes/release_21_11.rst |  7 +++
 lib/ethdev/rte_flow.h                  | 15 +++++--
 4 files changed, 69 insertions(+), 21 deletions(-)