mbox series

[0/2] Check meter packet mode in PMD

Message ID 20210401061618.1478961-1-lizh@nvidia.com (mailing list archive)
Headers
Series Check meter packet mode in PMD |

Message

Li Zhang April 1, 2021, 6:16 a.m. UTC 
  Currently meter algorithms only supports rate is bytes per second(BPS).
Add packet_mode flag in meter profile parameters data structure in RTE.
Add the necessary checks to the existing drivers implementing
the rte_mtr API to makes sure that profiles with
packet_mode set to TRUE are rejected.

Depends-on: series=16002  ("Support PPS(packet per second) on meter")
https://patchwork.dpdk.org/project/dpdk/list/?series=16002

Li Zhang (2):
  net/softnic: check meter packet mode
  net/mvpp2: check meter packet mode

 drivers/net/mvpp2/mrvl_mtr.c                | 6 ++++++
 drivers/net/softnic/rte_eth_softnic_meter.c | 8 ++++++++
 2 files changed, 14 insertions(+)

Comments

Thomas Monjalon April 1, 2021, 6:31 a.m. UTC | #1 
01/04/2021 08:16, Li Zhang:
> Currently meter algorithms only supports rate is bytes per second(BPS).
> Add packet_mode flag in meter profile parameters data structure in RTE.

What means RTE?
I see no flag added in these patches.

> Add the necessary checks to the existing drivers implementing
> the rte_mtr API to makes sure that profiles with
> packet_mode set to TRUE are rejected.
> 
> Depends-on: series=16002  ("Support PPS(packet per second) on meter")
> https://patchwork.dpdk.org/project/dpdk/list/?series=16002

It seems these patches should be part of the above patchset.

> Li Zhang (2):
>   net/softnic: check meter packet mode
>   net/mvpp2: check meter packet mode
Li Zhang April 1, 2021, 6:52 a.m. UTC | #2 
Hi Thomas,

> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Thursday, April 1, 2021 2:31 PM
> To: Li Zhang <lizh@nvidia.com>
> Cc: Ori Kam <orika@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>;
> Matan Azrad <matan@nvidia.com>; cristian.dumitrescu@intel.com;
> lironh@marvell.com; dev@dpdk.org; Raslan Darawsheh
> <rasland@nvidia.com>; Roni Bar Yanai <roniba@nvidia.com>
> Subject: Re: [PATCH 0/2] Check meter packet mode in PMD
> 
> External email: Use caution opening links or attachments
> 
> 
> 01/04/2021 08:16, Li Zhang:
> > Currently meter algorithms only supports rate is bytes per second(BPS).
> > Add packet_mode flag in meter profile parameters data structure in RTE.
> 
> What means RTE?
> I see no flag added in these patches.

It is RTE API, which added by another patch as below:
Depends-on: series=16002  ("Support PPS(packet per second) on meter")
https://patchwork.dpdk.org/project/dpdk/patch/20210331085405.1445546-2-lizh@nvidia.com/

> > Add the necessary checks to the existing drivers implementing the
> > rte_mtr API to makes sure that profiles with packet_mode set to TRUE
> > are rejected.
> >
> > Depends-on: series=16002  ("Support PPS(packet per second) on meter")
> > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatc
> >
> hwork.dpdk.org%2Fproject%2Fdpdk%2Flist%2F%3Fseries%3D16002&amp;dat
> a=04
> > %7C01%7Clizh%40nvidia.com%7C6fc22a58772641cbf72608d8f4d7bf75%7C4
> 3083d1
> >
> 5727340c1b7db39efd9ccc17a%7C0%7C0%7C637528554762610316%7CUnkno
> wn%7CTWF
> >
> pbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVC
> I6M
> >
> n0%3D%7C1000&amp;sdata=VZ88lQoAZK3z7MODRycvja4YvpEcjC4apoZZy4p1
> ZP4%3D&
> > amp;reserved=0
> 
> It seems these patches should be part of the above patchset.
> 
> > Li Zhang (2):
> >   net/softnic: check meter packet mode
> >   net/mvpp2: check meter packet mode
> 
>
Thomas Monjalon April 1, 2021, 7:04 a.m. UTC | #3 
01/04/2021 08:52, Li Zhang:
> From: Thomas Monjalon <thomas@monjalon.net>
> > 01/04/2021 08:16, Li Zhang:
> > > Currently meter algorithms only supports rate is bytes per second(BPS).
> > > Add packet_mode flag in meter profile parameters data structure in RTE.
> > 
> > What means RTE?
> > I see no flag added in these patches.
> 
> It is RTE API, which added by another patch as below:
> Depends-on: series=16002  ("Support PPS(packet per second) on meter")
> https://patchwork.dpdk.org/project/dpdk/patch/20210331085405.1445546-2-lizh@nvidia.com/

Please do not say RTE API, it is meaningless.
Better to give the exact name of the structure,
or at least the name of the library.

Also your sentence means this patchset is adding a flag but it is not.
It's very confusing.

> > > Add the necessary checks to the existing drivers implementing the
> > > rte_mtr API to makes sure that profiles with packet_mode set to TRUE
> > > are rejected.
> > >
> > > Depends-on: series=16002  ("Support PPS(packet per second) on meter")
> > > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatc
> > >
> > hwork.dpdk.org%2Fproject%2Fdpdk%2Flist%2F%3Fseries%3D16002&amp;dat
> > a=04
> > > %7C01%7Clizh%40nvidia.com%7C6fc22a58772641cbf72608d8f4d7bf75%7C4
> > 3083d1
> > >
> > 5727340c1b7db39efd9ccc17a%7C0%7C0%7C637528554762610316%7CUnkno
> > wn%7CTWF
> > >
> > pbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVC
> > I6M
> > >
> > n0%3D%7C1000&amp;sdata=VZ88lQoAZK3z7MODRycvja4YvpEcjC4apoZZy4p1
> > ZP4%3D&
> > > amp;reserved=0
> > 
> > It seems these patches should be part of the above patchset.
> > 
> > > Li Zhang (2):
> > >   net/softnic: check meter packet mode
> > >   net/mvpp2: check meter packet mode
Li Zhang April 1, 2021, 7:37 a.m. UTC | #4 
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Thursday, April 1, 2021 3:05 PM
> To: Li Zhang <lizh@nvidia.com>
> Cc: Ori Kam <orika@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>;
> Matan Azrad <matan@nvidia.com>; cristian.dumitrescu@intel.com;
> lironh@marvell.com; dev@dpdk.org; Raslan Darawsheh
> <rasland@nvidia.com>; Roni Bar Yanai <roniba@nvidia.com>
> Subject: Re: [PATCH 0/2] Check meter packet mode in PMD
> 
> External email: Use caution opening links or attachments
> 
> 
> 01/04/2021 08:52, Li Zhang:
> > From: Thomas Monjalon <thomas@monjalon.net>
> > > 01/04/2021 08:16, Li Zhang:
> > > > Currently meter algorithms only supports rate is bytes per second(BPS).
> > > > Add packet_mode flag in meter profile parameters data structure in RTE.
> > >
> > > What means RTE?
> > > I see no flag added in these patches.
> >
> > It is RTE API, which added by another patch as below:
> > Depends-on: series=16002  ("Support PPS(packet per second) on meter")
> > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatc
> > hwork.dpdk.org%2Fproject%2Fdpdk%2Fpatch%2F20210331085405.1445546-
> 2-liz
> >
> h%40nvidia.com%2F&amp;data=04%7C01%7Clizh%40nvidia.com%7Cee7b712
> 9413a4
> >
> 361efed08d8f4dc74d2%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%
> 7C63752
> >
> 8574977185064%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJ
> QIjoiV2lu
> >
> MzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=mtOtA82sfVNg
> gKbNr6
> > 2qPbgZymCHCSN9p2JB01LUDXc%3D&amp;reserved=0
> 
> Please do not say RTE API, it is meaningless.
> Better to give the exact name of the structure, or at least the name of the
> library.
> 
> Also your sentence means this patchset is adding a flag but it is not.
> It's very confusing.
> 

Thanks, I will change it in V2 patch.

> > > > Add the necessary checks to the existing drivers implementing the
> > > > rte_mtr API to makes sure that profiles with packet_mode set to
> > > > TRUE are rejected.
> > > >
> > > > Depends-on: series=16002  ("Support PPS(packet per second) on
> > > > meter")
> > > > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2F
> > > > patc
> > > >
> > >
> hwork.dpdk.org%2Fproject%2Fdpdk%2Flist%2F%3Fseries%3D16002&amp;dat
> > > a=04
> > > > %7C01%7Clizh%40nvidia.com%7C6fc22a58772641cbf72608d8f4d7bf75%
> 7C4
> > > 3083d1
> > > >
> > >
> 5727340c1b7db39efd9ccc17a%7C0%7C0%7C637528554762610316%7CUnkno
> > > wn%7CTWF
> > > >
> > >
> pbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVC
> > > I6M
> > > >
> > >
> n0%3D%7C1000&amp;sdata=VZ88lQoAZK3z7MODRycvja4YvpEcjC4apoZZy4p1
> > > ZP4%3D&
> > > > amp;reserved=0
> > >
> > > It seems these patches should be part of the above patchset.
> > >
> > > > Li Zhang (2):
> > > >   net/softnic: check meter packet mode
> > > >   net/mvpp2: check meter packet mode
> 
>
Thomas Monjalon April 1, 2021, 7:44 a.m. UTC | #5 
01/04/2021 09:37, Li Zhang:
> Thanks, I will change it in V2 patch.

Not sure you should do a v2.
I think this patchset is needed only because of your other patchset.
So it should be integrated with the other one.
Am I missing something?

> > > > > Depends-on: series=16002  ("Support PPS(packet per second) on
> > > > > meter")
> > > >
> > > > It seems these patches should be part of the above patchset.
> > > >
> > > > > Li Zhang (2):
> > > > >   net/softnic: check meter packet mode
> > > > >   net/mvpp2: check meter packet mode
Li Zhang April 1, 2021, 8:50 a.m. UTC | #6 
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Thursday, April 1, 2021 3:45 PM
> To: Li Zhang <lizh@nvidia.com>
> Cc: Ori Kam <orika@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>;
> Matan Azrad <matan@nvidia.com>; cristian.dumitrescu@intel.com;
> lironh@marvell.com; dev@dpdk.org; Raslan Darawsheh
> <rasland@nvidia.com>; Roni Bar Yanai <roniba@nvidia.com>
> Subject: Re: [PATCH 0/2] Check meter packet mode in PMD
> 
> External email: Use caution opening links or attachments
> 
> 
> 01/04/2021 09:37, Li Zhang:
> > Thanks, I will change it in V2 patch.
> 
> Not sure you should do a v2.
> I think this patchset is needed only because of your other patchset.
> So it should be integrated with the other one.
> Am I missing something?
> 
OK, I will not send V2 for it only.
I will add this cover-letter change when other patchset need be fixed for other comments.
> > > > > > Depends-on: series=16002  ("Support PPS(packet per second) on
> > > > > > meter")
> > > > >
> > > > > It seems these patches should be part of the above patchset.
> > > > >
> > > > > > Li Zhang (2):
> > > > > >   net/softnic: check meter packet mode
> > > > > >   net/mvpp2: check meter packet mode
> 
>