From patchwork Sun Dec 20 21:13:25 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxime Coquelin X-Patchwork-Id: 85524 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0A27FA09FD; Sun, 20 Dec 2020 22:14:27 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8ADDCCACF; Sun, 20 Dec 2020 22:14:25 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id 27BF6CAB9 for ; Sun, 20 Dec 2020 22:14:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1608498861; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=QiDBnTMCoayqsQp7oF4TXRbHkz5QvLMTUTqtYIQfcvQ=; b=A1K5sz4xCE351CLMIWGzkhcRMGQECOdOFKQeLN/qDpN1v+dqYAqxwbrK1p3t4DO0LIO8Dr yH9ToKeyoZw3FPMPqSfNMeQw7oMDSyHFY4Z0QCq1i1kfMMiaO07MoVmhaEjTqhUcvZALQQ JdzKwIWg/Mlj6//h1fH/YWm0zi3r35Q= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-476-anXjvrbsOoa2zub4ZRW5Rg-1; Sun, 20 Dec 2020 16:14:19 -0500 X-MC-Unique: anXjvrbsOoa2zub4ZRW5Rg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 88C98805EF2; Sun, 20 Dec 2020 21:14:18 +0000 (UTC) Received: from max-t490s.redhat.com (unknown [10.36.110.43]) by smtp.corp.redhat.com (Postfix) with ESMTP id B39BB60C43; Sun, 20 Dec 2020 21:14:10 +0000 (UTC) From: Maxime Coquelin To: dev@dpdk.org, chenbo.xia@intel.com, olivier.matz@6wind.com, amorenoz@redhat.com, david.marchand@redhat.com Cc: Maxime Coquelin Date: Sun, 20 Dec 2020 22:13:25 +0100 Message-Id: <20201220211405.313012-1-maxime.coquelin@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Subject: [dpdk-dev] [PATCH 00/40] net/virtio: Virtio PMD rework X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This series significantly rework Virtio PMD to improve the Virtio-user PMD and its backends integration. First part of the series (first 21 patches) removes the dependency of Virtio-user ethdev on Virtio PCI, by creating generic files, adding per-bus meta data, ... Main (if not single) functionnal change of this first part is to remove the hack for Virtio-user to work in IOVA as PA mode, this hack being very fragile. Now, the user has to manually pass --iova-mode=va in EAL parameters, otherwise vdev probe will fail. In v21.11, when ABI/API can be changed, I will add vdev driver flags so that the Virtio-user PMD can request IOVA as VA mode to be used. Second part of the series reworks Virtio-user internal, by reworking the requests handling so that vDPA and Kernel backends no more hack into being Vhost-user backend. It implies implementing new ops for all the request types. Also, all the backend specific actions are moved from the virtio_user_dev.c and virtio_user_ethdev.c to their backend files. Only functionnal change in this second part is making the Vhost-user server mode blocking at init time, as long as a client is not connected. The goal of this change is to make the Vhost-user support much more robust, as without blocking, the driver has to assume features that are going to be supported by the client, which is very fragile and error prone. As a side-effect, it also simplifies the logic nin several place of the virtio-user PMD. Plese note that I haven't tested the last 5 patches yet, I will conduct more testing early next week. Maxime Coquelin (40): bus/vdev: add helper to get vdev from eth dev net/virtio: Introduce Virtio bus type net/virtio: refactor virtio-user device net/virtio: introduce PCI device metadata net/virtio: move PCI device init in dedicated file net/virtio: move PCI specific dev init to PCI ethdev init net/virtio: move MSIX detection to PCI ethdev net/virtio: force IOVA as VA mode for Virtio-user net/virtio: store PCI type in Virtio device metadata net/virtio: add callback for device closing net/virtio: validate features at bus level net/virtio: remove bus type enum net/virtio: move PCI-specific fields to PCI device net/virtio: pack virtio HW struct net/virtio: move legacy IO to Virtio PCI net/virtio: introduce generic virtio header net/virtio: move features definition to generic header net/virtio: move virtqueue defines in generic header net/virtio: move config definitions to generic header net/virtio: make interrupt handling more generic net/virtio: move vring alignment to generic header net/virtio: remove last PCI refs in non-PCI code net/virtio: make Vhost-user req sender consistent net/virtio: add Virtio-user ops to set owner net/virtio: add Virtio-user features ops net/virtio: add Virtio-user protocol features ops net/virtio: add Virtio-user memory tables ops net/virtio: add Virtio-user vring setting ops net/virtio: add Virtio-user vring file ops net/virtio: add Virtio-user vring address ops net/virtio: add Virtio-user status ops net/virtio: remove useless request ops net/virtio: improve Virtio-user errors handling net/virtio: move Vhost-user reqs to Vhost-user backend net/virtio: make server mode blocking net/virtio: move protocol features to Vhost-user net/virtio: introduce backend data net/virtio: move Vhost-user specifics to its backend net/virtio: move Vhost-kernel data to its backend net/virtio: move Vhost-vDPA data to its backend drivers/bus/vdev/rte_bus_vdev.h | 2 + drivers/net/virtio/meson.build | 6 +- drivers/net/virtio/virtio.c | 71 ++ drivers/net/virtio/virtio.h | 247 ++++++ drivers/net/virtio/virtio_ethdev.c | 441 +++------ drivers/net/virtio/virtio_ethdev.h | 5 +- drivers/net/virtio/virtio_pci.c | 399 +++++---- drivers/net/virtio/virtio_pci.h | 286 +----- drivers/net/virtio/virtio_pci_ethdev.c | 225 +++++ drivers/net/virtio/virtio_ring.h | 2 +- drivers/net/virtio/virtio_rxtx.c | 90 +- drivers/net/virtio/virtio_rxtx_packed_avx.c | 18 +- drivers/net/virtio/virtio_rxtx_simple.h | 3 +- drivers/net/virtio/virtio_user/vhost.h | 80 +- drivers/net/virtio/virtio_user/vhost_kernel.c | 435 ++++++--- .../net/virtio/virtio_user/vhost_kernel_tap.c | 25 +- .../net/virtio/virtio_user/vhost_kernel_tap.h | 1 + drivers/net/virtio/virtio_user/vhost_user.c | 835 ++++++++++++++---- drivers/net/virtio/virtio_user/vhost_vdpa.c | 257 ++++-- .../net/virtio/virtio_user/virtio_user_dev.c | 490 +++++----- .../net/virtio/virtio_user/virtio_user_dev.h | 22 +- drivers/net/virtio/virtio_user_ethdev.c | 304 ++----- drivers/net/virtio/virtqueue.c | 6 +- drivers/net/virtio/virtqueue.h | 41 +- 24 files changed, 2481 insertions(+), 1810 deletions(-) create mode 100644 drivers/net/virtio/virtio.c create mode 100644 drivers/net/virtio/virtio.h create mode 100644 drivers/net/virtio/virtio_pci_ethdev.c