mbox series

[v3,00/33] net: add txgbe PMD part 2

Message ID 20201218093702.3651867-1-jiawenwu@trustnetic.com (mailing list archive)
Headers
Series net: add txgbe PMD part 2 |

Message

Jiawen Wu Dec. 18, 2020, 9:36 a.m. UTC
  This patch adds the rest of txgbe PMD for its PF part.
Support include flow API, traffic mirror, traffic manager, and ipsec.

v3:
- Delete macsec, add traffic mirror
- Re-order patches for the part of flow filter
- Fix to parse L2 tunnel filter
- Fix build errors and spelling mistake

v2:
- Rebase on next-net

Jiawen Wu (33):
  net/txgbe: add generic flow API
  net/txgbe: add ntuple filter init and uninit
  net/txgbe: support ntuple filter add and delete
  net/txgbe: parse n-tuple filter
  net/txgbe: support ethertype filter add and delete
  net/txgbe: parse ethertype filter
  net/txgbe: support syn filter add and delete
  net/txgbe: parse syn filter
  net/txgbe: add L2 tunnel filter init and uninit
  net/txgbe: config L2 tunnel filter with e-tag
  net/txgbe: support L2 tunnel filter add and delete
  net/txgbe: parse L2 tunnel filter
  net/txgbe: add flow director filter init and uninit
  net/txgbe: configure flow director filter
  net/txgbe: support flow director filter add and delete
  net/txgbe: parse flow director filter
  net/txgbe: restore RSS filter
  net/txgbe: parse RSS filter
  net/txgbe: support to create consistent filter
  net/txgbe: support to destroy consistent filter
  net/txgbe: flush all the filters
  net/txgbe: support UDP tunnel port add and delete
  net/txgbe: add TM configuration init and uninit
  net/txgbe: add TM capabilities get operation
  net/txgbe: support TM shaper profile add and delete
  net/txgbe: support TM node add and delete
  net/txgbe: add TM hierarchy commit
  net/txgbe: support to add traffic mirror rules
  net/txgbe: add IPsec context creation
  net/txgbe: add security session create operation
  net/txgbe: destroy security session
  net/txgbe: add security offload in Rx and Tx process
  net/txgbe: add security type in flow action

 doc/guides/nics/features/txgbe.ini  |    3 +
 doc/guides/nics/txgbe.rst           |    1 +
 drivers/net/txgbe/base/txgbe_hw.c   |   87 +
 drivers/net/txgbe/base/txgbe_hw.h   |    1 +
 drivers/net/txgbe/base/txgbe_type.h |   65 +
 drivers/net/txgbe/meson.build       |    6 +-
 drivers/net/txgbe/txgbe_ethdev.c    | 1470 ++++++++++++-
 drivers/net/txgbe/txgbe_ethdev.h    |  306 +++
 drivers/net/txgbe/txgbe_fdir.c      |  985 +++++++++
 drivers/net/txgbe/txgbe_flow.c      | 3154 +++++++++++++++++++++++++++
 drivers/net/txgbe/txgbe_ipsec.c     |  731 +++++++
 drivers/net/txgbe/txgbe_ipsec.h     |   97 +
 drivers/net/txgbe/txgbe_rxtx.c      |  189 +-
 drivers/net/txgbe/txgbe_rxtx.h      |   13 +
 drivers/net/txgbe/txgbe_tm.c        | 1022 +++++++++
 15 files changed, 8062 insertions(+), 68 deletions(-)
 create mode 100644 drivers/net/txgbe/txgbe_fdir.c
 create mode 100644 drivers/net/txgbe/txgbe_flow.c
 create mode 100644 drivers/net/txgbe/txgbe_ipsec.c
 create mode 100644 drivers/net/txgbe/txgbe_ipsec.h
 create mode 100644 drivers/net/txgbe/txgbe_tm.c
  

Comments

Jiawen Wu Jan. 13, 2021, 6:15 a.m. UTC | #1
Hi Ferruh,

> -----Original Message-----
> From: Jiawen Wu <jiawenwu@trustnetic.com>
> Sent: Friday, December 18, 2020 5:36 PM
> To: dev@dpdk.org
> Cc: Jiawen Wu <jiawenwu@trustnetic.com>
> Subject: [PATCH v3 00/33] net: add txgbe PMD part 2
> 
> This patch adds the rest of txgbe PMD for its PF part.
> Support include flow API, traffic mirror, traffic manager, and ipsec.
> 
> v3:
> - Delete macsec, add traffic mirror
> - Re-order patches for the part of flow filter
> - Fix to parse L2 tunnel filter
> - Fix build errors and spelling mistake
> 
> v2:
> - Rebase on next-net
> 
> Jiawen Wu (33):
>   net/txgbe: add generic flow API
>   net/txgbe: add ntuple filter init and uninit
>   net/txgbe: support ntuple filter add and delete
>   net/txgbe: parse n-tuple filter
>   net/txgbe: support ethertype filter add and delete
>   net/txgbe: parse ethertype filter
>   net/txgbe: support syn filter add and delete
>   net/txgbe: parse syn filter
>   net/txgbe: add L2 tunnel filter init and uninit
>   net/txgbe: config L2 tunnel filter with e-tag
>   net/txgbe: support L2 tunnel filter add and delete
>   net/txgbe: parse L2 tunnel filter
>   net/txgbe: add flow director filter init and uninit
>   net/txgbe: configure flow director filter
>   net/txgbe: support flow director filter add and delete
>   net/txgbe: parse flow director filter
>   net/txgbe: restore RSS filter
>   net/txgbe: parse RSS filter
>   net/txgbe: support to create consistent filter
>   net/txgbe: support to destroy consistent filter
>   net/txgbe: flush all the filters
>   net/txgbe: support UDP tunnel port add and delete
>   net/txgbe: add TM configuration init and uninit
>   net/txgbe: add TM capabilities get operation
>   net/txgbe: support TM shaper profile add and delete
>   net/txgbe: support TM node add and delete
>   net/txgbe: add TM hierarchy commit
>   net/txgbe: support to add traffic mirror rules
>   net/txgbe: add IPsec context creation
>   net/txgbe: add security session create operation
>   net/txgbe: destroy security session
>   net/txgbe: add security offload in Rx and Tx process
>   net/txgbe: add security type in flow action
> 
>  doc/guides/nics/features/txgbe.ini  |    3 +
>  doc/guides/nics/txgbe.rst           |    1 +
>  drivers/net/txgbe/base/txgbe_hw.c   |   87 +
>  drivers/net/txgbe/base/txgbe_hw.h   |    1 +
>  drivers/net/txgbe/base/txgbe_type.h |   65 +
>  drivers/net/txgbe/meson.build       |    6 +-
>  drivers/net/txgbe/txgbe_ethdev.c    | 1470 ++++++++++++-
>  drivers/net/txgbe/txgbe_ethdev.h    |  306 +++
>  drivers/net/txgbe/txgbe_fdir.c      |  985 +++++++++
>  drivers/net/txgbe/txgbe_flow.c      | 3154
> +++++++++++++++++++++++++++
>  drivers/net/txgbe/txgbe_ipsec.c     |  731 +++++++
>  drivers/net/txgbe/txgbe_ipsec.h     |   97 +
>  drivers/net/txgbe/txgbe_rxtx.c      |  189 +-
>  drivers/net/txgbe/txgbe_rxtx.h      |   13 +
>  drivers/net/txgbe/txgbe_tm.c        | 1022 +++++++++
>  15 files changed, 8062 insertions(+), 68 deletions(-)  create mode 100644
> drivers/net/txgbe/txgbe_fdir.c  create mode 100644
> drivers/net/txgbe/txgbe_flow.c  create mode 100644
> drivers/net/txgbe/txgbe_ipsec.c  create mode 100644
> drivers/net/txgbe/txgbe_ipsec.h  create mode 100644
> drivers/net/txgbe/txgbe_tm.c
> 
> --
> 2.18.2
  
Ferruh Yigit Jan. 13, 2021, 1:15 p.m. UTC | #2
On 1/13/2021 6:15 AM, Jiawen Wu wrote:
> Hi Ferruh,
> 
>> -----Original Message-----
>> From: Jiawen Wu <jiawenwu@trustnetic.com>
>> Sent: Friday, December 18, 2020 5:36 PM
>> To: dev@dpdk.org
>> Cc: Jiawen Wu <jiawenwu@trustnetic.com>
>> Subject: [PATCH v3 00/33] net: add txgbe PMD part 2
>>
>> This patch adds the rest of txgbe PMD for its PF part.
>> Support include flow API, traffic mirror, traffic manager, and ipsec.
>>
>> v3:
>> - Delete macsec, add traffic mirror
>> - Re-order patches for the part of flow filter
>> - Fix to parse L2 tunnel filter
>> - Fix build errors and spelling mistake
>>
>> v2:
>> - Rebase on next-net
>>
>> Jiawen Wu (33):
>>    net/txgbe: add generic flow API
>>    net/txgbe: add ntuple filter init and uninit
>>    net/txgbe: support ntuple filter add and delete
>>    net/txgbe: parse n-tuple filter
>>    net/txgbe: support ethertype filter add and delete
>>    net/txgbe: parse ethertype filter
>>    net/txgbe: support syn filter add and delete
>>    net/txgbe: parse syn filter
>>    net/txgbe: add L2 tunnel filter init and uninit
>>    net/txgbe: config L2 tunnel filter with e-tag
>>    net/txgbe: support L2 tunnel filter add and delete
>>    net/txgbe: parse L2 tunnel filter
>>    net/txgbe: add flow director filter init and uninit
>>    net/txgbe: configure flow director filter
>>    net/txgbe: support flow director filter add and delete
>>    net/txgbe: parse flow director filter
>>    net/txgbe: restore RSS filter
>>    net/txgbe: parse RSS filter
>>    net/txgbe: support to create consistent filter
>>    net/txgbe: support to destroy consistent filter
>>    net/txgbe: flush all the filters
>>    net/txgbe: support UDP tunnel port add and delete
>>    net/txgbe: add TM configuration init and uninit
>>    net/txgbe: add TM capabilities get operation
>>    net/txgbe: support TM shaper profile add and delete
>>    net/txgbe: support TM node add and delete
>>    net/txgbe: add TM hierarchy commit
>>    net/txgbe: support to add traffic mirror rules
>>    net/txgbe: add IPsec context creation
>>    net/txgbe: add security session create operation
>>    net/txgbe: destroy security session
>>    net/txgbe: add security offload in Rx and Tx process
>>    net/txgbe: add security type in flow action

Hi Jiawen,

Can you please send a release notes update for the added support?

Some short PMD documentation on how to use new added rte_flow support and tm 
support can be good. Since some of the names of the filtering is not very clear, 
documentation and samples may help there.

It would be better to send proper documentation update with the code changes, 
but for this case I will continue with the set, please send the doc updates as 
separate patches.


Also "Traffic mirroring" feature is deprecated, it is dropped while merging.

Except from 28/33 (traffic mirroring)
Series applied to dpdk-next-net/main, thanks.