Message ID | 20201024010146.27689-1-stephen@networkplumber.org (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 56199A04B0; Sat, 24 Oct 2020 03:02:00 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C0CB1A69; Sat, 24 Oct 2020 03:01:57 +0200 (CEST) Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) by dpdk.org (Postfix) with ESMTP id AFCD53DC for <dev@dpdk.org>; Sat, 24 Oct 2020 03:01:56 +0200 (CEST) Received: by mail-pf1-f194.google.com with SMTP id h7so2815163pfn.2 for <dev@dpdk.org>; Fri, 23 Oct 2020 18:01:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=c1ni/h/eXOOZcNZhWB4FGECP7xIo5ZGojjq1bmxqajA=; b=jLg8hPEQu/QZy23iYAyhCrMu/iVYg/StV+oFe8g9GW5E0ffBi/4R6xAfP1vj7Whlhg J2b4gCQNzOUGo6k8itQ07mWL3G7xTsI4xZucZNTra/viNblT9dVlRU9xEdf/pOhf6Nbx aD8/G0qWKGqv32e2KDKhVOJPgM5FnIo9LMCnoYer4aONJHC/dDORjCWLzkjZvycbmdGQ PQdhcNWnvThs00gkOyiWrrGis6Oi7G2yMqoB8WFPO6wyl7dEzo3JjE4mJfl2tsoYzQvG 2/MJ1BKL9uuwJ4UBYl7IZHqw9KwZnFr9baQeuknWq9RsXcflLSwMTytotkueEBNL3VsH tDAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=c1ni/h/eXOOZcNZhWB4FGECP7xIo5ZGojjq1bmxqajA=; b=bqi3M0pPHyYKa/YteqdMXayVVXqabAux/UAesMIF0WxRUkDH692UeRWtXaWu17I00P L5g1pWoSj+pQpI7ZVbIxC8Rj9btxtjg1IxTOy/lHSh/brYSkohHzGavf5Wp/a0B5ZN/V leJ8BEfbBCGgIBc6awhWKvMfWcRXRh/ZdkRhLoaSauLweUOUHmx+fpNqw89HeSoY31VK 1bsvLHS1rEKOhiMXB1+Fk20z9UtWqJpollQjBX5mKoWKP3row7AC7/25ExixWvE1R/l7 Cti8YFFplm7tyRSZrAkqlWg5q8J20fZva8fP1sBfm0568nUHf8Gkkqj+VuZGAM9mJpfU q6ww== X-Gm-Message-State: AOAM530cJsBy0h0LrPYGo2iHRm0tS+hILLXblVMCSkM2rDJE6+9VTIi0 Q8uQ38zMnK3SoHPCAABqX9I5iOnMHV8vSJt2 X-Google-Smtp-Source: ABdhPJwf4t8RbCNPEVZ7rtpUiV4kDWPMNoJz40lZRcyvfcG5qQU3xPNYkGsohVfscLjXbs6Wy2R5SA== X-Received: by 2002:a63:4c6:: with SMTP id 189mr4193502pge.233.1603501314129; Fri, 23 Oct 2020 18:01:54 -0700 (PDT) Received: from hermes.corp.microsoft.com (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id w19sm3356439pfn.174.2020.10.23.18.01.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Oct 2020 18:01:53 -0700 (PDT) From: Stephen Hemminger <stephen@networkplumber.org> To: dev@dpdk.org Cc: Stephen Hemminger <stephen@networkplumber.org> Date: Fri, 23 Oct 2020 18:01:41 -0700 Message-Id: <20201024010146.27689-1-stephen@networkplumber.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200922143202.8755-1-stephen@networkplumber.org> References: <20200922143202.8755-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v5 0/5] replace blacklist/whitelist with block/allow X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
replace blacklist/whitelist with block/allow
|
|
Message
Stephen Hemminger
Oct. 24, 2020, 1:01 a.m. UTC
This is a revised version of the earlier RFC patch set for changing the blacklist/whitelist terms in DPDK. The first patch is a duplicate from the other patch set about use of master/slave in API. Note: This may cause some warnings in existing programs in the CI tests using the -w flag. It also causes checkpatch complaints because we are replacing blacklist which is flagged by the current versions. v5 - rebase and fix conflicts in documentation Stephen Hemminger (5): eal: replace usage of blacklist/whitelist in enum drivers: replace references to blacklist eal: replace pci-whitelist/pci-blacklist options app/test: use new allowlist and blocklist doc: change references to blacklist and whitelist app/test/autotest.py | 16 ++--- app/test/autotest_runner.py | 18 ++--- app/test/test.c | 2 +- app/test/test_eal_flags.c | 52 +++++++------- doc/guides/cryptodevs/dpaa2_sec.rst | 6 +- doc/guides/cryptodevs/dpaa_sec.rst | 6 +- doc/guides/cryptodevs/qat.rst | 12 ++-- doc/guides/eventdevs/octeontx2.rst | 20 +++--- doc/guides/freebsd_gsg/build_sample_apps.rst | 2 +- doc/guides/linux_gsg/build_sample_apps.rst | 2 +- doc/guides/linux_gsg/eal_args.include.rst | 14 ++-- doc/guides/linux_gsg/linux_drivers.rst | 4 +- doc/guides/mempool/octeontx2.rst | 4 +- doc/guides/nics/bnxt.rst | 18 ++--- doc/guides/nics/cxgbe.rst | 12 ++-- doc/guides/nics/dpaa.rst | 6 +- doc/guides/nics/dpaa2.rst | 6 +- doc/guides/nics/enic.rst | 6 +- doc/guides/nics/fail_safe.rst | 16 ++--- doc/guides/nics/features.rst | 2 +- doc/guides/nics/i40e.rst | 16 ++--- doc/guides/nics/ice.rst | 28 +++++--- doc/guides/nics/ixgbe.rst | 4 +- doc/guides/nics/mlx4.rst | 18 ++--- doc/guides/nics/mlx5.rst | 14 ++-- doc/guides/nics/nfb.rst | 2 +- doc/guides/nics/octeontx2.rst | 23 +++--- doc/guides/nics/sfc_efx.rst | 2 +- doc/guides/nics/tap.rst | 2 +- doc/guides/nics/thunderx.rst | 4 +- .../prog_guide/env_abstraction_layer.rst | 6 +- doc/guides/prog_guide/multi_proc_support.rst | 4 +- doc/guides/prog_guide/poll_mode_drv.rst | 6 +- .../prog_guide/switch_representation.rst | 6 +- doc/guides/rel_notes/release_20_11.rst | 5 ++ doc/guides/sample_app_ug/bbdev_app.rst | 14 ++-- .../sample_app_ug/eventdev_pipeline.rst | 4 +- doc/guides/sample_app_ug/ipsec_secgw.rst | 12 ++-- doc/guides/sample_app_ug/l3_forward.rst | 7 +- .../sample_app_ug/l3_forward_access_ctrl.rst | 2 +- .../sample_app_ug/l3_forward_power_man.rst | 3 +- doc/guides/sample_app_ug/vdpa.rst | 2 +- doc/guides/tools/cryptoperf.rst | 6 +- doc/guides/tools/flow-perf.rst | 2 +- doc/guides/tools/testregex.rst | 2 +- drivers/bus/dpaa/dpaa_bus.c | 7 +- drivers/bus/fslmc/fslmc_bus.c | 9 ++- drivers/bus/fslmc/fslmc_vfio.c | 12 ++-- drivers/bus/pci/pci_common.c | 24 +++---- drivers/bus/vmbus/vmbus_common.c | 4 +- drivers/crypto/virtio/virtio_pci.c | 2 +- drivers/net/virtio/virtio_pci.c | 2 +- lib/librte_eal/common/eal_common_devargs.c | 14 ++-- lib/librte_eal/common/eal_common_options.c | 70 ++++++++++++------- lib/librte_eal/common/eal_options.h | 9 ++- lib/librte_eal/include/rte_bus.h | 10 ++- lib/librte_eal/include/rte_dev.h | 10 ++- lib/librte_eal/include/rte_devargs.h | 10 ++- 58 files changed, 328 insertions(+), 273 deletions(-)
Comments
On Sat, Oct 24, 2020 at 3:02 AM Stephen Hemminger <stephen@networkplumber.org> wrote: > > This is a revised version of the earlier RFC patch set for changing > the blacklist/whitelist terms in DPDK. > > The first patch is a duplicate from the other patch set about > use of master/slave in API. > > Note: > This may cause some warnings in existing programs in the CI > tests using the -w flag. > > It also causes checkpatch complaints because we are replacing > blacklist which is flagged by the current versions. > > v5 - rebase and fix conflicts in documentation > > Stephen Hemminger (5): > eal: replace usage of blacklist/whitelist in enum > drivers: replace references to blacklist > eal: replace pci-whitelist/pci-blacklist options > app/test: use new allowlist and blocklist > doc: change references to blacklist and whitelist - This series does not implement what had been announced in the deprecation notice: https://git.dpdk.org/dpdk/commit/doc/guides/rel_notes/deprecation.rst?id=714e3e60014206cb616cd4157bf11a5209e7186f From my pov, the implementation with ALLOWED/BLOCKED is as good as the one initially proposed so this is fine. But in this case, please stick to it, there are still some traces about "included" / "include" / "excluded" "exclude" devices, in comments and usage strings. Idem, please stick to a consistent wording in all patches, I noted "Blocklisted" "Blocked" "Marked as blocked". - The release note and deprecation notice (which is missing) must both be updated atomically with the patches that change API. - Compilation is broken at patch1, since patch2 changes are required. - The documentation patch has misses: doc/guides/nics/fail_safe.rst: -w 81:00.0 -- -i doc/guides/nics/fail_safe.rst: ./<build_dir>/app/dpdk-testpmd -c 0xff -n 4 -w ff:ff.f \ doc/guides/sample_app_ug/vdpa.rst: -w 0000:06:00.3,vdpa=1 -a 0000:06:00.4,vdpa=1 \ - The documentation patch has a rebase issue in ice.rst, as flow mark devargs has been dropped in 62451c94ad - net/ice: remove devargs for flow mark (7 weeks ago) <Guinan Sun>
On Thu, 5 Nov 2020 09:27:59 +0100 David Marchand <david.marchand@redhat.com> wrote: > On Sat, Oct 24, 2020 at 3:02 AM Stephen Hemminger > <stephen@networkplumber.org> wrote: > > > > This is a revised version of the earlier RFC patch set for changing > > the blacklist/whitelist terms in DPDK. > > > > The first patch is a duplicate from the other patch set about > > use of master/slave in API. > > > > Note: > > This may cause some warnings in existing programs in the CI > > tests using the -w flag. > > > > It also causes checkpatch complaints because we are replacing > > blacklist which is flagged by the current versions. > > > > v5 - rebase and fix conflicts in documentation > > > > Stephen Hemminger (5): > > eal: replace usage of blacklist/whitelist in enum > > drivers: replace references to blacklist > > eal: replace pci-whitelist/pci-blacklist options > > app/test: use new allowlist and blocklist > > doc: change references to blacklist and whitelist > > - This series does not implement what had been announced in the > deprecation notice: > https://git.dpdk.org/dpdk/commit/doc/guides/rel_notes/deprecation.rst?id=714e3e60014206cb616cd4157bf11a5209e7186f > > From my pov, the implementation with ALLOWED/BLOCKED is as good as the > one initially proposed so this is fine. > But in this case, please stick to it, there are still some traces > about "included" / "include" / "excluded" "exclude" devices, in > comments and usage strings. > Idem, please stick to a consistent wording in all patches, I noted > "Blocklisted" "Blocked" "Marked as blocked". Thanks fixed in next version > - The release note and deprecation notice (which is missing) must both > be updated atomically with the patches that change API. Should I just remove the deprecation notice now? > - Compilation is broken at patch1, since patch2 changes are required. The compilation does work just produces lots of warnings. > - The documentation patch has misses: > doc/guides/nics/fail_safe.rst: -w 81:00.0 -- -i > doc/guides/nics/fail_safe.rst: ./<build_dir>/app/dpdk-testpmd -c > 0xff -n 4 -w ff:ff.f \ > doc/guides/sample_app_ug/vdpa.rst: -w > 0000:06:00.3,vdpa=1 -a 0000:06:00.4,vdpa=1 \ Fixed those > - The documentation patch has a rebase issue in ice.rst, as flow mark > devargs has been dropped in 62451c94ad - net/ice: remove devargs for > flow mark (7 weeks ago) <Guinan Sun> Fixed that as well