mbox series

[0/5] cleanup comments and logs about config options

Message ID 20201022220525.1532249-1-thomas@monjalon.net (mailing list archive)
Headers show
Series cleanup comments and logs about config options | expand

Message

Thomas Monjalon Oct. 22, 2020, 10:05 p.m. UTC 
Below patches are cleaning traces of CONFIG_RTE_ after make removal,
except one occurence in app/test/test_cryptodev.c (left as exercise).
PS: In reality I don't know what must be done for this case about QAT.

Thomas Monjalon (5):
  eal: remove comment about old partition option
  mem: fix config name in error logs
  lib: remove config prefix used with make
  drivers: remove config prefix used with make
  doc: remove references to make from known issues

 doc/guides/rel_notes/known_issues.rst       |  8 ++------
 drivers/net/bnxt/bnxt_ethdev.c              |  2 +-
 drivers/net/ixgbe/ixgbe_rxtx.c              |  2 +-
 drivers/net/sfc/sfc_ef10_essb_rx.c          |  2 +-
 lib/librte_eal/arm/include/rte_atomic_32.h  |  2 +-
 lib/librte_eal/arm/include/rte_atomic_64.h  |  2 +-
 lib/librte_eal/arm/include/rte_byteorder.h  |  2 +-
 lib/librte_eal/arm/include/rte_mcslock.h    |  2 +-
 lib/librte_eal/arm/include/rte_spinlock.h   |  2 +-
 lib/librte_eal/arm/include/rte_ticketlock.h |  2 +-
 lib/librte_eal/common/eal_common_dynmem.c   |  4 ++--
 lib/librte_eal/freebsd/eal_memory.c         |  6 +++---
 lib/librte_eal/include/rte_eal.h            |  8 --------
 lib/librte_eal/linux/eal_memory.c           |  8 ++++----
 lib/librte_eal/linux/eal_timer.c            |  2 +-
 lib/librte_eal/linux/eal_vfio_mp_sync.c     |  2 +-
 lib/librte_mbuf/rte_mbuf_core.h             |  3 +--
 lib/librte_rcu/rte_rcu_qsbr.h               | 10 +++++-----
 18 files changed, 28 insertions(+), 41 deletions(-)

Comments

David Marchand Oct. 23, 2020, 7:37 a.m. UTC | #1 
On Fri, Oct 23, 2020 at 12:05 AM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> Below patches are cleaning traces of CONFIG_RTE_ after make removal,
> except one occurence in app/test/test_cryptodev.c (left as exercise).
> PS: In reality I don't know what must be done for this case about QAT.

It seems a reintroduction with raw datapath API merge.

I would apply the same as Ciara previous:
https://git.dpdk.org/dpdk/diff/app/test/test_cryptodev.c?id=c2c92c5d88522bb7f149de8ea6305691d1c65505

I.e.
@@ -14022,9 +14022,7 @@ test_cryptodev_qat_raw_api(void /*argv
__rte_unused, int argc __rte_unused*/)
                        RTE_STR(CRYPTODEV_NAME_QAT_SYM_PMD));

        if (gbl_driver_id == -1) {
-               RTE_LOG(ERR, USER1, "QAT PMD must be loaded. Check that both "
-               "CONFIG_RTE_LIBRTE_PMD_QAT and CONFIG_RTE_LIBRTE_PMD_QAT_SYM "
-               "are enabled in config file to run this testsuite.\n");
+               RTE_LOG(ERR, USER1, "QAT PMD must be loaded.\n");
                return TEST_SKIPPED;
        }


The rest of the series looks good to me.
Acked-by: David Marchand <david.marchand@redhat.com>
Thomas Monjalon Oct. 23, 2020, 5:24 p.m. UTC | #2 
23/10/2020 09:37, David Marchand:
> On Fri, Oct 23, 2020 at 12:05 AM Thomas Monjalon <thomas@monjalon.net> wrote:
> >
> > Below patches are cleaning traces of CONFIG_RTE_ after make removal,
> > except one occurence in app/test/test_cryptodev.c (left as exercise).
> > PS: In reality I don't know what must be done for this case about QAT.
> 
> It seems a reintroduction with raw datapath API merge.
> 
> I would apply the same as Ciara previous:
> https://git.dpdk.org/dpdk/diff/app/test/test_cryptodev.c?id=c2c92c5d88522bb7f149de8ea6305691d1c65505
> 
> I.e.
> @@ -14022,9 +14022,7 @@ test_cryptodev_qat_raw_api(void /*argv
> __rte_unused, int argc __rte_unused*/)
>                         RTE_STR(CRYPTODEV_NAME_QAT_SYM_PMD));
> 
>         if (gbl_driver_id == -1) {
> -               RTE_LOG(ERR, USER1, "QAT PMD must be loaded. Check that both "
> -               "CONFIG_RTE_LIBRTE_PMD_QAT and CONFIG_RTE_LIBRTE_PMD_QAT_SYM "
> -               "are enabled in config file to run this testsuite.\n");
> +               RTE_LOG(ERR, USER1, "QAT PMD must be loaded.\n");
>                 return TEST_SKIPPED;
>         }

Yes it seems the right thing to do.

> The rest of the series looks good to me.
> Acked-by: David Marchand <david.marchand@redhat.com>

Applied with above change