mbox series

[0/4] remove experimental tags from APIs

Message ID 20200911054534.55378-1-joyce.kong@arm.com (mailing list archive)
Headers show
Series remove experimental tags from APIs | expand

Message

Joyce Kong Sept. 11, 2020, 5:45 a.m. UTC
Experimental tags can be removed from APIs in module: ticket lock, 
MCS lock, pause (wait until equal APIs), and RCU (except for defer
queue APIs) as they have been aroud four releases.

Joyce Kong (4):
  eal/ticketlock: remove experimental tag
  eal/mcslock: remove experimental tag
  rcu: remove experimental tag from QSBR mechanism
  eal/pause: remove experimental tag from wait until equal

 MAINTAINERS                                   |  4 +-
 lib/librte_eal/include/generic/rte_mcslock.h  | 16 ------
 lib/librte_eal/include/generic/rte_pause.h    | 12 -----
 .../include/generic/rte_ticketlock.h          |  9 ----
 lib/librte_rcu/rte_rcu_qsbr.h                 | 52 -------------------
 lib/librte_rcu/rte_rcu_version.map            | 11 +++-
 6 files changed, 11 insertions(+), 93 deletions(-)

Comments

David Marchand Sept. 16, 2020, 5:09 p.m. UTC | #1
On Fri, Sep 11, 2020 at 7:46 AM Joyce Kong <joyce.kong@arm.com> wrote:
>
> Experimental tags can be removed from APIs in module: ticket lock,
> MCS lock, pause (wait until equal APIs), and RCU (except for defer
> queue APIs) as they have been aroud four releases.
>
> Joyce Kong (4):
>   eal/ticketlock: remove experimental tag
>   eal/mcslock: remove experimental tag
>   rcu: remove experimental tag from QSBR mechanism
>   eal/pause: remove experimental tag from wait until equal

This series seems good to me but I prefer to ask other arch maintainers.
Are you fine with those API being marked as stable (especially the
wait until equal API)?


Thanks.
David Marchand Sept. 25, 2020, 2:12 p.m. UTC | #2
On Wed, Sep 16, 2020 at 7:09 PM David Marchand
<david.marchand@redhat.com> wrote:
>
> On Fri, Sep 11, 2020 at 7:46 AM Joyce Kong <joyce.kong@arm.com> wrote:
> >
> > Experimental tags can be removed from APIs in module: ticket lock,
> > MCS lock, pause (wait until equal APIs), and RCU (except for defer
> > queue APIs) as they have been aroud four releases.
> >
> > Joyce Kong (4):
> >   eal/ticketlock: remove experimental tag
> >   eal/mcslock: remove experimental tag
> >   rcu: remove experimental tag from QSBR mechanism
> >   eal/pause: remove experimental tag from wait until equal
>
> This series seems good to me but I prefer to ask other arch maintainers.
> Are you fine with those API being marked as stable (especially the
> wait until equal API)?

Going twice...
Ananyev, Konstantin Sept. 25, 2020, 2:14 p.m. UTC | #3
> On Wed, Sep 16, 2020 at 7:09 PM David Marchand
> <david.marchand@redhat.com> wrote:
> >
> > On Fri, Sep 11, 2020 at 7:46 AM Joyce Kong <joyce.kong@arm.com> wrote:
> > >
> > > Experimental tags can be removed from APIs in module: ticket lock,
> > > MCS lock, pause (wait until equal APIs), and RCU (except for defer
> > > queue APIs) as they have been aroud four releases.
> > >
> > > Joyce Kong (4):
> > >   eal/ticketlock: remove experimental tag
> > >   eal/mcslock: remove experimental tag
> > >   rcu: remove experimental tag from QSBR mechanism
> > >   eal/pause: remove experimental tag from wait until equal
> >
> > This series seems good to me but I prefer to ask other arch maintainers.
> > Are you fine with those API being marked as stable (especially the
> > wait until equal API)?
> 
> Going twice...
> 

No objections from me.
Series acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
Kinsella, Ray Oct. 5, 2020, 8:39 a.m. UTC | #4
On 11/09/2020 06:45, Joyce Kong wrote:
> Experimental tags can be removed from APIs in module: ticket lock, 
> MCS lock, pause (wait until equal APIs), and RCU (except for defer
> queue APIs) as they have been aroud four releases.

NIT: aroud = around

> 
> Joyce Kong (4):
>   eal/ticketlock: remove experimental tag
>   eal/mcslock: remove experimental tag
>   rcu: remove experimental tag from QSBR mechanism
>   eal/pause: remove experimental tag from wait until equal
> 
>  MAINTAINERS                                   |  4 +-
>  lib/librte_eal/include/generic/rte_mcslock.h  | 16 ------
>  lib/librte_eal/include/generic/rte_pause.h    | 12 -----
>  .../include/generic/rte_ticketlock.h          |  9 ----
>  lib/librte_rcu/rte_rcu_qsbr.h                 | 52 -------------------
>  lib/librte_rcu/rte_rcu_version.map            | 11 +++-
>  6 files changed, 11 insertions(+), 93 deletions(-)
>
David Marchand Oct. 5, 2020, 12:18 p.m. UTC | #5
On Fri, Sep 11, 2020 at 7:46 AM Joyce Kong <joyce.kong@arm.com> wrote:
>
> Experimental tags can be removed from APIs in module: ticket lock,
> MCS lock, pause (wait until equal APIs), and RCU (except for defer
> queue APIs) as they have been aroud four releases.
>
> Joyce Kong (4):
>   eal/ticketlock: remove experimental tag
>   eal/mcslock: remove experimental tag
>   rcu: remove experimental tag from QSBR mechanism
>   eal/pause: remove experimental tag from wait until equal
>
>  MAINTAINERS                                   |  4 +-
>  lib/librte_eal/include/generic/rte_mcslock.h  | 16 ------
>  lib/librte_eal/include/generic/rte_pause.h    | 12 -----
>  .../include/generic/rte_ticketlock.h          |  9 ----
>  lib/librte_rcu/rte_rcu_qsbr.h                 | 52 -------------------
>  lib/librte_rcu/rte_rcu_version.map            | 11 +++-
>  6 files changed, 11 insertions(+), 93 deletions(-)
>

I will handle the Ray comment on the rcu map.

One additional comment: the wait until equal API should be marked
stable before the ticketlock API, since the latter relies on the
former.
This is just a question of ordering the patches, easy to do when applying.

No need for a v2 on those comments.
David Christensen Oct. 5, 2020, 7:39 p.m. UTC | #6
On 9/25/20 7:14 AM, Ananyev, Konstantin wrote:
> 
>> On Wed, Sep 16, 2020 at 7:09 PM David Marchand
>> <david.marchand@redhat.com> wrote:
>>>
>>> On Fri, Sep 11, 2020 at 7:46 AM Joyce Kong <joyce.kong@arm.com> wrote:
>>>>
>>>> Experimental tags can be removed from APIs in module: ticket lock,
>>>> MCS lock, pause (wait until equal APIs), and RCU (except for defer
>>>> queue APIs) as they have been aroud four releases.
>>>>
>>>> Joyce Kong (4):
>>>>    eal/ticketlock: remove experimental tag
>>>>    eal/mcslock: remove experimental tag
>>>>    rcu: remove experimental tag from QSBR mechanism
>>>>    eal/pause: remove experimental tag from wait until equal
>>>
>>> This series seems good to me but I prefer to ask other arch maintainers.
>>> Are you fine with those API being marked as stable (especially the
>>> wait until equal API)?
>>
>> Going twice...
>>
> 
> No objections from me.
> Series acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>

Same here, no objections.

Acked-by: David Christensen <drc@linux.vnet.ibm.com>
David Marchand Oct. 6, 2020, 8:30 a.m. UTC | #7
On Fri, Sep 11, 2020 at 7:46 AM Joyce Kong <joyce.kong@arm.com> wrote:
>
> Experimental tags can be removed from APIs in module: ticket lock,
> MCS lock, pause (wait until equal APIs), and RCU (except for defer
> queue APIs) as they have been aroud four releases.
>
> Joyce Kong (4):
>   eal/ticketlock: remove experimental tag
>   eal/mcslock: remove experimental tag
>   rcu: remove experimental tag from QSBR mechanism
>   eal/pause: remove experimental tag from wait until equal
>
>  MAINTAINERS                                   |  4 +-
>  lib/librte_eal/include/generic/rte_mcslock.h  | 16 ------
>  lib/librte_eal/include/generic/rte_pause.h    | 12 -----
>  .../include/generic/rte_ticketlock.h          |  9 ----
>  lib/librte_rcu/rte_rcu_qsbr.h                 | 52 -------------------
>  lib/librte_rcu/rte_rcu_version.map            | 11 +++-
>  6 files changed, 11 insertions(+), 93 deletions(-)
>

Series applied, thanks.