Message ID | 20200701202359.17006-1-stephen@networkplumber.org (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8D8B0A0350; Wed, 1 Jul 2020 22:24:13 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 159021D501; Wed, 1 Jul 2020 22:24:11 +0200 (CEST) Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) by dpdk.org (Postfix) with ESMTP id E241C1D455 for <dev@dpdk.org>; Wed, 1 Jul 2020 22:24:08 +0200 (CEST) Received: by mail-pf1-f177.google.com with SMTP id 207so11289956pfu.3 for <dev@dpdk.org>; Wed, 01 Jul 2020 13:24:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=eqHrd0JgrkA6udYOcfMRuNG/Z8mqN8NZZGIr48c7QDQ=; b=MNsNzhYvdNuDSrR+Ebfb5tkxEm7k/MefMNBoQWXfSrjf64PV75qkN33iv7lhwrzgIG Q2aNPHRCbQ86ViyxLfbKHJcKY1Z32m/R8cS7ab1qGxaN/dX+GKS+dO4j7BH21ied6i/8 CVUAlXv1DmZq0mpdPkqx3E/o8AISXV5f2XAfyQf09lD8tJDSDQO/LRSZdIyJL/NdGVoG q1v6QCAIAsq8MId7ca9z/MOr1b6jnfdWM0aBpBsczDYqrkTruXY68g+ohVB+579BopiE N7OKsHUHPT/5tPStiM8GlDDdySUMsWmqGW2Dv0FTCBUwGe62P4Jo09BQSdxQiTr0+MFj CbCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=eqHrd0JgrkA6udYOcfMRuNG/Z8mqN8NZZGIr48c7QDQ=; b=Y3/Eh/ibJ1YCkfK2OFZqFl3+CRv3/nY9Nxcs+G25ap3kV1fJNcWqoIj+S8zvx9rkgG wD7qKnqowpz2kNLNq+vTn3KOFQxmSPvPyWchmpONxsiGDlX6DjyuA84OekW1+uXqZihG SoQHNSaJeflnuElS4zIDD+Gd6C6mZoyrm4U83NMhmcF1pwgZEVQuGdN9RijHLf0fx9vV JqQ7aXYF8jjItSiK6T6VqEgEqHGP2pl9NciuizT8xQ61ue1TN8+hPncrQgRIwtUC1a81 9cTe31dSa2nfulD0gG3AYlaLh9Q+ahtdMpaXhZ1agUXgzHUH76CDpdmuMkfc92q4pQKn BwWg== X-Gm-Message-State: AOAM5304P+QYPdHODK/HS9Qn7wq9p29UsKPh32guAMYYyaX21MRwfVgm 98Dwu0rIUryr3yo6Ksc1CcIkJbkwwFc= X-Google-Smtp-Source: ABdhPJyLSrxt0vmAaSx14fl3zsqsk9SRGrf0HNO+O6H24YASiemEvn2OkVKFKufecVsxSO2mXBMMhw== X-Received: by 2002:a63:f903:: with SMTP id h3mr22159479pgi.437.1593635047355; Wed, 01 Jul 2020 13:24:07 -0700 (PDT) Received: from hermes.corp.microsoft.com (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id g8sm6584803pgr.70.2020.07.01.13.24.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jul 2020 13:24:06 -0700 (PDT) From: Stephen Hemminger <stephen@networkplumber.org> To: dev@dpdk.org Cc: Stephen Hemminger <stephen@networkplumber.org> Date: Wed, 1 Jul 2020 13:23:32 -0700 Message-Id: <20200701202359.17006-1-stephen@networkplumber.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200604210200.25405-1-stephen@networkplumber.org> References: <20200604210200.25405-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v4 00/27] Replace references to master and slave X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
Replace references to master and slave
|
|
Message
Stephen Hemminger
July 1, 2020, 8:23 p.m. UTC
This set of patches changes the API and conventions around referring to DPDK lcores. The first patch changes rte_get_master_lcore_id and related calls. The rest fix the DPDK to use the new naming. Buried in the documentation set are a couple of patches where we were using incorrect naming around primary/secondary process. This will could/should be flagged as an API policy violation since new API is jumping the queue of EXPERIMENTAL. But we can vote on the exception. The one area left to be fixed is the bonding device. v4 - fix checkpatch warnings note: this patchset will cause some false positives v3 - modify vhost to replace slave with client - modify memif to replace slave with client - fix variable names s2m becomes i2w etc. Stephen Hemminger (27): eal: rename terms used for DPDK lcores kni: fix reference to master/slave process bbdev: rename master to initial lcore librte_power: change reference to rte_master_lcore drivers: replace master/slave terminology examples/distributor: rename master to initial examples/bond: replace references to master lcore examples/ethtool-app: replace references to slave with worker examples/ip_pipeline: replace references to master_lcore examples/qos_{meter/sched}: replace references to master lcore examples/l3fwd: replace references to master lcore examples/l2fwd: replace references to master lcore examples/multi_process: replace references to master lcore examples/performance-thread: replace reference to master lcore examples/ptpclient: replace references to master lcore examples/ipcsec-secgw: replace references to master lcore examples: replace reference to master lcore app/test-pmd: change references to master/slave test-eventdev: replace references to slave with worker lcores app/test: replace refernces to master/slave doc: fix incorrect reference to master process doc: update references to master/slave lcore in documentation app/pdump: replace references to master/slave lcore app/test-XXX: replace reference to master/slave eal: mark old naming as deprecated memif: replace master/slave with server/client vhost: rename SLAVE to CLIENT app/pdump/main.c | 2 +- app/test-acl/main.c | 2 +- app/test-bbdev/test_bbdev_perf.c | 16 +-- app/test-compress-perf/main.c | 8 +- app/test-crypto-perf/main.c | 14 +- app/test-eventdev/evt_options.c | 2 +- app/test-eventdev/test_order_common.c | 12 +- app/test-eventdev/test_perf_common.c | 16 +-- app/test-eventdev/test_pipeline_common.c | 8 +- app/test-flow-perf/main.c | 2 +- app/test-pipeline/main.c | 4 +- app/test-pmd/config.c | 4 +- app/test-pmd/parameters.c | 2 +- app/test-pmd/softnicfwd.c | 2 +- app/test-pmd/testpmd.c | 4 +- app/test-sad/main.c | 4 +- app/test/autotest_test_funcs.py | 2 +- app/test/test.c | 2 +- app/test/test_atomic.c | 26 ++-- app/test/test_barrier.c | 2 +- app/test/test_cryptodev.c | 16 +-- app/test/test_distributor.c | 8 +- app/test/test_distributor_perf.c | 11 +- app/test/test_eal_flags.c | 32 ++--- app/test/test_efd.c | 2 +- app/test/test_efd_perf.c | 2 +- app/test/test_func_reentrancy.c | 25 ++-- app/test/test_hash_multiwriter.c | 4 +- app/test/test_hash_readwrite.c | 38 +++--- app/test/test_kni.c | 16 +-- app/test/test_malloc.c | 12 +- app/test/test_mbuf.c | 36 ++--- app/test/test_mcslock.c | 28 ++-- app/test/test_mempool_perf.c | 10 +- app/test/test_mp_secondary.c | 2 +- app/test/test_pdump.c | 2 +- app/test/test_per_lcore.c | 14 +- app/test/test_pmd_perf.c | 20 +-- app/test/test_rcu_qsbr.c | 2 +- app/test/test_rcu_qsbr_perf.c | 2 +- app/test/test_ring_perf.c | 14 +- app/test/test_ring_stress_impl.h | 10 +- app/test/test_rwlock.c | 28 ++-- app/test/test_service_cores.c | 10 +- app/test/test_spinlock.c | 34 ++--- app/test/test_stack.c | 2 +- app/test/test_stack_perf.c | 6 +- app/test/test_ticketlock.c | 36 ++--- app/test/test_timer.c | 107 ++++++++------- app/test/test_timer_racecond.c | 27 ++-- app/test/test_timer_secondary.c | 2 +- app/test/test_trace_perf.c | 4 +- doc/guides/contributing/coding_style.rst | 2 +- doc/guides/faq/faq.rst | 6 +- doc/guides/howto/debug_troubleshoot.rst | 2 +- doc/guides/linux_gsg/eal_args.include.rst | 4 +- doc/guides/nics/bnxt.rst | 2 +- doc/guides/nics/fail_safe.rst | 3 - doc/guides/nics/memif.rst | 82 +++++------ .../prog_guide/env_abstraction_layer.rst | 6 +- .../prog_guide/event_ethernet_rx_adapter.rst | 2 +- doc/guides/prog_guide/glossary.rst | 8 +- .../thread_safety_dpdk_functions.rst | 4 +- doc/guides/rel_notes/release_20_08.rst | 7 +- doc/guides/sample_app_ug/bbdev_app.rst | 2 +- doc/guides/sample_app_ug/ethtool.rst | 4 +- doc/guides/sample_app_ug/hello_world.rst | 8 +- doc/guides/sample_app_ug/ioat.rst | 12 +- doc/guides/sample_app_ug/ip_pipeline.rst | 4 +- doc/guides/sample_app_ug/keep_alive.rst | 2 +- doc/guides/sample_app_ug/l2_forward_event.rst | 4 +- .../sample_app_ug/l2_forward_real_virtual.rst | 4 +- doc/guides/sample_app_ug/l3_forward_graph.rst | 6 +- .../sample_app_ug/l3_forward_power_man.rst | 2 +- doc/guides/sample_app_ug/link_status_intr.rst | 4 +- doc/guides/sample_app_ug/multi_process.rst | 6 +- doc/guides/sample_app_ug/packet_ordering.rst | 8 +- .../sample_app_ug/performance_thread.rst | 6 +- doc/guides/sample_app_ug/qos_scheduler.rst | 4 +- doc/guides/sample_app_ug/timer.rst | 13 +- doc/guides/testpmd_app_ug/run_app.rst | 2 +- doc/guides/testpmd_app_ug/testpmd_funcs.rst | 2 +- drivers/bus/dpaa/dpaa_bus.c | 2 +- drivers/bus/fslmc/portal/dpaa2_hw_dpio.c | 6 +- drivers/net/bnxt/bnxt_ring.c | 4 +- drivers/net/memif/memif.h | 40 +++--- drivers/net/memif/memif_socket.c | 54 ++++---- drivers/net/memif/memif_socket.h | 5 +- drivers/net/memif/rte_eth_memif.c | 128 +++++++++--------- drivers/net/memif/rte_eth_memif.h | 20 +-- drivers/net/mvpp2/mrvl_ethdev.c | 6 +- drivers/net/qede/base/bcm_osal.c | 4 +- drivers/net/softnic/rte_eth_softnic_thread.c | 4 +- drivers/vdpa/ifc/ifcvf_vdpa.c | 4 +- drivers/vdpa/mlx5/mlx5_vdpa.c | 4 +- examples/bbdev_app/main.c | 14 +- examples/bond/main.c | 8 +- examples/distributor/main.c | 10 +- examples/ethtool/ethtool-app/main.c | 10 +- examples/eventdev_pipeline/main.c | 2 +- examples/flow_classify/flow_classify.c | 2 +- examples/helloworld/main.c | 6 +- examples/ioat/ioatfwd.c | 6 +- examples/ip_fragmentation/main.c | 4 +- examples/ip_pipeline/main.c | 2 +- examples/ip_pipeline/thread.c | 16 +-- examples/ip_reassembly/main.c | 4 +- examples/ipsec-secgw/event_helper.c | 6 +- examples/ipsec-secgw/ipsec-secgw.c | 4 +- examples/ipv4_multicast/main.c | 4 +- examples/kni/main.c | 7 +- examples/l2fwd-cat/l2fwd-cat.c | 2 +- examples/l2fwd-crypto/main.c | 8 +- examples/l2fwd-event/l2fwd_event_generic.c | 2 +- .../l2fwd-event/l2fwd_event_internal_port.c | 2 +- examples/l2fwd-event/l2fwd_poll.c | 2 +- examples/l2fwd-event/main.c | 2 +- examples/l2fwd-jobstats/main.c | 4 +- examples/l2fwd-keepalive/main.c | 6 +- examples/l2fwd/main.c | 8 +- examples/l3fwd-acl/main.c | 4 +- examples/l3fwd-graph/main.c | 14 +- examples/l3fwd-power/main.c | 20 +-- examples/l3fwd/main.c | 2 +- examples/link_status_interrupt/main.c | 8 +- .../client_server_mp/mp_server/main.c | 10 +- examples/multi_process/simple_mp/main.c | 6 +- examples/multi_process/symmetric_mp/main.c | 2 +- examples/ntb/ntb_fwd.c | 14 +- examples/packet_ordering/main.c | 22 +-- .../performance-thread/l3fwd-thread/main.c | 12 +- .../performance-thread/pthread_shim/main.c | 4 +- examples/ptpclient/ptpclient.c | 2 +- examples/qos_meter/main.c | 4 +- examples/qos_sched/args.c | 22 +-- examples/qos_sched/cmdline.c | 2 +- examples/qos_sched/main.c | 2 +- examples/rxtx_callbacks/main.c | 2 +- examples/server_node_efd/server/main.c | 10 +- examples/skeleton/basicfwd.c | 2 +- examples/tep_termination/main.c | 12 +- examples/timer/main.c | 8 +- examples/vhost/main.c | 10 +- examples/vmdq/main.c | 4 +- examples/vmdq_dcb/main.c | 6 +- lib/librte_eal/common/eal_common_launch.c | 36 ++--- lib/librte_eal/common/eal_common_lcore.c | 11 +- lib/librte_eal/common/eal_common_options.c | 62 ++++----- lib/librte_eal/common/eal_options.h | 4 +- lib/librte_eal/common/eal_private.h | 6 +- lib/librte_eal/common/eal_thread.h | 6 +- lib/librte_eal/common/rte_random.c | 2 +- lib/librte_eal/common/rte_service.c | 2 +- lib/librte_eal/freebsd/eal.c | 24 ++-- lib/librte_eal/freebsd/eal_thread.c | 34 ++--- lib/librte_eal/include/rte_eal.h | 4 +- lib/librte_eal/include/rte_eal_trace.h | 4 +- lib/librte_eal/include/rte_launch.h | 62 +++++---- lib/librte_eal/include/rte_lcore.h | 31 ++++- lib/librte_eal/linux/eal.c | 24 ++-- lib/librte_eal/linux/eal_memory.c | 10 +- lib/librte_eal/linux/eal_thread.c | 34 ++--- lib/librte_eal/rte_eal_version.map | 1 + lib/librte_eal/windows/eal.c | 14 +- lib/librte_eal/windows/eal_thread.c | 32 ++--- lib/librte_kni/rte_kni.h | 2 +- lib/librte_power/rte_power_empty_poll.c | 2 +- lib/librte_vhost/rte_vhost.h | 16 +-- lib/librte_vhost/rte_vhost_version.map | 2 +- lib/librte_vhost/vhost.c | 4 +- lib/librte_vhost/vhost.h | 4 +- lib/librte_vhost/vhost_crypto.c | 2 +- lib/librte_vhost/vhost_user.c | 96 ++++++------- lib/librte_vhost/vhost_user.h | 41 +++--- 174 files changed, 1074 insertions(+), 1041 deletions(-)
Comments
On 01-Jul-20 9:23 PM, Stephen Hemminger wrote: > This set of patches changes the API and conventions around referring > to DPDK lcores. The first patch changes rte_get_master_lcore_id > and related calls. The rest fix the DPDK to use the new naming. > > Buried in the documentation set are a couple of patches where > we were using incorrect naming around primary/secondary process. > > This will could/should be flagged as an API policy violation > since new API is jumping the queue of EXPERIMENTAL. But we can > vote on the exception. > > The one area left to be fixed is the bonding device. > > v4 > - fix checkpatch warnings > note: this patchset will cause some false positives > v3 > - modify vhost to replace slave with client > - modify memif to replace slave with client > - fix variable names s2m becomes i2w etc. > Hi Stephen, This patchset does not apply on the latest master. Please rebase and resend.
On 01-Jul-20 9:23 PM, Stephen Hemminger wrote: > This set of patches changes the API and conventions around referring > to DPDK lcores. The first patch changes rte_get_master_lcore_id > and related calls. The rest fix the DPDK to use the new naming. > > Buried in the documentation set are a couple of patches where > we were using incorrect naming around primary/secondary process. > > This will could/should be flagged as an API policy violation > since new API is jumping the queue of EXPERIMENTAL. But we can > vote on the exception. > > The one area left to be fixed is the bonding device. > I am not too sure about the "initial" core term, it doesn't strike me as immediately obvious as to what "initial" core does. Perhaps "main" lcore would be more descriptive?