mbox series

[0/8] Fips validation fixes

Message ID 20190919121232.4864-1-michaelsh@marvell.com (mailing list archive)
Headers
Series Fips validation fixes |

Message

Michael Shamis Sept. 19, 2019, 12:12 p.m. UTC 
  From: Michael Shamis <michaelsh@marvell.com>

Include fixes related to SHA, TDES and GCM.

Michael Shamis (8):
  examples/fips_validation: separation between HMAC-SHA and SHA
  examples/fips_validation: fix structs used for AES-GCM
  examples/fips_validation: initialize IV for AES-GCM
  examples/fips_validation: move digest after cipher text
  examples/fips_validation: fix AES-GCM decryption vector
  examples/fips_validation: fix overwrite of KEY line in TDES
  examples/fips_validation: improve algo parsing logic
  examples/fips_validation: fix plain text overwrite

 examples/fips_validation/fips_validation.c    | 85 +++++++++++++++++--
 .../fips_validation/fips_validation_gcm.c     | 39 +++++++--
 examples/fips_validation/main.c               | 15 +++-
 3 files changed, 119 insertions(+), 20 deletions(-)

Comments

Akhil Goyal Sept. 19, 2019, 1:15 p.m. UTC | #1 
Hi Michael,

I see that there are compilation issues with meson build
Please check http://mails.dpdk.org/archives/test-report/2019-September/098161.html

Also run devtools/check-git-log.sh -<number of patches>.

You should have a fixes line in each of the fix commits as stated earlier also.
Please have a look at http://doc.dpdk.org/guides/contributing/patches.html for any clarification.

Thanks,
Akhil

> -----Original Message-----
> From: michaelsh@marvell.com <michaelsh@marvell.com>
> Sent: Thursday, September 19, 2019 5:42 PM
> To: Akhil Goyal <akhil.goyal@nxp.com>
> Cc: stable@dpdk.org; dev@dpdk.org; marko.kovacevic@intel.com;
> lironh@marvell.com; michaelsh@marvell.com
> Subject: [PATCH 0/8] Fips validation fixes
> 
> From: Michael Shamis <michaelsh@marvell.com>
> 
> Include fixes related to SHA, TDES and GCM.
> 
> Michael Shamis (8):
>   examples/fips_validation: separation between HMAC-SHA and SHA
>   examples/fips_validation: fix structs used for AES-GCM
>   examples/fips_validation: initialize IV for AES-GCM
>   examples/fips_validation: move digest after cipher text
>   examples/fips_validation: fix AES-GCM decryption vector
>   examples/fips_validation: fix overwrite of KEY line in TDES
>   examples/fips_validation: improve algo parsing logic
>   examples/fips_validation: fix plain text overwrite
> 
>  examples/fips_validation/fips_validation.c    | 85 +++++++++++++++++--
>  .../fips_validation/fips_validation_gcm.c     | 39 +++++++--
>  examples/fips_validation/main.c               | 15 +++-
>  3 files changed, 119 insertions(+), 20 deletions(-)
> 
> --
> 2.23.0