Message ID | 20190220230023.17029-1-dharmik.thakkar@arm.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 51E8C20BD; Thu, 21 Feb 2019 00:00:37 +0100 (CET) Received: from foss.arm.com (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by dpdk.org (Postfix) with ESMTP id 041751F28 for <dev@dpdk.org>; Thu, 21 Feb 2019 00:00:34 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5CBC1EBD; Wed, 20 Feb 2019 15:00:34 -0800 (PST) Received: from 2p2660v4-1.austin.arm.com (2p2660v4-1.austin.arm.com [10.118.12.58]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 233433F719; Wed, 20 Feb 2019 15:00:34 -0800 (PST) From: Dharmik Thakkar <dharmik.thakkar@arm.com> To: Cc: dev@dpdk.org, Dharmik Thakkar <dharmik.thakkar@arm.com> Date: Wed, 20 Feb 2019 17:00:20 -0600 Message-Id: <20190220230023.17029-1-dharmik.thakkar@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190220224714.16303-1-dharmik.thakkar@arm.com> References: <20190220224714.16303-1-dharmik.thakkar@arm.com> Subject: [dpdk-dev] [PATCH v3 0/3] Replace compilation time options with log level X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
Replace compilation time options with log level
|
|
Message
Dharmik Thakkar
Feb. 20, 2019, 11 p.m. UTC
Currently, in test code, for printing extra information, compilation time options are used. This approach does not compile the code always. Macro needs to be set for the code to compile. This patchset replaces compilation time option with log level based approach, thus enabling compilation of code always. Log levels can be set using eal parameters. Dharmik Thakkar (3): test/hash: replace macro with log-level approach test/efd: enable unit test compilation always test/timer: enable unit test compilation always test/test/test_efd.c | 24 ++++++++---------------- test/test/test_hash.c | 3 +-- test/test/test_timer_racecond.c | 23 ++++++++++------------- 3 files changed, 19 insertions(+), 31 deletions(-)
Comments
On Wed, 20 Feb 2019 17:00:20 -0600 Dharmik Thakkar <dharmik.thakkar@arm.com> wrote: > Currently, in test code, for printing extra information, > compilation time options are used. This approach does not compile the > code always. Macro needs to be set for the code to compile. > > This patchset replaces compilation time option with log level based > approach, thus enabling compilation of code always. Log levels can be > set using eal parameters. > > Dharmik Thakkar (3): > test/hash: replace macro with log-level approach > test/efd: enable unit test compilation always > test/timer: enable unit test compilation always > > test/test/test_efd.c | 24 ++++++++---------------- > test/test/test_hash.c | 3 +-- > test/test/test_timer_racecond.c | 23 ++++++++++------------- > 3 files changed, 19 insertions(+), 31 deletions(-) > Maybe the tests should use their own dynamic logging (i.e. --log-level=test.hash:debug)
> On Feb 20, 2019, at 5:08 PM, Stephen Hemminger <stephen@networkplumber.org> wrote: > > On Wed, 20 Feb 2019 17:00:20 -0600 > Dharmik Thakkar <dharmik.thakkar@arm.com> wrote: > >> Currently, in test code, for printing extra information, >> compilation time options are used. This approach does not compile the >> code always. Macro needs to be set for the code to compile. >> >> This patchset replaces compilation time option with log level based >> approach, thus enabling compilation of code always. Log levels can be >> set using eal parameters. >> >> Dharmik Thakkar (3): >> test/hash: replace macro with log-level approach >> test/efd: enable unit test compilation always >> test/timer: enable unit test compilation always >> >> test/test/test_efd.c | 24 ++++++++---------------- >> test/test/test_hash.c | 3 +-- >> test/test/test_timer_racecond.c | 23 ++++++++++------------- >> 3 files changed, 19 insertions(+), 31 deletions(-) >> > > Maybe the tests should use their own dynamic logging (i.e. --log-level=test.hash:debug) Updated. Thank you!