From patchwork Mon Dec 3 15:10:33 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxime Coquelin X-Patchwork-Id: 48506 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5FC7A1B3A1; Mon, 3 Dec 2018 16:11:12 +0100 (CET) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 849D81B39F for ; Mon, 3 Dec 2018 16:11:10 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D3FD03086268; Mon, 3 Dec 2018 15:11:09 +0000 (UTC) Received: from localhost.localdomain (ovpn-112-44.ams2.redhat.com [10.36.112.44]) by smtp.corp.redhat.com (Postfix) with ESMTP id 14B9E7FD36; Mon, 3 Dec 2018 15:10:40 +0000 (UTC) From: Maxime Coquelin To: dev@dpdk.org, jfreimann@redhat.com, tiwei.bie@intel.com, zhihong.wang@intel.com Cc: Maxime Coquelin Date: Mon, 3 Dec 2018 16:10:33 +0100 Message-Id: <20181203151036.11293-1-maxime.coquelin@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.49]); Mon, 03 Dec 2018 15:11:09 +0000 (UTC) Subject: [dpdk-dev] [PATCH 0/3] net/virtio: Rx paths cleanup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This is series mainly merges out-of-order mergeable and non-mergeable Rx paths. Doing so, we remove one path, and micro-benchmark does not show any performance regression: +---------+----------+----------+----------+----------+----------+ | V18.11 | v18.11 + Rx paths merge | +---------+----------+----------+----------+----------+----------+ | 1 queue | 2 queues | 3 queues | 1 queue | 2 queues | 3 queues | +-----+---------+---------+----------+----------+----------+----------+----------+ | MRG | Rxonly | 16.22 | 32.47 | 48.81 | 16.31 | 32.62 | 48.88 | | OFF | IO loop | 12.86 | 25.69 | 38.16 | 12.88 | 25.74 | 38.53 | +-----+---------+---------+----------+----------+----------+----------+----------+ | MRG | Rxonly | 16.27 | 32.65 | 48.81 | 16.29 | 32.67 | 48.77 | | ON | IO loop | 12.82 | 25.59 | 37.86 | 12.86 | 25.68 | 37.9 | +-----+---------+---------+----------+----------+----------+----------+----------+ Note that to avoid vector path to be selected as this benchmark is done without offloads, I had to do this small change to disable it in virtio_dev_configure(): - hw->use_simple_rx = 1; + hw->use_simple_rx = 0; The series also enables in-order path selection when mergeable buffers feature is disabled. Offload and refill helpers are also changed to be inlined. Maxime Coquelin (3): net/virtio: inline refill and offload helpers net/virtio: merge Rx mergeable and non-mergeable paths net/virtio: add non-mergeable support to in-order path drivers/net/virtio/virtio_ethdev.c | 16 +--- drivers/net/virtio/virtio_ethdev.h | 5 +- drivers/net/virtio/virtio_rxtx.c | 133 ++++------------------------- 3 files changed, 22 insertions(+), 132 deletions(-)