From patchwork Sun Oct 7 09:32:39 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Monjalon X-Patchwork-Id: 46200 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 726F4374E; Sun, 7 Oct 2018 11:32:55 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 4AA832C28 for ; Sun, 7 Oct 2018 11:32:53 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id BC6FE21EBD; Sun, 7 Oct 2018 05:32:52 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sun, 07 Oct 2018 05:32:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=mesmtp; bh=zQuSd9iItF i9aGXFYadMqznH9a6l+TeS9wqsrSzcIJA=; b=h/NzIykCrjFRvmG+fNI8fDyCJd aBJnnmLaWwXZ3UV70bKQ80npHBSWqev4VMVIO4gTbnv1K4UKAk8e8ntLPpoUNaIA Hy3++CrxUijFeg2f3se/OqcCJYCGG6skacGSq3C6+EB3cfBf7nqeadJgykyRLLdR Wqa7DoDYFjPQ+qBGw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; bh=zQuSd9iItFi9aGXFYadMqznH9a6l+TeS9wqsrSzcIJA=; b=Q5XyuD5w HxZ7yGq+BbhpFzKbDkiTECM215HGUZXsWsTX2MoNI37JPGdJQY7BOyt3eLeznWSw tYkD/eI+vCiqIU15To31bDZZfwHfgDd3SyW0PspAv2R1mGAJYou0+o2y8AbFvfXS hSNtlLuYYNqObqErrCcwFcq8fv34S42thi0cGmp/598oN87PIsQlZuMjP0hd1obs zmGGC1g6P4TDkpdgKBFxp7HN8CwcOmayQM2BFqCxVX+ecpRmr/lznru3qpxsMtSC lOplTaUWjeyRCC4ydt8bsz96oWppI7LOBio3UxqTUGVpgFvQfzcDZ27VD+Hb7a8T MpIxEAWCVLFyTQ== X-ME-Sender: X-ME-Proxy: Received: from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 13E79102E8; Sun, 7 Oct 2018 05:32:50 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Cc: gaetan.rivet@6wind.com, ophirmu@mellanox.com, qi.z.zhang@intel.com, ferruh.yigit@intel.com, ktraynor@redhat.com Date: Sun, 7 Oct 2018 11:32:39 +0200 Message-Id: <20181007093244.20659-1-thomas@monjalon.net> X-Mailer: git-send-email 2.19.0 In-Reply-To: <20180907222727.20521-1-thomas@monjalon.net> References: <20180907222727.20521-1-thomas@monjalon.net> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v6 0/5] eal: simplify devargs and hotplug functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This is a follow-up of an idea presented at Dublin during the "hotplug talk". Instead of changing the existing hotplug functions, as in the RFC, some new experimental functions are added. The old functions lose their experimental status in order to provide a non-experimental replacement for deprecated attach/detach functions. It has been discussed briefly in the latest technical board meeting. Changes in v6 - after Gaetan's review: - bump ABI version of all buses (because of rte_device change) - unroll snprintf loop in rte_eal_hotplug_add Changes in v5: - rte_devargs_remove is fixed in case of null devargs (patch 2) - a pointer to the bus is added in rte_device (patch 3) - rte_dev_remove is fixed in case of no devargs (patch 5) Changes in v4 - after Andrew's review: - add API changes in release notes (patches 1 & 2) - fix memory leak in rte_eal_hotplug_add (patch 4) Change in v3: - fix null dereferencing in error path (patch 2) Thomas Monjalon (5): devargs: remove deprecated functions devargs: simplify parameters of removal function eal: add bus pointer in device structure eal: remove experimental flag of hotplug functions eal: simplify parameters of hotplug functions doc/guides/rel_notes/release_18_11.rst | 23 ++++-- drivers/bus/dpaa/Makefile | 2 +- drivers/bus/dpaa/dpaa_bus.c | 2 + drivers/bus/dpaa/meson.build | 2 + drivers/bus/fslmc/Makefile | 2 +- drivers/bus/fslmc/fslmc_bus.c | 2 + drivers/bus/fslmc/meson.build | 2 + drivers/bus/ifpga/Makefile | 2 +- drivers/bus/ifpga/ifpga_bus.c | 6 +- drivers/bus/ifpga/meson.build | 2 + drivers/bus/pci/Makefile | 2 +- drivers/bus/pci/bsd/pci.c | 2 + drivers/bus/pci/linux/pci.c | 1 + drivers/bus/pci/meson.build | 2 + drivers/bus/pci/private.h | 2 + drivers/bus/vdev/Makefile | 2 +- drivers/bus/vdev/meson.build | 2 + drivers/bus/vdev/vdev.c | 9 +-- drivers/bus/vmbus/Makefile | 2 +- drivers/bus/vmbus/linux/vmbus_bus.c | 1 + drivers/bus/vmbus/meson.build | 2 + drivers/bus/vmbus/private.h | 3 + drivers/net/failsafe/failsafe_eal.c | 3 +- drivers/net/failsafe/failsafe_ether.c | 3 +- lib/librte_eal/common/eal_common_dev.c | 90 +++++++++++++-------- lib/librte_eal/common/eal_common_devargs.c | 41 ++-------- lib/librte_eal/common/include/rte_dev.h | 36 +++++++-- lib/librte_eal/common/include/rte_devargs.h | 81 +------------------ lib/librte_eal/rte_eal_version.map | 10 +-- 29 files changed, 155 insertions(+), 184 deletions(-) Reviewed-by: Stephen Hemminger