From patchwork Fri Apr 12 22:52:11 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tyler Retzlaff X-Patchwork-Id: 859 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2023E43E55; Sat, 13 Apr 2024 00:52:31 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D572740684; Sat, 13 Apr 2024 00:52:25 +0200 (CEST) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 55B9540263 for ; Sat, 13 Apr 2024 00:52:23 +0200 (CEST) Received: by linux.microsoft.com (Postfix, from userid 1086) id 6B2D020EBE36; Fri, 12 Apr 2024 15:52:22 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 6B2D020EBE36 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1712962342; bh=7Db3XmChr17otr/k4MEYpiSe2/NpqBkKKlcUy2T4rBw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qbkAsAeWYBYWcVy69t82liDaMtoCNjdRu0hOdexGTDcLvYrXfxvQECsL+BvAlqy9d Of1+9RNOemS1MKvF+NEo1976BQAxLMC1wNy0Fh1Xk9LvHhdDGhCKsIkR/3wjVHNRVP RaijzqldjH1tkKP34Gs4D3YU1STxjGkAAmbS4SYU= From: Tyler Retzlaff To: dev@dpdk.org Cc: Bruce Richardson , Harman Kalra , Tyler Retzlaff Subject: [PATCH v3 0/2] build and install only one library type on Windows Date: Fri, 12 Apr 2024 15:52:11 -0700 Message-Id: <1712962333-14355-1-git-send-email-roretzla@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1710445477-23848-1-git-send-email-roretzla@linux.microsoft.com> References: <1710445477-23848-1-git-send-email-roretzla@linux.microsoft.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org MSVC is the only compiler that can produce usable shared libraries for DPDK on Windows because of the use of exported TLS variables. Disable building of shared libraries with LLVM and MinGW so that remaining __declspec macros needed for the functional libraries built by MSVC can be used without triggering errors in LLVM and MinGW builds. For Windows only install the default_library type to avoid confusion. Windows builds cannot build both shared and static in a single pass so install only the functional variant MSVC does not guarantee any kind of compatibility for static libraries so they should not be packaged and instead they should be rebuilt along with the application using the same version of the compiler & linker. Because of this we have chosen to build only one library type at a time instead of compiling twice to produce both types in a single pass. v3: * condense library, target and toolchain type logic determining values for is_shared_enabled,install_{static,shared} values. * define empty shared_dep object to allow unconditional evaluation of shared variables even when is_shared_enabled is false. * use default_library() string to determine deps for chkincs. Tyler Retzlaff (2): build: build only one library type on Windows buildtools: when building static library use static deps app/meson.build | 6 +++ buildtools/chkincs/meson.build | 5 ++- config/meson.build | 20 ++++++++++ drivers/meson.build | 64 +++++++++++++++---------------- drivers/net/octeontx/base/meson.build | 2 +- examples/meson.build | 6 +++ lib/meson.build | 72 +++++++++++++++-------------------- 7 files changed, 97 insertions(+), 78 deletions(-)