From patchwork Sat Feb 24 08:21:45 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tyler Retzlaff X-Patchwork-Id: 682 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 908AF43BBD; Sat, 24 Feb 2024 09:23:59 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1032F402D9; Sat, 24 Feb 2024 09:23:54 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 0AFA5402A8 for ; Sat, 24 Feb 2024 09:22:12 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id 2CFFA20B74C0; Sat, 24 Feb 2024 00:22:11 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 2CFFA20B74C0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1708762931; bh=OoK4rapXckkzpG0y5/LyvJYky2hhsGycXpdU7ZA25t4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hOVSdp9HPoAO/v4mg18MMPovc3VEoqrf+C3p6OOmMB1bywBWxutOC/rg/4pjZEaVJ KYzh4a3wC9BmCsZCrTi6afxD0fJWr4U59c9qH75iAmEafKizC6AYgMDevL/JRkdl8Z UbFCrneulUknpcHAHmvCmiAhtU3MFT7e0ayfio4o= From: Tyler Retzlaff To: dev@dpdk.org Cc: Ajit Khaparde , Andrew Boyer , Andrew Rybchenko , Bruce Richardson , Chenbo Xia , Chengwen Feng , Dariusz Sosnowski , David Christensen , Hyong Youb Kim , Jerin Jacob , Jie Hai , Jingjing Wu , John Daley , Kevin Laatz , Kiran Kumar K , Konstantin Ananyev , Maciej Czekaj , Matan Azrad , Maxime Coquelin , Nithin Dabilpuram , Ori Kam , Ruifeng Wang , Satha Rao , Somnath Kotur , Suanming Mou , Sunil Kumar Kori , Viacheslav Ovsiienko , Yisen Zhuang , Yuying Zhang , mb@smartsharesystems.com, Tyler Retzlaff Subject: [PATCH v5 00/22] stop using RTE_MARKER extensions Date: Sat, 24 Feb 2024 00:21:45 -0800 Message-Id: <1708762927-14126-1-git-send-email-roretzla@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1706657173-26166-1-git-send-email-roretzla@linux.microsoft.com> References: <1706657173-26166-1-git-send-email-roretzla@linux.microsoft.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org RTE_MARKER typedefs are a GCC extension unsupported by MSVC. This series hides the markers when building with MSVC and updates libraries and drivers to access compatibly typed pointers to the rte_mbuf struct offsets. This series, does the following. Introduces a new macro __rte_marker(type, name) which is used to conditionally expand RTE_MARKER fields empty when building with GCC. Updates existing inline functions accessing cacheline{0,1} markers in the rte_mbuf struct to stop using the markers and instead uses the mbuf fields directly. Introduces 2 new inline functions to allow drivers to access rearm_data and rx_descriptor_fields1 descriptors without using the RTE_MARKER fields. Updates all drivers to use the new inline rte_mbuf struct accessors for rearm_data and rx_descriptor_fields1. Any previous Acks on the series are considered to be reset due to amount of change. v5: * update existing cacheline{0, 1} inline functions to access actual mbuf fields. * introduce new inline functions for accessing rearm_data and rx_descriptor_fields1 descriptors. * adapt drivers to use new inline functions. prior versions not relevant due to re-work of entire series. Tyler Retzlaff (22): eal: provide macro to expand marker extensions mbuf: expand rte markers empty when building with MSVC security: expand rte markers empty when building with MSVC cryptodev: expand rte markers empty when building with MSVC mbuf: stop using mbuf cacheline marker fields mbuf: add mbuf descriptor accessors common/idpf: use mbuf descriptor accessors net/bnxt: use mbuf descriptor accessors net/cnxk: use mbuf descriptor accessors net/enic: use mbuf descriptor accessors net/fm10k: use mbuf descriptor accessors net/hns3: use mbuf descriptor accessors net/i40e: use mbuf descriptor accessors net/iavf: use mbuf descriptor accessors net/ice: use mbuf descriptor accessors net/ionic: use mbuf descriptor accessors net/ixgbe: use mbuf descriptor accessors net/mlx5: use mbuf descriptor accessors net/octeon_ep: use mbuf descriptor accessors net/sfc: use mbuf descriptor accessors net/thunderx: use mbuf descriptor accessors net/virtio: use mbuf descriptor accessors drivers/common/idpf/idpf_common_rxtx.c | 4 +-- drivers/common/idpf/idpf_common_rxtx_avx512.c | 33 ++++++++++++----------- drivers/net/bnxt/bnxt_rxtx_vec_avx2.c | 32 +++++++++++----------- drivers/net/bnxt/bnxt_rxtx_vec_common.h | 4 +-- drivers/net/bnxt/bnxt_rxtx_vec_neon.c | 16 +++++------ drivers/net/bnxt/bnxt_rxtx_vec_sse.c | 16 +++++------ drivers/net/cnxk/cn10k_rx.h | 36 ++++++++++++------------- drivers/net/cnxk/cn9k_rx.h | 20 +++++++------- drivers/net/cnxk/cnxk_ethdev.c | 2 +- drivers/net/enic/enic_main.c | 4 +-- drivers/net/enic/enic_rxtx_vec_avx2.c | 18 ++++++------- drivers/net/fm10k/fm10k_rxtx_vec.c | 19 +++++-------- drivers/net/hns3/hns3_rxtx_vec.c | 4 +-- drivers/net/hns3/hns3_rxtx_vec_neon.h | 16 +++++------ drivers/net/i40e/i40e_rxtx_vec_altivec.c | 18 +++++-------- drivers/net/i40e/i40e_rxtx_vec_avx2.c | 16 +++++------ drivers/net/i40e/i40e_rxtx_vec_avx512.c | 16 +++++------ drivers/net/i40e/i40e_rxtx_vec_common.h | 4 +-- drivers/net/i40e/i40e_rxtx_vec_neon.c | 16 +++++------ drivers/net/i40e/i40e_rxtx_vec_sse.c | 16 +++++------ drivers/net/iavf/iavf_rxtx_vec_avx2.c | 32 +++++++++++----------- drivers/net/iavf/iavf_rxtx_vec_avx512.c | 32 +++++++++++----------- drivers/net/iavf/iavf_rxtx_vec_common.h | 4 +-- drivers/net/iavf/iavf_rxtx_vec_neon.c | 16 +++++------ drivers/net/iavf/iavf_rxtx_vec_sse.c | 32 +++++++++++----------- drivers/net/ice/ice_rxtx_vec_avx2.c | 16 +++++------ drivers/net/ice/ice_rxtx_vec_avx512.c | 16 +++++------ drivers/net/ice/ice_rxtx_vec_common.h | 4 +-- drivers/net/ice/ice_rxtx_vec_sse.c | 16 +++++------ drivers/net/ionic/ionic_lif.c | 4 +-- drivers/net/ionic/ionic_rxtx_sg.c | 4 +-- drivers/net/ionic/ionic_rxtx_simple.c | 2 +- drivers/net/ixgbe/ixgbe_rxtx_vec_common.h | 4 +-- drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c | 12 ++++----- drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c | 24 ++++++++--------- drivers/net/mlx5/mlx5_rxq.c | 2 +- drivers/net/mlx5/mlx5_rxtx_vec_altivec.h | 28 +++++++++---------- drivers/net/mlx5/mlx5_rxtx_vec_neon.h | 20 +++++++------- drivers/net/mlx5/mlx5_rxtx_vec_sse.h | 28 +++++++++---------- drivers/net/octeon_ep/cnxk_ep_rx.h | 2 +- drivers/net/octeon_ep/cnxk_ep_rx_avx.c | 2 +- drivers/net/octeon_ep/cnxk_ep_rx_neon.c | 8 +++--- drivers/net/octeon_ep/cnxk_ep_rx_sse.c | 8 +++--- drivers/net/octeon_ep/otx_ep_rxtx.c | 5 +--- drivers/net/sfc/sfc_ef100_rx.c | 4 +-- drivers/net/sfc/sfc_ef10_rx.c | 6 ++--- drivers/net/thunderx/nicvf_ethdev.c | 4 +-- drivers/net/thunderx/nicvf_rxtx.h | 4 +-- drivers/net/virtio/virtio_rxtx_packed_avx.h | 10 +++---- drivers/net/virtio/virtio_rxtx_packed_neon.h | 16 +++++------ drivers/net/virtio/virtio_rxtx_simple.c | 4 +-- drivers/net/virtio/virtio_rxtx_simple.h | 5 +--- drivers/net/virtio/virtio_rxtx_simple_altivec.c | 16 +++++------ drivers/net/virtio/virtio_rxtx_simple_neon.c | 24 ++++++----------- drivers/net/virtio/virtio_rxtx_simple_sse.c | 16 +++++------ lib/cryptodev/cryptodev_pmd.h | 5 ++-- lib/eal/include/rte_common.h | 8 +++++- lib/mbuf/rte_mbuf.h | 28 +++++++++++++++++-- lib/mbuf/rte_mbuf_core.h | 10 +++---- lib/security/rte_security_driver.h | 5 ++-- 60 files changed, 392 insertions(+), 404 deletions(-)