From patchwork Wed Feb 14 04:17:36 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tyler Retzlaff X-Patchwork-Id: 642 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 61E5943B1F; Wed, 14 Feb 2024 05:17:55 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E063B42E51; Wed, 14 Feb 2024 05:17:54 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 722D942E51 for ; Wed, 14 Feb 2024 05:17:52 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id 88F82207F20D; Tue, 13 Feb 2024 20:17:51 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 88F82207F20D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1707884271; bh=BpbO3LHSUemtMQp+Su+DGuB+PfKZ0+I24rf4Kr3/+xU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=L2Ja6zR/I3IVaEzPzsT32Tnf2jQf1N6RyfetKJ1TpxfPvNoBxQWzGIuKTfedNnMWa 2N3Inxgq52+DszFT6xIfH8DO2+uoYaMmMdBrQ/C8oVIqpvB7J5ET+Y636Yt+7HKbfP MlvSyXcAqU0PzGp3HYnYU2G7toB1kimpMliibvR4= From: Tyler Retzlaff To: dev@dpdk.org Cc: Andrew Rybchenko , Bruce Richardson , Chengwen Feng , Cristian Dumitrescu , David Christensen , David Hunt , Ferruh Yigit , Honnappa Nagarahalli , Jasvinder Singh , Jerin Jacob , Kevin Laatz , Konstantin Ananyev , Min Zhou , Ruifeng Wang , Sameh Gobriel , Stanislaw Kardach , Thomas Monjalon , Vladimir Medvedkin , Yipeng Wang , Tyler Retzlaff Subject: [PATCH v2 00/14] use C11 alignas and normalize type alignment Date: Tue, 13 Feb 2024 20:17:36 -0800 Message-Id: <1707884270-27189-1-git-send-email-roretzla@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1707873986-29352-1-git-send-email-roretzla@linux.microsoft.com> References: <1707873986-29352-1-git-send-email-roretzla@linux.microsoft.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This series normalizes type and object alignment by doing the following. Fill in expansion of existing __rte_aligned, __rte_cache_aligned and __rte_cache_min_aligned macros for MSVC. Where __rte_aligned, __rte_cache_aligned and __rte_cache_min_aligned are used to align *types* move them to a location on the type definition that both GCC and MSVC accept for both C and C++ compilation. Where __rte_aligned, __rte_cache_aligned or __rte_cache_min_aligned are used to align *objects* replace their usage with standard C11 alignas. I've elected to put the series forward without introducing a new macro similar to __rte_alignas. Assuming the convention of a lower case macro starting with __rte is intended to be internal only and providing it would only permit unintended use by applications. v2: * add missing #include for alignas macro. Tyler Retzlaff (14): eal: use C11 alignas stack: use C11 alignas sched: use C11 alignas ring: remove unnecessary explicit alignment pipeline: use C11 alignas net: use C11 alignas mbuf: remove unnecessary explicit alignment hash: use C11 alignas eventdev: use C11 alignas ethdev: use C11 alignas dmadev: use C11 alignas distributor: use C11 alignas acl: use C11 alignas eal: redefine macro to be integer literal for MSVC lib/acl/acl_run.h | 4 ++-- lib/distributor/rte_distributor.c | 3 ++- lib/dmadev/rte_dmadev_core.h | 4 ++-- lib/eal/arm/include/rte_vect.h | 4 ++-- lib/eal/include/generic/rte_atomic.h | 4 ++-- lib/eal/include/rte_common.h | 2 +- lib/eal/loongarch/include/rte_vect.h | 8 ++++---- lib/eal/ppc/include/rte_vect.h | 4 ++-- lib/eal/riscv/include/rte_vect.h | 4 ++-- lib/eal/x86/include/rte_vect.h | 9 ++++++--- lib/ethdev/rte_ethdev.h | 4 ++-- lib/eventdev/rte_eventdev.h | 8 ++++---- lib/hash/rte_thash.h | 8 ++++---- lib/mbuf/rte_mbuf_core.h | 2 +- lib/net/net_crc_avx512.c | 14 ++++++++------ lib/net/net_crc_neon.c | 11 ++++++----- lib/net/net_crc_sse.c | 17 +++++++++-------- lib/net/rte_arp.h | 8 ++++---- lib/net/rte_ether.h | 8 ++++---- lib/pipeline/rte_table_action.c | 24 ++++++++++++------------ lib/ring/rte_ring_core.h | 4 ++-- lib/sched/rte_sched.c | 3 ++- lib/sched/rte_sched_common.h | 2 -- lib/stack/rte_stack.h | 4 +++- 24 files changed, 86 insertions(+), 77 deletions(-)