From patchwork Thu Apr 6 00:45:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tyler Retzlaff X-Patchwork-Id: 125828 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C1224428D0; Thu, 6 Apr 2023 02:45:28 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3117442BB1; Thu, 6 Apr 2023 02:45:24 +0200 (CEST) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id EC17C40DF6 for ; Thu, 6 Apr 2023 02:45:21 +0200 (CEST) Received: by linux.microsoft.com (Postfix, from userid 1086) id 1E81E210DEF4; Wed, 5 Apr 2023 17:45:21 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 1E81E210DEF4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1680741921; bh=0rawZ4d+5R/2cP2JIJIx78BFH3Kq4pG9STbrb9VGzQE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WuH30FCl5Vjx8ggua/+YIjqvyJKibgcFixROlUri2deUXopIeUebGgLQp3JMhrOAa bHIi93kAJTsTzmS0bbWbWdN23wFQ4xgHVI0UqB82wiFrjANLfS6frclGM2BVv7gygY 1LMVmvZpDgvxq6Xg5g2k91DHyz+AhtbvK4pShFEA= From: Tyler Retzlaff To: dev@dpdk.org Cc: bruce.richardson@intel.com, david.marchand@redhat.com, thomas@monjalon.net, mb@smartsharesystems.com, konstantin.ananyev@huawei.com, Tyler Retzlaff Subject: [PATCH v3 00/11] msvc integration changes Date: Wed, 5 Apr 2023 17:45:08 -0700 Message-Id: <1680741919-22102-1-git-send-email-roretzla@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1680558751-17931-1-git-send-email-roretzla@linux.microsoft.com> References: <1680558751-17931-1-git-send-email-roretzla@linux.microsoft.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org In accordance with draft plan http://mails.dpdk.org/archives/web/2023-February/002023.html introduces conditionally compiled code to enable building with MSVC that _does not_ require C99/C11 meaning it can be integrated now. This series covers minimal changes for item #2 in draft plan for EAL dependencies kvargs, telemetry and consumed EAL public headers. Note if any patch in the series requires in-depth discussion I'll detach it from this series for separate submission & more focused discussion so it doesn't block the entire series. v3: * v3 does not group together conditional blocks when experimented with it didn't reduce conditionals enough to make it worth while. once msvc tests are at a running point i suggest a narrow targeted discussion about code organization without blocking this series * v3 does not attempt to refactor to use intrinsics for non-msvc compilers. again this should be done as a separate follow-up series later if desired * fix expansion of likely and unlikely macros * remove unnecessary define for rte_smp_{r,w}mb it is sufficient for these to be compiler barriers on x86 * add a new patch to use __cpuid and __cpuidex intrinsics when building with msvc * add a new patch to use _umonitor, _umwait and _tpause intrinsics when building with msvc v2: * use _mm_{l,s,m}fence intrinsics for rte_smp_{r,w,}mb macros are intended to be memory barriers not compiler barriers on x86_64. Tyler Retzlaff (11): eal: use rdtsc intrinsic when compiling with msvc eal: use rtm and xtest intrinsics when compiling with msvc eal: use barrier intrinsics when compiling with msvc eal: use cpuid and cpuidex intrinsics eal: use umonitor umwait and tpause intrinsics eal: typedef cpu flag enum as int for msvc eal: hide GCC extension based alignment markers eal: expand most macros to empty when using msvc eal: exclude exposure of rte atomic APIs for MSVC builds telemetry: disable json print formatting with msvc telemetry: avoid expanding versioned symbol macros on msvc lib/eal/include/generic/rte_atomic.h | 11 ++++++++++ lib/eal/include/generic/rte_cpuflags.h | 12 ++++++----- lib/eal/include/rte_branch_prediction.h | 8 +++++++ lib/eal/include/rte_common.h | 37 +++++++++++++++++++++++++++++++++ lib/eal/include/rte_compat.h | 20 ++++++++++++++++++ lib/eal/x86/include/rte_atomic.h | 9 +++++++- lib/eal/x86/include/rte_cycles.h | 8 +++++++ lib/eal/x86/include/rte_rtm.h | 19 +++++++++++++++++ lib/eal/x86/rte_cpuflags.c | 4 ++++ lib/eal/x86/rte_cpuid.h | 7 +++++++ lib/eal/x86/rte_cycles.c | 36 ++++++++++++++++++++++++++++++++ lib/eal/x86/rte_hypervisor.c | 4 ++++ lib/eal/x86/rte_power_intrinsics.c | 12 +++++++++++ lib/telemetry/telemetry_data.c | 16 ++++++++++++++ lib/telemetry/telemetry_json.h | 6 ++++++ 15 files changed, 203 insertions(+), 6 deletions(-)