mbox series

[v9,00/12] preparation for the rte_flow offload of nfp PMD

Message ID 1663238669-12244-1-git-send-email-chaoyong.he@corigine.com (mailing list archive)
Headers
Series preparation for the rte_flow offload of nfp PMD |

Message

Chaoyong He Sept. 15, 2022, 10:44 a.m. UTC 
  * Changes since v8
- Update the nfp.rst
- Fix the 'app_hw' to 'app_fw'
- Remove the ovs compatible header file
- Remove the use of rte_eth_dev_configure()/rte_eth_rx_burst()/rte_eth_dev_start() API

* Changes since v7
- Adjust the logics to make sure not break the pci probe process
- Change 'app' to 'app_fw' in all logics to avoid confuse
- Fix problem about log level

* Changes since v6
- Fix the compile error

* Changes since v5
- Compare integer with 0 explicitly
- Change helper macro to function
- Implement the dummy functions
- Remove some unnecessary logics

* Changes since v4
- Remove the unneeded '__rte_unused' attribute
- Fixup a potential memory leak problem

* Changes since v3
- Add the 'Depends-on' tag

* Changes since v2
- Remove the use of rte_panic()

* Changes since v1
- Fix the compile error

Depends-on: series-23707 ("Add support of NFP3800 chip and firmware with NFDk")

Chaoyong He (12):
  net/nfp: move app specific attributes to own struct
  net/nfp: simplify initialization and remove dead code
  net/nfp: move app specific init logic to own function
  net/nfp: add initial flower firmware support
  net/nfp: add flower PF setup logic
  net/nfp: add flower PF related routines
  net/nfp: add flower ctrl VNIC related logics
  net/nfp: move common rxtx function for flower use
  net/nfp: add flower ctrl VNIC rxtx logic
  net/nfp: add flower representor framework
  net/nfp: move rxtx function to header file
  net/nfp: add flower PF rxtx logic

 doc/guides/nics/nfp.rst                         |   32 +
 doc/guides/rel_notes/release_22_11.rst          |    9 +
 drivers/net/nfp/flower/nfp_flower.c             | 1310 +++++++++++++++++++++++
 drivers/net/nfp/flower/nfp_flower.h             |   70 ++
 drivers/net/nfp/flower/nfp_flower_cmsg.c        |  185 ++++
 drivers/net/nfp/flower/nfp_flower_cmsg.h        |  173 +++
 drivers/net/nfp/flower/nfp_flower_ctrl.c        |  250 +++++
 drivers/net/nfp/flower/nfp_flower_ctrl.h        |   13 +
 drivers/net/nfp/flower/nfp_flower_representor.c |  664 ++++++++++++
 drivers/net/nfp/flower/nfp_flower_representor.h |   39 +
 drivers/net/nfp/meson.build                     |    4 +
 drivers/net/nfp/nfp_common.c                    |    2 +-
 drivers/net/nfp/nfp_common.h                    |   35 +-
 drivers/net/nfp/nfp_cpp_bridge.c                |   88 +-
 drivers/net/nfp/nfp_cpp_bridge.h                |    6 +-
 drivers/net/nfp/nfp_ethdev.c                    |  347 +++---
 drivers/net/nfp/nfp_ethdev_vf.c                 |    2 +-
 drivers/net/nfp/nfp_rxtx.c                      |  123 +--
 drivers/net/nfp/nfp_rxtx.h                      |  121 +++
 drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c      |   31 +-
 20 files changed, 3222 insertions(+), 282 deletions(-)
 create mode 100644 drivers/net/nfp/flower/nfp_flower.c
 create mode 100644 drivers/net/nfp/flower/nfp_flower.h
 create mode 100644 drivers/net/nfp/flower/nfp_flower_cmsg.c
 create mode 100644 drivers/net/nfp/flower/nfp_flower_cmsg.h
 create mode 100644 drivers/net/nfp/flower/nfp_flower_ctrl.c
 create mode 100644 drivers/net/nfp/flower/nfp_flower_ctrl.h
 create mode 100644 drivers/net/nfp/flower/nfp_flower_representor.c
 create mode 100644 drivers/net/nfp/flower/nfp_flower_representor.h

Comments

Ferruh Yigit Sept. 20, 2022, 2:56 p.m. UTC | #1 
On 9/15/2022 11:44 AM, Chaoyong He wrote:
> * Changes since v8
> - Update the nfp.rst
> - Fix the 'app_hw' to 'app_fw'
> - Remove the ovs compatible header file
> - Remove the use of rte_eth_dev_configure()/rte_eth_rx_burst()/rte_eth_dev_start() API
> 
> * Changes since v7
> - Adjust the logics to make sure not break the pci probe process
> - Change 'app' to 'app_fw' in all logics to avoid confuse
> - Fix problem about log level
> 
> * Changes since v6
> - Fix the compile error
> 
> * Changes since v5
> - Compare integer with 0 explicitly
> - Change helper macro to function
> - Implement the dummy functions
> - Remove some unnecessary logics
> 
> * Changes since v4
> - Remove the unneeded '__rte_unused' attribute
> - Fixup a potential memory leak problem
> 
> * Changes since v3
> - Add the 'Depends-on' tag
> 
> * Changes since v2
> - Remove the use of rte_panic()
> 
> * Changes since v1
> - Fix the compile error
> 
> Depends-on: series-23707 ("Add support of NFP3800 chip and firmware with NFDk")
> 
> Chaoyong He (12):
>    net/nfp: move app specific attributes to own struct
>    net/nfp: simplify initialization and remove dead code
>    net/nfp: move app specific init logic to own function
>    net/nfp: add initial flower firmware support
>    net/nfp: add flower PF setup logic
>    net/nfp: add flower PF related routines
>    net/nfp: add flower ctrl VNIC related logics
>    net/nfp: move common rxtx function for flower use
>    net/nfp: add flower ctrl VNIC rxtx logic
>    net/nfp: add flower representor framework
>    net/nfp: move rxtx function to header file
>    net/nfp: add flower PF rxtx logic
> 

Hi Chaoyong,

Patchset looks good, except from two issues we have discussed before, 
those issues are:

* Creating a new ethdev just for driver-FW control communication
* Application (OvS) specific code in the driver

I commented them separately and cc'ed more folks, we can proceed when 
above are resolved.

Thanks,
ferruh