Message ID | 1547613775-58027-1-git-send-email-wei.zhao1@intel.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7594E1041; Wed, 16 Jan 2019 06:08:36 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 8825C9E4; Wed, 16 Jan 2019 06:08:34 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Jan 2019 21:08:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,484,1539673200"; d="scan'208";a="291898605" Received: from dpdk6.bj.intel.com ([172.16.182.192]) by orsmga005.jf.intel.com with ESMTP; 15 Jan 2019 21:08:30 -0800 From: Wei Zhao <wei.zhao1@intel.com> To: dev@dpdk.org Cc: stable@dpdk.org, wenzhuo.lu@intel.com, qi.z.zhang@intel.com Date: Wed, 16 Jan 2019 12:42:52 +0800 Message-Id: <1547613775-58027-1-git-send-email-wei.zhao1@intel.com> X-Mailer: git-send-email 2.7.5 Subject: [dpdk-dev] [PATCH 0/3] promiscuous mode enable on VF X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
promiscuous mode enable on VF
|
|
Message
Zhao1, Wei
Jan. 16, 2019, 4:42 a.m. UTC
There is need to enable promiscuous mode enable on VF, pf host should also enable to support that. Zhao Wei (3): net/ixgbe: promiscuous mode enable on VF net/ixgbe: enable promiscous mode on PF host net/ixgbe: update API version drivers/net/ixgbe/ixgbe_ethdev.c | 21 +++++++++++ drivers/net/ixgbe/ixgbe_ethdev.h | 1 + drivers/net/ixgbe/ixgbe_pf.c | 79 +++++++++++++++++++++++++++++----------- 3 files changed, 79 insertions(+), 22 deletions(-)
Comments
On Wed, Jan 16, 2019 at 6:08 AM Wei Zhao <wei.zhao1@intel.com> wrote: > There is need to enable promiscuous mode enable on VF, > pf host should also enable to support that. > > Zhao Wei (3): > net/ixgbe: promiscuous mode enable on VF > net/ixgbe: enable promiscous mode on PF host > net/ixgbe: update API version > > drivers/net/ixgbe/ixgbe_ethdev.c | 21 +++++++++++ > drivers/net/ixgbe/ixgbe_ethdev.h | 1 + > drivers/net/ixgbe/ixgbe_pf.c | 79 > +++++++++++++++++++++++++++++----------- > 3 files changed, 79 insertions(+), 22 deletions(-) > > -- > 2.7.5 > This series looks more about a missing feature than a proper fix. We have a new pf/vf api supported in this series and a new behaviour for promiscuous. This is not stable material to me unless you expose a clear problem that this series wants to address.
On Wed, 16 Jan 2019 12:42:52 +0800 Wei Zhao <wei.zhao1@intel.com> wrote: > There is need to enable promiscuous mode enable on VF, > pf host should also enable to support that. > > Zhao Wei (3): > net/ixgbe: promiscuous mode enable on VF > net/ixgbe: enable promiscous mode on PF host > net/ixgbe: update API version > > drivers/net/ixgbe/ixgbe_ethdev.c | 21 +++++++++++ > drivers/net/ixgbe/ixgbe_ethdev.h | 1 + > drivers/net/ixgbe/ixgbe_pf.c | 79 +++++++++++++++++++++++++++++----------- > 3 files changed, 79 insertions(+), 22 deletions(-) > Is there someway to check if PF on host allows promiscious mode (and fail the attempt to set it on VF if not allowed).
From: David Marchand [mailto:david.marchand@redhat.com]
Sent: Wednesday, January 16, 2019 4:29 PM
To: Zhao1, Wei <wei.zhao1@intel.com>
Cc: dev@dpdk.org; dpdk stable <stable@dpdk.org>; Lu, Wenzhuo <wenzhuo.lu@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>
Subject: Re: [dpdk-dev] [PATCH 0/3] promiscuous mode enable on VF
On Wed, Jan 16, 2019 at 6:08 AM Wei Zhao <wei.zhao1@intel.com<mailto:wei.zhao1@intel.com>> wrote:
There is need to enable promiscuous mode enable on VF,
pf host should also enable to support that.
Zhao Wei (3):
net/ixgbe: promiscuous mode enable on VF
net/ixgbe: enable promiscous mode on PF host
net/ixgbe: update API version
drivers/net/ixgbe/ixgbe_ethdev.c | 21 +++++++++++
drivers/net/ixgbe/ixgbe_ethdev.h | 1 +
drivers/net/ixgbe/ixgbe_pf.c | 79 +++++++++++++++++++++++++++++-----------
3 files changed, 79 insertions(+), 22 deletions(-)
--
2.7.5
This series looks more about a missing feature than a proper fix.
We have a new pf/vf api supported in this series and a new behaviour for promiscuous.
This is not stable material to me unless you expose a clear problem that this series wants to address.
Yes, this a new feature enable related, but this patch set will not introduce problem, because vf
promiscuous mode is close by default, this set is just send out for request from users that want to use
vf promiscuous. They will open it in their APP. NOT only ixgbe, but also other NIC vf HAS SUPPORT this feature.
--
David Marchand
> -----Original Message----- > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > Sent: Thursday, January 17, 2019 2:59 AM > To: Zhao1, Wei <wei.zhao1@intel.com> > Cc: dev@dpdk.org; stable@dpdk.org; Lu, Wenzhuo > <wenzhuo.lu@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com> > Subject: Re: [dpdk-dev] [PATCH 0/3] promiscuous mode enable on VF > > On Wed, 16 Jan 2019 12:42:52 +0800 > Wei Zhao <wei.zhao1@intel.com> wrote: > > > There is need to enable promiscuous mode enable on VF, pf host should > > also enable to support that. > > > > Zhao Wei (3): > > net/ixgbe: promiscuous mode enable on VF > > net/ixgbe: enable promiscous mode on PF host > > net/ixgbe: update API version > > > > drivers/net/ixgbe/ixgbe_ethdev.c | 21 +++++++++++ > > drivers/net/ixgbe/ixgbe_ethdev.h | 1 + > > drivers/net/ixgbe/ixgbe_pf.c | 79 > +++++++++++++++++++++++++++++----------- > > 3 files changed, 79 insertions(+), 22 deletions(-) > > > > Is there someway to check if PF on host allows promiscious mode (and fail > the attempt to set it on VF if not allowed). Yes, Pf host has check vfinfo[vf].api_version, that is key for that check. If fail, it will return -1. switch (vfinfo[vf].api_version) { case ixgbe_mbox_api_12: + /* promisc introduced in 1.3 version */ + if (xcast_mode == IXGBEVF_XCAST_MODE_PROMISC) + return -EOPNOTSUPP; + break; + /* Fall threw */ + case ixgbe_mbox_api_13: break; default: return -1; }