mbox series

[v1,0/3] ethdev: document more retained across restart

Message ID 1545200580-15467-1-git-send-email-arybchenko@solarflare.com (mailing list archive)
Headers show
Series ethdev: document more retained across restart | expand

Message

Andrew Rybchenko Dec. 19, 2018, 6:22 a.m. UTC
The patch series tries to improve documentation of what is retained
across default restart.

Andrew Rybchenko (3):
  ethdev: advertise MTU as retained across device stop/start
  ethdev: advertise default MAC as retained on device restart
  ethdev: highlight that all-multicast is retained on restart

 lib/librte_ethdev/rte_ethdev.h | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comments

Ferruh Yigit Jan. 8, 2019, 2:52 p.m. UTC | #1
On 12/19/2018 6:22 AM, Andrew Rybchenko wrote:
> The patch series tries to improve documentation of what is retained
> across default restart.

Overall makes sense to add below items into retained list, only concern if is
there any PMD conflicts with these information, they should either updated with
this patch or at least notified about expectation change.

> 
> Andrew Rybchenko (3):
>   ethdev: advertise MTU as retained across device stop/start
>   ethdev: advertise default MAC as retained on device restart
>   ethdev: highlight that all-multicast is retained on restart
> 
>  lib/librte_ethdev/rte_ethdev.h | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
Andrew Rybchenko Jan. 9, 2019, 7:15 a.m. UTC | #2
On 1/8/19 5:52 PM, Ferruh Yigit wrote:
> On 12/19/2018 6:22 AM, Andrew Rybchenko wrote:
>> The patch series tries to improve documentation of what is retained
>> across default restart.
> Overall makes sense to add below items into retained list, only concern if is
> there any PMD conflicts with these information, they should either updated with
> this patch or at least notified about expectation change.

 From my point of view it is just clarification of the required behaviour.
MTU is required because of flag which may be used to advertise that
it is impossible to change in started state (otherwise the behaviour for
different PMDs will be absolutely different).
Default MAC is just cosmetics because of MAC address list is already
mentioned and the only goal is to highlight since these are different
features from the feature list point of view.
All-multicast is a part of Rx mode.

In fact I recall that net/bonding does not preserve all-multicast
(CC maintainers). If there is an agreement to fix it, I can take
a look - it should not be hard to fix.

In general I think that notification is sufficient in this case.

>> Andrew Rybchenko (3):
>>    ethdev: advertise MTU as retained across device stop/start
>>    ethdev: advertise default MAC as retained on device restart
>>    ethdev: highlight that all-multicast is retained on restart
>>
>>   lib/librte_ethdev/rte_ethdev.h | 6 ++++--
>>   1 file changed, 4 insertions(+), 2 deletions(-)
>>
WILLIAMS, CHARLES J Jan. 10, 2019, 2:03 a.m. UTC | #3
On 1/9/19 2:15 AM, Andrew Rybchenko wrote:
On 1/8/19 5:52 PM, Ferruh Yigit wrote:

On 12/19/2018 6:22 AM, Andrew Rybchenko wrote:


The patch series tries to improve documentation of what is retained
across default restart.


Overall makes sense to add below items into retained list, only concern if is
there any PMD conflicts with these information, they should either updated with
this patch or at least notified about expectation change.

From my point of view it is just clarification of the required behaviour.
MTU is required because of flag which may be used to advertise that
it is impossible to change in started state (otherwise the behaviour for
different PMDs will be absolutely different).
Default MAC is just cosmetics because of MAC address list is already
mentioned and the only goal is to highlight since these are different
features from the feature list point of view.
All-multicast is a part of Rx mode.

In fact I recall that net/bonding does not preserve all-multicast
(CC maintainers). If there is an agreement to fix it, I can take
a look - it should not be hard to fix.

I don't think bonding does anything particular because the all_multicast state of the bonding PMD isn't related to the slaves.  Currently, it's up to the applications to correctly configure multicast on the slaves.

On a side note, I don't think the registered multicast addresses are preserved across PMD stop/start (unless this has been fixed recently).

In general I think that notification is sufficient in this case.


Andrew Rybchenko (3):
  ethdev: advertise MTU as retained across device stop/start
  ethdev: advertise default MAC as retained on device restart
  ethdev: highlight that all-multicast is retained on restart

 lib/librte_ethdev/rte_ethdev.h | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
Andrew Rybchenko Jan. 23, 2019, 12:23 p.m. UTC | #4
On 1/10/19 5:03 AM, WILLIAMS, CHARLES J wrote:
>
>
> On 1/9/19 2:15 AM, Andrew Rybchenko wrote:
>> On 1/8/19 5:52 PM, Ferruh Yigit wrote:
>>> On 12/19/2018 6:22 AM, Andrew Rybchenko wrote:
>>>> The patch series tries to improve documentation of what is retained
>>>> across default restart.
>>> Overall makes sense to add below items into retained list, only concern if is
>>> there any PMD conflicts with these information, they should either updated with
>>> this patch or at least notified about expectation change.
>>
>> From my point of view it is just clarification of the required behaviour.
>> MTU is required because of flag which may be used to advertise that
>> it is impossible to change in started state (otherwise the behaviour for
>> different PMDs will be absolutely different).
>> Default MAC is just cosmetics because of MAC address list is already
>> mentioned and the only goal is to highlight since these are different
>> features from the feature list point of view.
>> All-multicast is a part of Rx mode.
>>
>> In fact I recall that net/bonding does not preserve all-multicast
>> (CC maintainers). If there is an agreement to fix it, I can take
>> a look - it should not be hard to fix.
>
> I don't think bonding does anything particular because the 
> all_multicast state of the bonding PMD isn't related to the slaves.  
> Currently, it's up to the applications to correctly configure 
> multicast on the slaves.
>

May be I'm wrong but I think all-multicast handling should be similar to 
promiscuous mode handling in bonding: for all slaves in the case of 
round-robin, balance and broadcast, primary only in the case of active 
backup, TLB and ALB and when slave is added/removed in 802.3ad case.

> On a side note, I don't think the registered multicast addresses are 
> preserved across PMD stop/start (unless this has been fixed recently).
>

Yes, that's true, but I think it is separate story.

>>
>> In general I think that notification is sufficient in this case.
>>
>>>> Andrew Rybchenko (3):
>>>>    ethdev: advertise MTU as retained across device stop/start
>>>>    ethdev: advertise default MAC as retained on device restart
>>>>    ethdev: highlight that all-multicast is retained on restart
>>>>
>>>>   lib/librte_ethdev/rte_ethdev.h | 6 ++++--
>>>>   1 file changed, 4 insertions(+), 2 deletions(-)
>>>>
>>
Ferruh Yigit March 19, 2019, 1:21 p.m. UTC | #5
On 12/19/2018 6:22 AM, Andrew Rybchenko wrote:
> The patch series tries to improve documentation of what is retained
> across default restart.
> 
> Andrew Rybchenko (3):
>   ethdev: advertise MTU as retained across device stop/start
>   ethdev: advertise default MAC as retained on device restart
>   ethdev: highlight that all-multicast is retained on restart
> 

Hi Thomas,

Is there any objection on this patchset? If not I am planning to merge it.

Thanks,
ferruh
Thomas Monjalon March 20, 2019, 2:26 p.m. UTC | #6
19/03/2019 14:21, Yigit, Ferruh:
> On 12/19/2018 6:22 AM, Andrew Rybchenko wrote:
> > The patch series tries to improve documentation of what is retained
> > across default restart.
> > 
> > Andrew Rybchenko (3):
> >   ethdev: advertise MTU as retained across device stop/start
> >   ethdev: advertise default MAC as retained on device restart
> >   ethdev: highlight that all-multicast is retained on restart
> > 
> 
> Hi Thomas,
> 
> Is there any objection on this patchset? If not I am planning to merge it.

No objection, more clarification in doxygen is always good.
Ferruh Yigit March 20, 2019, 3:25 p.m. UTC | #7
On 3/20/2019 2:26 PM, Thomas Monjalon wrote:
> 19/03/2019 14:21, Yigit, Ferruh:
>> On 12/19/2018 6:22 AM, Andrew Rybchenko wrote:
>>> The patch series tries to improve documentation of what is retained
>>> across default restart.
>>>
>>> Andrew Rybchenko (3):
>>>   ethdev: advertise MTU as retained across device stop/start
>>>   ethdev: advertise default MAC as retained on device restart
>>>   ethdev: highlight that all-multicast is retained on restart
>>>
>>
>> Hi Thomas,
>>
>> Is there any objection on this patchset? If not I am planning to merge it.
> 
> No objection, more clarification in doxygen is always good.
> 

This may be defining the behavior more than clarification.

Can I add your explicit ACK?
Thomas Monjalon March 20, 2019, 3:32 p.m. UTC | #8
20/03/2019 16:25, Ferruh Yigit:
> On 3/20/2019 2:26 PM, Thomas Monjalon wrote:
> > 19/03/2019 14:21, Yigit, Ferruh:
> >> On 12/19/2018 6:22 AM, Andrew Rybchenko wrote:
> >>> The patch series tries to improve documentation of what is retained
> >>> across default restart.
> >>>
> >>> Andrew Rybchenko (3):
> >>>   ethdev: advertise MTU as retained across device stop/start
> >>>   ethdev: advertise default MAC as retained on device restart
> >>>   ethdev: highlight that all-multicast is retained on restart
> >>>
> >>
> >> Hi Thomas,
> >>
> >> Is there any objection on this patchset? If not I am planning to merge it.
> > 
> > No objection, more clarification in doxygen is always good.
> > 
> 
> This may be defining the behavior more than clarification.
> 
> Can I add your explicit ACK?

Acked-by: Thomas Monjalon <thomas@monjalon.net>
Ferruh Yigit March 20, 2019, 4:53 p.m. UTC | #9
On 3/20/2019 3:32 PM, Thomas Monjalon wrote:
> 20/03/2019 16:25, Ferruh Yigit:
>> On 3/20/2019 2:26 PM, Thomas Monjalon wrote:
>>> 19/03/2019 14:21, Yigit, Ferruh:
>>>> On 12/19/2018 6:22 AM, Andrew Rybchenko wrote:
>>>>> The patch series tries to improve documentation of what is retained
>>>>> across default restart.
>>>>>
>>>>> Andrew Rybchenko (3):
>>>>>   ethdev: advertise MTU as retained across device stop/start
>>>>>   ethdev: advertise default MAC as retained on device restart
>>>>>   ethdev: highlight that all-multicast is retained on restart
>>>>>
>>>>
>>>> Hi Thomas,
>>>>
>>>> Is there any objection on this patchset? If not I am planning to merge it.
>>>
>>> No objection, more clarification in doxygen is always good.
>>>
>>
>> This may be defining the behavior more than clarification.
>>
>> Can I add your explicit ACK?
> 
> Acked-by: Thomas Monjalon <thomas@monjalon.net>
> 

Series applied to dpdk-next-net/master, thanks.