mbox series

[v3,0/8] Add Marvell NETA PMD

Message ID 1535720386-18775-1-git-send-email-amo@semihalf.com (mailing list archive)
Headers
Series Add Marvell NETA PMD |

Message

Andrzej Ostruszka Aug. 31, 2018, 12:59 p.m. UTC 
  This patch series introduces new PMD for Marvell NETA adapters (MVNETA).
See the documentation for more info.

It is split for easier reviewing.

v3:
    No changes against v2, just resubmitting again to have clean patch
    set after my faulty format-patch.  My apologies for the noise.

v2:
  * fixed couple of checkpatch warnings
  * removed '\n' from MVNETA_LOG invocations (appended by the macro)
  * removed unused MVNETA_MUSDK_DMA_MEMSIZE define
  * changed one printf into MVNETA_LOG
  * removed __func__ from one MVNETA_LOG invocation (inserted
    automatically by the macro)
  * minor grammar/spelling correction in comments
  * removed license text from file with SPDX tag (mvneta.rst)
  * removed misleading part of comment for mvneta_shadow_txq
  * changed authorship of the patches to the original author

Natalie Samsonov (1):
  net/mvneta: add reset statistics callback

Zyta Szpak (7):
  net/mvneta: add neta PMD skeleton
  net/mvneta: add Rx/Tx support
  net/mvneta: support for setting of MTU
  net/mvneta: add link update
  net/mvneta: support for promiscuous
  net/mvneta: add MAC filtering
  net/mvneta: add support for basic stats

 MAINTAINERS                                   |    8 +
 config/common_base                            |    5 +
 devtools/test-build.sh                        |    2 +
 doc/guides/nics/features/mvneta.ini           |   18 +
 doc/guides/nics/mvneta.rst                    |  154 ++
 doc/guides/rel_notes/release_18_11.rst        |    4 +
 drivers/common/Makefile                       |    4 +-
 drivers/common/mvep/rte_mvep_common.h         |    1 +
 drivers/net/Makefile                          |    1 +
 drivers/net/meson.build                       |    1 +
 drivers/net/mvneta/Makefile                   |   42 +
 drivers/net/mvneta/meson.build                |   27 +
 drivers/net/mvneta/mvneta_ethdev.c            | 2016 +++++++++++++++++++++++++
 drivers/net/mvneta/mvneta_ethdev.h            |   90 ++
 drivers/net/mvneta/rte_pmd_mvneta_version.map |    3 +
 mk/rte.app.mk                                 |    7 +-
 16 files changed, 2380 insertions(+), 3 deletions(-)
 create mode 100644 doc/guides/nics/features/mvneta.ini
 create mode 100644 doc/guides/nics/mvneta.rst
 create mode 100644 drivers/net/mvneta/Makefile
 create mode 100644 drivers/net/mvneta/meson.build
 create mode 100644 drivers/net/mvneta/mvneta_ethdev.c
 create mode 100644 drivers/net/mvneta/mvneta_ethdev.h
 create mode 100644 drivers/net/mvneta/rte_pmd_mvneta_version.map

Comments

Andrzej Ostruszka Sept. 10, 2018, 6:11 a.m. UTC | #1 
On 31.08.2018 14:59, Andrzej Ostruszka wrote:
> This patch series introduces new PMD for Marvell NETA adapters (MVNETA).
> See the documentation for more info.
[...]

Hello all

I'd appreciate comments on this patch series.  So far I have received
one comment for the redundant license text when SPDX tag is present
(which is fixed already in the latest version together with a number of
other minor fixes).

Thank you in advance
Best regards
Andrzej Ostruszka
Ferruh Yigit Sept. 14, 2018, 4:20 p.m. UTC | #2 
On 8/31/2018 1:59 PM, Andrzej Ostruszka wrote:
> This patch series introduces new PMD for Marvell NETA adapters (MVNETA).
> See the documentation for more info.
> 
> It is split for easier reviewing.
> 
> v3:
>     No changes against v2, just resubmitting again to have clean patch
>     set after my faulty format-patch.  My apologies for the noise.
> 
> v2:
>   * fixed couple of checkpatch warnings
>   * removed '\n' from MVNETA_LOG invocations (appended by the macro)
>   * removed unused MVNETA_MUSDK_DMA_MEMSIZE define
>   * changed one printf into MVNETA_LOG
>   * removed __func__ from one MVNETA_LOG invocation (inserted
>     automatically by the macro)
>   * minor grammar/spelling correction in comments
>   * removed license text from file with SPDX tag (mvneta.rst)
>   * removed misleading part of comment for mvneta_shadow_txq
>   * changed authorship of the patches to the original author
> 
> Natalie Samsonov (1):
>   net/mvneta: add reset statistics callback
> 
> Zyta Szpak (7):
>   net/mvneta: add neta PMD skeleton
>   net/mvneta: add Rx/Tx support
>   net/mvneta: support for setting of MTU
>   net/mvneta: add link update
>   net/mvneta: support for promiscuous
>   net/mvneta: add MAC filtering
>   net/mvneta: add support for basic stats

Hi Andrzej,

Patchset is mostly looks good to me, there is no major issue but I have
commented on some minor issues.

Can you also set a web page patch to add new hardware to supported hw list:
http://core.dpdk.org/supported/
https://git.dpdk.org/tools/dpdk-web/
Andrzej Ostruszka Sept. 19, 2018, 3:07 p.m. UTC | #3 
On 14.09.2018 18:20, Ferruh Yigit wrote:
> On 8/31/2018 1:59 PM, Andrzej Ostruszka wrote:
>> This patch series introduces new PMD for Marvell NETA adapters (MVNETA).
>> See the documentation for more info.
[...]
> Hi Andrzej,
> 
> Patchset is mostly looks good to me, there is no major issue but I have
> commented on some minor issues.

Thank you Ferruh for taking time to review it.  I have just pushed out
new version incorporating your suggestions.

> Can you also set a web page patch to add new hardware to supported hw list:
> http://core.dpdk.org/supported/
> https://git.dpdk.org/tools/dpdk-web/

Could you tell me what is the procedure for submitting web page patches?
 Same as for code (sending via e-mail to dev)?

Best regards
Andrzej
Ferruh Yigit Sept. 19, 2018, 5:39 p.m. UTC | #4 
On 9/19/2018 4:07 PM, Andrzej Ostruszka wrote:
> On 14.09.2018 18:20, Ferruh Yigit wrote:
>> On 8/31/2018 1:59 PM, Andrzej Ostruszka wrote:
>>> This patch series introduces new PMD for Marvell NETA adapters (MVNETA).
>>> See the documentation for more info.
> [...]
>> Hi Andrzej,
>>
>> Patchset is mostly looks good to me, there is no major issue but I have
>> commented on some minor issues.
> 
> Thank you Ferruh for taking time to review it.  I have just pushed out
> new version incorporating your suggestions.
> 
>> Can you also set a web page patch to add new hardware to supported hw list:
>> http://core.dpdk.org/supported/
>> https://git.dpdk.org/tools/dpdk-web/
> 
> Could you tell me what is the procedure for submitting web page patches?
>  Same as for code (sending via e-mail to dev)?

Same process but different mail list: web@dpdk.org
Andrzej Ostruszka Sept. 21, 2018, 11:59 a.m. UTC | #5 
On 19.09.2018 19:39, Ferruh Yigit wrote:
> On 9/19/2018 4:07 PM, Andrzej Ostruszka wrote:
>> On 14.09.2018 18:20, Ferruh Yigit wrote:
[...]
>>> Can you also set a web page patch to add new hardware to supported hw list:
>>> http://core.dpdk.org/supported/
>>> https://git.dpdk.org/tools/dpdk-web/
>>
>> Could you tell me what is the procedure for submitting web page patches?
>>  Same as for code (sending via e-mail to dev)?
> 
> Same process but different mail list: web@dpdk.org

Thanks.  I will send it out as soon as the NETA gets into next-net since
I see there is a custom of pointing to "reference commit" in commit
messages.

Best regards
Andrzej
Ferruh Yigit Sept. 21, 2018, 1:37 p.m. UTC | #6 
On 9/21/2018 12:59 PM, Andrzej Ostruszka wrote:
> On 19.09.2018 19:39, Ferruh Yigit wrote:
>> On 9/19/2018 4:07 PM, Andrzej Ostruszka wrote:
>>> On 14.09.2018 18:20, Ferruh Yigit wrote:
> [...]
>>>> Can you also set a web page patch to add new hardware to supported hw list:
>>>> http://core.dpdk.org/supported/
>>>> https://git.dpdk.org/tools/dpdk-web/
>>>
>>> Could you tell me what is the procedure for submitting web page patches?
>>>  Same as for code (sending via e-mail to dev)?
>>
>> Same process but different mail list: web@dpdk.org
> 
> Thanks.  I will send it out as soon as the NETA gets into next-net since
> I see there is a custom of pointing to "reference commit" in commit
> messages.

Thanks.
Yes, web page commit log should point to commit that adds the support.