mbox series

[v5,0/4] crypto: add asym crypto support

Message ID 1531236801-5931-1-git-send-email-shally.verma@caviumnetworks.com (mailing list archive)
Headers
Series crypto: add asym crypto support |

Message

Shally Verma July 10, 2018, 3:33 p.m. UTC 
  This patch series add support for asymmetric crypto in DPDK
librte_cryptodev framework along with documentation updates.

This patch series is divided in to following categories:
1. library patches with asymmetric API, xform and capability
   definitions
2. Programmer Guide updates with asymmetric description

openssl pmd and test app to be added as separate patch series
with 1.1.0 support.

changes in v5:
- remove asym_get/set_session_priv_data APIs
- fix 'make doc' error

changes in v4:
- add asym specific session header get size API
- add NULL check for asym_session_configure/destroy functions,
  for the devices that doesn’t support asymmetric
- remove redundant asym_op_reset and asym_op_attach functions from lib
- fix ordering in version.map
- simplified check_modlen function
- simplified logic in op_pool_create
- corrections in doc
- renaming rte_cryptodev_asym_session_get_private_data to 
  rte_cryptodev_asym_session_get_app_private_data 
- contains only lib changes

changes in v3:
- correct rte_cryptodev_asym_session_create to pass void** to
  rte_mempool_get() and add support for private_data_size flag
- remove redundant xform_type from rte_cryptodev_asymmetric_capability
- added rte_cryptodev_asym_session_set/get_private_data for app to setup
  private data in a session as per latest dpdk-next-crypto spec
- rename few APIs to be consistent with other API names
- update test meson.build to include asym unit test file

changes in v2:
-addresses patch apply failure
raised on asym crypto v1 patch series:
https://dpdk.org/dev/patchwork/patch/36575/
https://dpdk.org/dev/patchwork/patch/36576/
https://dpdk.org/dev/patchwork/patch/36577/

And, unit test and PMD patch series:
https://dpdk.org/dev/patchwork/patch/36928/
https://dpdk.org/dev/patchwork/patch/36929/
https://dpdk.org/dev/patchwork/patch/36930/
-- resolve git apply patch error on patch id 36575
-- resolve git apply patch error on patch id 36929

Changes in v1:
- removal of dedicated sym and asym qp setup,
- remove asym qp count and attach/detach_session apis
- re-org xforms params for deffie-hellman to allow
  public key and optional private key generations
- move elliptic curve changes into another separate patch/patch series

TBD:
- add elliptic curve support
- rename of existing session_configure/clear APIs to
  sym_session_configure/clear/init APIs

It is based on review discussion on RFC v1 asym crypto patch
http://dpdk.org/patch/34308.

RFC v1 patch http://dpdk.org/patch/34308 is further a derivative of
earlier reviewed  RFC v2 patch series:
http://dpdk.org/dev/patchwork/patch/24245/
http://dpdk.org/dev/patchwork/patch/24246/
http://dpdk.org/dev/patchwork/patch/24247/

Shally Verma (2):
  cryptodev: add asymmetric xform and op definitions
  doc: add asym crypto in cryptodev programmer guide

Sunila Sahu (2):
  cryptodev: support asymmetric operations
  cryptodev: add asymmetric capability

 doc/guides/prog_guide/cryptodev_lib.rst        | 290 ++++++++++++++-
 lib/librte_cryptodev/Makefile                  |   1 +
 lib/librte_cryptodev/meson.build               |   3 +-
 lib/librte_cryptodev/rte_crypto.h              |  37 +-
 lib/librte_cryptodev/rte_crypto_asym.h         | 496 +++++++++++++++++++++++++
 lib/librte_cryptodev/rte_cryptodev.c           | 242 +++++++++++-
 lib/librte_cryptodev/rte_cryptodev.h           | 194 +++++++++-
 lib/librte_cryptodev/rte_cryptodev_pmd.h       |  57 ++-
 lib/librte_cryptodev/rte_cryptodev_version.map |  15 +-
 9 files changed, 1315 insertions(+), 20 deletions(-)
 create mode 100644 lib/librte_cryptodev/rte_crypto_asym.h

Comments

De Lara Guarch, Pablo July 10, 2018, 9:35 p.m. UTC | #1 
> -----Original Message-----
> From: Shally Verma [mailto:shally.verma@caviumnetworks.com]
> Sent: Tuesday, July 10, 2018 4:33 PM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Cc: dev@dpdk.org; pathreya@caviumnetworks.com;
> nmurthy@caviumnetworks.com
> Subject: [PATCH v5 0/4] crypto: add asym crypto support
> 
> This patch series add support for asymmetric crypto in DPDK librte_cryptodev
> framework along with documentation updates.
> 
> This patch series is divided in to following categories:
> 1. library patches with asymmetric API, xform and capability
>    definitions
> 2. Programmer Guide updates with asymmetric description
> 
> openssl pmd and test app to be added as separate patch series with 1.1.0
> support.
> 

Acking this patchset, assuming comments from Declan/Fiona are addressed in next version.

Series-acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
De Lara Guarch, Pablo July 10, 2018, 9:41 p.m. UTC | #2 
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of De Lara Guarch, Pablo
> Sent: Tuesday, July 10, 2018 10:35 PM
> To: Shally Verma <shally.verma@caviumnetworks.com>
> Cc: dev@dpdk.org; pathreya@caviumnetworks.com;
> nmurthy@caviumnetworks.com
> Subject: Re: [dpdk-dev] [PATCH v5 0/4] crypto: add asym crypto support
> 
> 
> 
> > -----Original Message-----
> > From: Shally Verma [mailto:shally.verma@caviumnetworks.com]
> > Sent: Tuesday, July 10, 2018 4:33 PM
> > To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> > Cc: dev@dpdk.org; pathreya@caviumnetworks.com;
> > nmurthy@caviumnetworks.com
> > Subject: [PATCH v5 0/4] crypto: add asym crypto support
> >
> > This patch series add support for asymmetric crypto in DPDK
> > librte_cryptodev framework along with documentation updates.
> >
> > This patch series is divided in to following categories:
> > 1. library patches with asymmetric API, xform and capability
> >    definitions
> > 2. Programmer Guide updates with asymmetric description
> >
> > openssl pmd and test app to be added as separate patch series with
> > 1.1.0 support.
> >
> 
> Acking this patchset, assuming comments from Declan/Fiona are addressed in
> next version.
> 
> Series-acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>

Series applied to dpdk-next-crypto.
Thanks,

Pablo
Verma, Shally July 11, 2018, 5:09 a.m. UTC | #3 
>-----Original Message-----
>From: De Lara Guarch, Pablo [mailto:pablo.de.lara.guarch@intel.com]
>Sent: 11 July 2018 03:05
>To: Verma, Shally <Shally.Verma@cavium.com>
>Cc: dev@dpdk.org; Athreya, Narayana Prasad <NarayanaPrasad.Athreya@cavium.com>; Murthy, Nidadavolu
><Nidadavolu.Murthy@cavium.com>
>Subject: RE: [PATCH v5 0/4] crypto: add asym crypto support
>
>External Email
>
>> -----Original Message-----
>> From: Shally Verma [mailto:shally.verma@caviumnetworks.com]
>> Sent: Tuesday, July 10, 2018 4:33 PM
>> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
>> Cc: dev@dpdk.org; pathreya@caviumnetworks.com;
>> nmurthy@caviumnetworks.com
>> Subject: [PATCH v5 0/4] crypto: add asym crypto support
>>
>> This patch series add support for asymmetric crypto in DPDK librte_cryptodev
>> framework along with documentation updates.
>>
>> This patch series is divided in to following categories:
>> 1. library patches with asymmetric API, xform and capability
>>    definitions
>> 2. Programmer Guide updates with asymmetric description
>>
>> openssl pmd and test app to be added as separate patch series with 1.1.0
>> support.
>>
>
>Acking this patchset, assuming comments from Declan/Fiona are addressed in next version.
Thanks and as I said, we would continue to discuss and close on open items.

Shally
>
>Series-acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>