net/qede: change driver's default load parameter
diff mbox series

Message ID 20201203133023.4060250-1-dsinghrawat@marvell.com
State Superseded
Delegated to: Jerin Jacob
Headers show
Series
  • net/qede: change driver's default load parameter
Related show

Checks

Context Check Description
ci/iol-testing success Testing PASS
ci/travis-robot success Travis build: passed
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/Intel-compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

Devendra Singh Rawat Dec. 3, 2020, 1:30 p.m. UTC
Loading ecore clients (PMD or linux kernel driver) having different ecore
versions concurrently, is problematic from device's init/config
perspective. This fix changes driver's default load parameter to have
ecore version validated by MFW. All ecore clients having matching ecore
version should be allowed to load, otherwise MFW should fail the load
request.

Fixes: c5e1108920 ("alter driver's force load behavior")
Cc: stable@dpdk.org

Signed-off-by: Devendra Singh Rawat <dsinghrawat@marvell.com>
Signed-off-by: Manish Chopra <manishc@marvell.com>
Signed-off-by: Igor Russkikh <irusskikh@marvell.com>
---
 drivers/net/qede/qede_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Rasesh Mody Dec. 4, 2020, 4:32 a.m. UTC | #1
Hi Devendra,

>From: Devendra Singh Rawat <dsinghrawat@marvell.com>
>Sent: Thursday, December 03, 2020 5:30 AM
>
>Loading ecore clients (PMD or linux kernel driver) having different ecore
>versions concurrently, is problematic from device's init/config perspective.
>This fix changes driver's default load parameter to have ecore version
>validated by MFW. All ecore clients having matching ecore version should be
>allowed to load, otherwise MFW should fail the load request.
>

Accompanying this change, I think, Co-existence considerations section in NIC guide needs to be updated.

Thanks,
Rasesh

>Fixes: c5e1108920 ("alter driver's force load behavior")
>Cc: stable@dpdk.org
>
>Signed-off-by: Devendra Singh Rawat <dsinghrawat@marvell.com>
>Signed-off-by: Manish Chopra <manishc@marvell.com>
>Signed-off-by: Igor Russkikh <irusskikh@marvell.com>
>---
> drivers/net/qede/qede_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/net/qede/qede_main.c b/drivers/net/qede/qede_main.c
>index caa9d1d4f..d208d276a 100644
>--- a/drivers/net/qede/qede_main.c
>+++ b/drivers/net/qede/qede_main.c
>@@ -300,7 +300,7 @@ static int qed_slowpath_start(struct ecore_dev *edev,
> 	memset(&drv_load_params, 0, sizeof(drv_load_params));
> 	drv_load_params.mfw_timeout_val =
>ECORE_LOAD_REQ_LOCK_TO_DEFAULT;
> 	drv_load_params.avoid_eng_reset = false;
>-	drv_load_params.override_force_load =
>ECORE_OVERRIDE_FORCE_LOAD_ALWAYS;
>+	drv_load_params.override_force_load =
>ECORE_OVERRIDE_FORCE_LOAD_NONE;
> 	hw_init_params.avoid_eng_affin = false;
> 	hw_init_params.p_drv_load_params = &drv_load_params;
>
>--
>2.18.2

Patch
diff mbox series

diff --git a/drivers/net/qede/qede_main.c b/drivers/net/qede/qede_main.c
index caa9d1d4f..d208d276a 100644
--- a/drivers/net/qede/qede_main.c
+++ b/drivers/net/qede/qede_main.c
@@ -300,7 +300,7 @@  static int qed_slowpath_start(struct ecore_dev *edev,
 	memset(&drv_load_params, 0, sizeof(drv_load_params));
 	drv_load_params.mfw_timeout_val = ECORE_LOAD_REQ_LOCK_TO_DEFAULT;
 	drv_load_params.avoid_eng_reset = false;
-	drv_load_params.override_force_load = ECORE_OVERRIDE_FORCE_LOAD_ALWAYS;
+	drv_load_params.override_force_load = ECORE_OVERRIDE_FORCE_LOAD_NONE;
 	hw_init_params.avoid_eng_affin = false;
 	hw_init_params.p_drv_load_params = &drv_load_params;