From patchwork Wed Dec 2 10:11:38 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Liron Himi X-Patchwork-Id: 84677 X-Patchwork-Delegate: jerinj@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9C977A04DB; Wed, 2 Dec 2020 11:13:53 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 93F1DCA02; Wed, 2 Dec 2020 11:12:31 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 60066C9E7; Wed, 2 Dec 2020 11:12:29 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 0B2AAKwf024166; Wed, 2 Dec 2020 02:12:27 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=pfpt0220; bh=aRdY36tmiYbcPMB1wXCaG/Si+GMLQMaqK6kdLLgnZIs=; b=bpOoVSOjthYZ3dmM2NmGGSDPqBHCz2+nV7Otgoc+DTSmZmU/XpMAMK9/BQKkmDK2q0nV EQ8xTJ6lP+CvPJpotN6zjJW1Rva7/7GMzT+pm8aFpGitml7d1tucJxKlazsV3z4dpcaZ ELCeDCpisXu+9PtjXSaIock2lhUZ1zH+AbzjQdgBXehscPlMTOxUxu6U1CrPOe8gftub 2fIbrukmR9+SiCZi15rNskdrSGmsXSIwjUiHERMUZfWiWXv/BCBkRtq+LK7tQmNouu8M uffSwnf38IMBQrnr6T7j98UvP2g1jZITi6cWsRhZb1GZX3DT5+U/QFZGb4M5fov/nZ3E 2A== Received: from sc-exch01.marvell.com ([199.233.58.181]) by mx0b-0016f401.pphosted.com with ESMTP id 355w509r4j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 02 Dec 2020 02:12:25 -0800 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 2 Dec 2020 02:12:23 -0800 Received: from pt-lxl0023.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 2 Dec 2020 02:12:23 -0800 From: To: CC: , Liron Himi , Date: Wed, 2 Dec 2020 12:11:38 +0200 Message-ID: <20201202101212.4717-5-lironh@marvell.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201202101212.4717-1-lironh@marvell.com> References: <20201202101212.4717-1-lironh@marvell.com> MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.312, 18.0.737 definitions=2020-12-02_04:2020-11-30, 2020-12-02 signatures=0 Subject: [dpdk-dev] [PATCH v1 04/38] net/mvpp2: skip vlan flush X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Liron Himi vlan-flush in MUSDK is not supported yet. until it does, the code should be skipped as currently an redundant error message is displayed. Fixes: a8f3d6783 ("net/mrvl: support VLAN filtering") Cc: stable@dpdk.org Signed-off-by: Liron Himi Reviewed-by: Liron Himi Reviewed-by: Michael Shamis Signed-off-by: Liron Himi Reviewed-by: Liron Himi --- drivers/net/mvpp2/mrvl_ethdev.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethdev.c index ebd2bb1c8..0985ccebe 100644 --- a/drivers/net/mvpp2/mrvl_ethdev.c +++ b/drivers/net/mvpp2/mrvl_ethdev.c @@ -672,15 +672,15 @@ mrvl_dev_start(struct rte_eth_dev *dev) } if (!priv->vlan_flushed) { - ret = pp2_ppio_flush_vlan(priv->ppio); - if (ret) { - MRVL_LOG(ERR, "Failed to flush vlan list"); - /* - * TODO - * once pp2_ppio_flush_vlan() is supported jump to out - * goto out; - */ - } + /* + * TODO + * once pp2_ppio_flush_vlan() is supported call it + * ret = pp2_ppio_flush_vlan(priv->ppio); + * if (ret) { + * MRVL_LOG(ERR, "Failed to flush vlan list"); + * goto out; + * } + */ priv->vlan_flushed = 1; } ret = mrvl_mtu_set(dev, dev->data->mtu);