maintainers: Update for OcteonTx2 DMA and EP
diff mbox series

Message ID 20201110001938.174839-1-radhac@marvell.com
State Accepted
Delegated to: Thomas Monjalon
Headers show
Series
  • maintainers: Update for OcteonTx2 DMA and EP
Related show

Checks

Context Check Description
ci/iol-intel-Functional success Functional Testing PASS
ci/Intel-compilation success Compilation OK
ci/iol-mellanox-Performance success Performance Testing PASS
ci/travis-robot success Travis build: passed
ci/iol-testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/checkpatch success coding style OK

Commit Message

Radha Mohan Chintakuntla Nov. 10, 2020, 12:19 a.m. UTC
Replace the maintainers for OcteonTx2 DMA and EP drivers.

Signed-off-by: Radha Mohan Chintakuntla <radhac@marvell.com>
---
 MAINTAINERS | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comments

Radha Mohan Nov. 10, 2020, 6:13 p.m. UTC | #1
On Mon, Nov 9, 2020 at 4:20 PM Radha Mohan Chintakuntla
<radhac@marvell.com> wrote:
>
> Replace the maintainers for OcteonTx2 DMA and EP drivers.
>
> Signed-off-by: Radha Mohan Chintakuntla <radhac@marvell.com>
> ---
>  MAINTAINERS | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index a720cf672e..214515060a 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1258,12 +1258,14 @@ F: drivers/raw/dpaa2_cmdif/
>  F: doc/guides/rawdevs/dpaa2_cmdif.rst
>
>  Marvell OCTEON TX2 DMA
> -M: Satha Rao <skoteshwar@marvell.com>
> +M: Radha Mohan Chintakuntla <radhac@marvell.com>
> +M: Veerasenareddy Burru <vburru@marvell.com>
>  F: drivers/raw/octeontx2_dma/
>  F: doc/guides/rawdevs/octeontx2_dma.rst
>
>  Marvell OCTEON TX2 EP
> -M: Mahipal Challa <mchalla@marvell.com>
> +M: Radha Mohan Chintakuntla <radhac@marvell.com>
> +M: Veerasenareddy Burru <vburru@marvell.com>
>  F: drivers/raw/octeontx2_ep/
>  F: doc/guides/rawdevs/octeontx2_ep.rst
>
> --
> 2.24.1
>

Adding previous maintainers to ack.
Satha Koteswara Rao Kottidi Nov. 10, 2020, 6:18 p.m. UTC | #2
-----Original Message-----
From: Radha Mohan <mohun106@gmail.com> 
Sent: Tuesday, November 10, 2020 11:44 PM
To: Radha Chintakuntla <radhac@marvell.com>; Satha Koteswara Rao Kottidi <skoteshwar@marvell.com>; Mahipal Challa <mchalla@marvell.com>
Cc: dev@dpdk.org; Thomas Monjalon <thomas@monjalon.net>; Veerasenareddy Burru <vburru@marvell.com>; Satananda Burla <sburla@marvell.com>; Jerin Jacob Kollanukkaran <jerinj@marvell.com>
Subject: [EXT] Re: [dpdk-dev] [PATCH] maintainers: Update for OcteonTx2 DMA and EP

External Email

----------------------------------------------------------------------
On Mon, Nov 9, 2020 at 4:20 PM Radha Mohan Chintakuntla <radhac@marvell.com> wrote:
>
> Replace the maintainers for OcteonTx2 DMA and EP drivers.
>
> Signed-off-by: Radha Mohan Chintakuntla <radhac@marvell.com>
> ---
>  MAINTAINERS | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS index a720cf672e..214515060a 
> 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1258,12 +1258,14 @@ F: drivers/raw/dpaa2_cmdif/
>  F: doc/guides/rawdevs/dpaa2_cmdif.rst
>
>  Marvell OCTEON TX2 DMA
> -M: Satha Rao <skoteshwar@marvell.com>
> +M: Radha Mohan Chintakuntla <radhac@marvell.com>
> +M: Veerasenareddy Burru <vburru@marvell.com>
>  F: drivers/raw/octeontx2_dma/
>  F: doc/guides/rawdevs/octeontx2_dma.rst
>
>  Marvell OCTEON TX2 EP
> -M: Mahipal Challa <mchalla@marvell.com>
> +M: Radha Mohan Chintakuntla <radhac@marvell.com>
> +M: Veerasenareddy Burru <vburru@marvell.com>
>  F: drivers/raw/octeontx2_ep/
>  F: doc/guides/rawdevs/octeontx2_ep.rst
>
> --
> 2.24.1
>

Adding previous maintainers to ack.
Acked-by: Satha Rao <skoteshwar@marvell.com>
Mahipal Challa Nov. 11, 2020, 7:56 a.m. UTC | #3
-----Original Message-----
From: Radha Mohan <mohun106@gmail.com> 
Sent: Tuesday, November 10, 2020 11:44 PM
To: Radha Chintakuntla <radhac@marvell.com>; Satha Koteswara Rao Kottidi <skoteshwar@marvell.com>; Mahipal Challa <mchalla@marvell.com>
Cc: dev@dpdk.org; Thomas Monjalon <thomas@monjalon.net>; Veerasenareddy Burru <vburru@marvell.com>; Satananda Burla <sburla@marvell.com>; Jerin Jacob Kollanukkaran <jerinj@marvell.com>
Subject: [EXT] Re: [dpdk-dev] [PATCH] maintainers: Update for OcteonTx2 DMA and EP

External Email

----------------------------------------------------------------------
On Mon, Nov 9, 2020 at 4:20 PM Radha Mohan Chintakuntla <radhac@marvell.com> wrote:
>
> Replace the maintainers for OcteonTx2 DMA and EP drivers.
>
> Signed-off-by: Radha Mohan Chintakuntla <radhac@marvell.com>
> ---
>  MAINTAINERS | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS index a720cf672e..214515060a 
> 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1258,12 +1258,14 @@ F: drivers/raw/dpaa2_cmdif/
>  F: doc/guides/rawdevs/dpaa2_cmdif.rst
>
>  Marvell OCTEON TX2 DMA
> -M: Satha Rao <skoteshwar@marvell.com>
> +M: Radha Mohan Chintakuntla <radhac@marvell.com>
> +M: Veerasenareddy Burru <vburru@marvell.com>
>  F: drivers/raw/octeontx2_dma/
>  F: doc/guides/rawdevs/octeontx2_dma.rst
>
>  Marvell OCTEON TX2 EP
> -M: Mahipal Challa <mchalla@marvell.com>
> +M: Radha Mohan Chintakuntla <radhac@marvell.com>
> +M: Veerasenareddy Burru <vburru@marvell.com>
>  F: drivers/raw/octeontx2_ep/
>  F: doc/guides/rawdevs/octeontx2_ep.rst
>
> --
> 2.24.1
>

>Adding previous maintainers to ack.
Acked-by: Mahipal Challa <mchalla@marvell.com

Thanks,
Mahipal
Radha Mohan Nov. 13, 2020, 7:18 p.m. UTC | #4
On Tue, Nov 10, 2020 at 11:57 PM Mahipal Challa <mchalla@marvell.com> wrote:
>
>
>
> -----Original Message-----
> From: Radha Mohan <mohun106@gmail.com>
> Sent: Tuesday, November 10, 2020 11:44 PM
> To: Radha Chintakuntla <radhac@marvell.com>; Satha Koteswara Rao Kottidi <skoteshwar@marvell.com>; Mahipal Challa <mchalla@marvell.com>
> Cc: dev@dpdk.org; Thomas Monjalon <thomas@monjalon.net>; Veerasenareddy Burru <vburru@marvell.com>; Satananda Burla <sburla@marvell.com>; Jerin Jacob Kollanukkaran <jerinj@marvell.com>
> Subject: [EXT] Re: [dpdk-dev] [PATCH] maintainers: Update for OcteonTx2 DMA and EP
>
> External Email
>
> ----------------------------------------------------------------------
> On Mon, Nov 9, 2020 at 4:20 PM Radha Mohan Chintakuntla <radhac@marvell.com> wrote:
> >
> > Replace the maintainers for OcteonTx2 DMA and EP drivers.
> >
> > Signed-off-by: Radha Mohan Chintakuntla <radhac@marvell.com>
> > ---
> >  MAINTAINERS | 6 ++++--
> >  1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS index a720cf672e..214515060a
> > 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -1258,12 +1258,14 @@ F: drivers/raw/dpaa2_cmdif/
> >  F: doc/guides/rawdevs/dpaa2_cmdif.rst
> >
> >  Marvell OCTEON TX2 DMA
> > -M: Satha Rao <skoteshwar@marvell.com>
> > +M: Radha Mohan Chintakuntla <radhac@marvell.com>
> > +M: Veerasenareddy Burru <vburru@marvell.com>
> >  F: drivers/raw/octeontx2_dma/
> >  F: doc/guides/rawdevs/octeontx2_dma.rst
> >
> >  Marvell OCTEON TX2 EP
> > -M: Mahipal Challa <mchalla@marvell.com>
> > +M: Radha Mohan Chintakuntla <radhac@marvell.com>
> > +M: Veerasenareddy Burru <vburru@marvell.com>
> >  F: drivers/raw/octeontx2_ep/
> >  F: doc/guides/rawdevs/octeontx2_ep.rst
> >
> > --
> > 2.24.1
> >
>
> >Adding previous maintainers to ack.
> Acked-by: Mahipal Challa <mchalla@marvell.com
>
> Thanks,
> Mahipal

Hi Thomas,
Could you please pick this patch ?

regards,
Radha Mohan
Thomas Monjalon Nov. 13, 2020, 10:38 p.m. UTC | #5
13/11/2020 20:18, Radha Mohan:
> On Tue, Nov 10, 2020 at 11:57 PM Mahipal Challa <mchalla@marvell.com> wrote:
> From: Radha Mohan <mohun106@gmail.com>
> Sent: Tuesday, November 10, 2020 11:44 PM
> > On Mon, Nov 9, 2020 at 4:20 PM Radha Mohan Chintakuntla <radhac@marvell.com> wrote:
> > >
> > > Replace the maintainers for OcteonTx2 DMA and EP drivers.
> > >
> > > Signed-off-by: Radha Mohan Chintakuntla <radhac@marvell.com>
[...]
> > >Adding previous maintainers to ack.
> > Acked-by: Mahipal Challa <mchalla@marvell.com
> >
> > Thanks,
> > Mahipal
> 
> Hi Thomas,
> Could you please pick this patch ?

This low-priority patch has been sent 4 days ago,
and was acked by only 1 maintainer 3 days ago.

Why pushing? What is your fear exactly?

Why the new maintainers candidates have 0 and 2 contributions
in git history?
Radha Mohan Nov. 16, 2020, 6:28 p.m. UTC | #6
On Fri, Nov 13, 2020 at 2:39 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 13/11/2020 20:18, Radha Mohan:
> > On Tue, Nov 10, 2020 at 11:57 PM Mahipal Challa <mchalla@marvell.com> wrote:
> > From: Radha Mohan <mohun106@gmail.com>
> > Sent: Tuesday, November 10, 2020 11:44 PM
> > > On Mon, Nov 9, 2020 at 4:20 PM Radha Mohan Chintakuntla <radhac@marvell.com> wrote:
> > > >
> > > > Replace the maintainers for OcteonTx2 DMA and EP drivers.
> > > >
> > > > Signed-off-by: Radha Mohan Chintakuntla <radhac@marvell.com>
> [...]
> > > >Adding previous maintainers to ack.
> > > Acked-by: Mahipal Challa <mchalla@marvell.com
> > >
> > > Thanks,
> > > Mahipal
> >
> > Hi Thomas,
> > Could you please pick this patch ?
>
> This low-priority patch has been sent 4 days ago,
> and was acked by only 1 maintainer 3 days ago.
>

It was acked by both the old maintainers Satha Koteshwar and Mahipal
Challa. Maybe both of those emails didn't come on top of each other.

> Why pushing? What is your fear exactly?

Just want to make the transfer of ownership official in the mainline.
There's no fear I just normally wanted to send a reminder to you to
pick as it might be missed inclusion. If there's a guarantee that all
ack'ed patches will go automatically then I won't be sending any
reminder emails in future.

>
> Why the new maintainers candidates have 0 and 2 contributions
> in git history?
>
These drivers requires some maintenance and likely expanded to support
future chips from Marvell. So you will not see contributions right
away.
So to become a maintainer one has to have prior contributions ? Kind
of makes odd sense as these drivers are specific to our chip and we
are changing ownership for maintaining them.
I do not understand why you have an issue here? You don't like
reminding then I understand.

regards,
Radha Mohan
Thomas Monjalon Nov. 16, 2020, 8:28 p.m. UTC | #7
16/11/2020 19:28, Radha Mohan:
> On Fri, Nov 13, 2020 at 2:39 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> > 13/11/2020 20:18, Radha Mohan:
> > > On Tue, Nov 10, 2020 at 11:57 PM Mahipal Challa <mchalla@marvell.com> wrote:
> > > From: Radha Mohan <mohun106@gmail.com>
> > > Sent: Tuesday, November 10, 2020 11:44 PM
> > > > On Mon, Nov 9, 2020 at 4:20 PM Radha Mohan Chintakuntla <radhac@marvell.com> wrote:
> > > > >
> > > > > Replace the maintainers for OcteonTx2 DMA and EP drivers.
> > > > >
> > > > > Signed-off-by: Radha Mohan Chintakuntla <radhac@marvell.com>
> > [...]
> > > > >Adding previous maintainers to ack.
> > > > Acked-by: Mahipal Challa <mchalla@marvell.com
> > > >
> > > > Thanks,
> > > > Mahipal
> > >
> > > Hi Thomas,
> > > Could you please pick this patch ?
> >
> > This low-priority patch has been sent 4 days ago,
> > and was acked by only 1 maintainer 3 days ago.
> >
> 
> It was acked by both the old maintainers Satha Koteshwar and Mahipal
> Challa. Maybe both of those emails didn't come on top of each other.

I missed one.

> > Why pushing? What is your fear exactly?
> 
> Just want to make the transfer of ownership official in the mainline.
> There's no fear I just normally wanted to send a reminder to you to
> pick as it might be missed inclusion. If there's a guarantee that all
> ack'ed patches will go automatically then I won't be sending any
> reminder emails in future.

It's OK to send reminder, but please wait at least a week.

> > Why the new maintainers candidates have 0 and 2 contributions
> > in git history?
> >
> These drivers requires some maintenance and likely expanded to support
> future chips from Marvell. So you will not see contributions right
> away.
> So to become a maintainer one has to have prior contributions ?

Yes: http://doc.dpdk.org/guides/contributing/patches.html#maintainers-and-sub-trees
"
Maintainers should have demonstrated a reasonable level of contributions or reviews to the component area. The maintainer should be confirmed by an ack from an established contributor.
"

> Kind of makes odd sense as these drivers are specific to our chip and we
> are changing ownership for maintaining them.
> I do not understand why you have an issue here?
> You don't like reminding then I understand.

I don't like how you push new unconfirmed maintainers.
Radha Mohan Nov. 18, 2020, 4:15 a.m. UTC | #8
On Mon, Nov 16, 2020 at 12:28 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 16/11/2020 19:28, Radha Mohan:
> > On Fri, Nov 13, 2020 at 2:39 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> > > 13/11/2020 20:18, Radha Mohan:
> > > > On Tue, Nov 10, 2020 at 11:57 PM Mahipal Challa <mchalla@marvell.com> wrote:
> > > > From: Radha Mohan <mohun106@gmail.com>
> > > > Sent: Tuesday, November 10, 2020 11:44 PM
> > > > > On Mon, Nov 9, 2020 at 4:20 PM Radha Mohan Chintakuntla <radhac@marvell.com> wrote:
> > > > > >
> > > > > > Replace the maintainers for OcteonTx2 DMA and EP drivers.
> > > > > >
> > > > > > Signed-off-by: Radha Mohan Chintakuntla <radhac@marvell.com>
> > > [...]
> > > > > >Adding previous maintainers to ack.
> > > > > Acked-by: Mahipal Challa <mchalla@marvell.com
> > > > >
> > > > > Thanks,
> > > > > Mahipal
> > > >
> > > > Hi Thomas,
> > > > Could you please pick this patch ?
> > >
> > > This low-priority patch has been sent 4 days ago,
> > > and was acked by only 1 maintainer 3 days ago.
> > >
> >
> > It was acked by both the old maintainers Satha Koteshwar and Mahipal
> > Challa. Maybe both of those emails didn't come on top of each other.
>
> I missed one.
>
> > > Why pushing? What is your fear exactly?
> >
> > Just want to make the transfer of ownership official in the mainline.
> > There's no fear I just normally wanted to send a reminder to you to
> > pick as it might be missed inclusion. If there's a guarantee that all
> > ack'ed patches will go automatically then I won't be sending any
> > reminder emails in future.
>
> It's OK to send reminder, but please wait at least a week.
>
> > > Why the new maintainers candidates have 0 and 2 contributions
> > > in git history?
> > >
> > These drivers requires some maintenance and likely expanded to support
> > future chips from Marvell. So you will not see contributions right
> > away.
> > So to become a maintainer one has to have prior contributions ?
>
> Yes: http://doc.dpdk.org/guides/contributing/patches.html#maintainers-and-sub-trees
> "
> Maintainers should have demonstrated a reasonable level of contributions or reviews to the component area. The maintainer should be confirmed by an ack from an established contributor.
> "

How was this done without prior contributions?
http://git.dpdk.org/dpdk/commit/MAINTAINERS?id=238e3167ca869abf44fa50ead022d7fc3b99605b

The commit log says that he is a "new developer". So am I technically
to the community.

Also the thing that puzzles me most is its a driver specific to
Marvell and both the previous maintainers are ok with the transfer but
a strange rule that probably applies to generic things of dpdk code
(which really makes sense there) comes as a blocker.
And how does new driver go?
Lets say if either myself or veerasena have pushed a new driver now
who has to ack it for inclusion ? Isn't that like a chicken and egg
problem.

I am looking for clarifications as things are different in other open
source communities.

>
> > Kind of makes odd sense as these drivers are specific to our chip and we
> > are changing ownership for maintaining them.
> > I do not understand why you have an issue here?
> > You don't like reminding then I understand.
>
> I don't like how you push new unconfirmed maintainers.

Could you please explain above commit made into new maintainer?

>
>
Thomas Monjalon Nov. 18, 2020, 9:15 a.m. UTC | #9
18/11/2020 05:15, Radha Mohan:
> On Mon, Nov 16, 2020 at 12:28 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> > 16/11/2020 19:28, Radha Mohan:
> > > On Fri, Nov 13, 2020 at 2:39 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> > > > 13/11/2020 20:18, Radha Mohan:
> > > > > On Tue, Nov 10, 2020 at 11:57 PM Mahipal Challa <mchalla@marvell.com> wrote:
> > > > > From: Radha Mohan <mohun106@gmail.com>
> > > > > Sent: Tuesday, November 10, 2020 11:44 PM
> > > > > > On Mon, Nov 9, 2020 at 4:20 PM Radha Mohan Chintakuntla <radhac@marvell.com> wrote:
> > > > > > >
> > > > > > > Replace the maintainers for OcteonTx2 DMA and EP drivers.
> > > > > > >
> > > > > > > Signed-off-by: Radha Mohan Chintakuntla <radhac@marvell.com>
> > > > [...]
> > > > > > >Adding previous maintainers to ack.
> > > > > > Acked-by: Mahipal Challa <mchalla@marvell.com
> > > > > >
> > > > > > Thanks,
> > > > > > Mahipal
> > > > >
> > > > > Hi Thomas,
> > > > > Could you please pick this patch ?
> > > >
> > > > This low-priority patch has been sent 4 days ago,
> > > > and was acked by only 1 maintainer 3 days ago.
> > > >
> > >
> > > It was acked by both the old maintainers Satha Koteshwar and Mahipal
> > > Challa. Maybe both of those emails didn't come on top of each other.
> >
> > I missed one.
> >
> > > > Why pushing? What is your fear exactly?
> > >
> > > Just want to make the transfer of ownership official in the mainline.
> > > There's no fear I just normally wanted to send a reminder to you to
> > > pick as it might be missed inclusion. If there's a guarantee that all
> > > ack'ed patches will go automatically then I won't be sending any
> > > reminder emails in future.
> >
> > It's OK to send reminder, but please wait at least a week.
> >
> > > > Why the new maintainers candidates have 0 and 2 contributions
> > > > in git history?
> > > >
> > > These drivers requires some maintenance and likely expanded to support
> > > future chips from Marvell. So you will not see contributions right
> > > away.
> > > So to become a maintainer one has to have prior contributions ?
> >
> > Yes: http://doc.dpdk.org/guides/contributing/patches.html#maintainers-and-sub-trees
> > "
> > Maintainers should have demonstrated a reasonable level of contributions or reviews to the component area. The maintainer should be confirmed by an ack from an established contributor.
> > "
> 
> How was this done without prior contributions?
> http://git.dpdk.org/dpdk/commit/MAINTAINERS?id=238e3167ca869abf44fa50ead022d7fc3b99605b

I asked a confirmation:
http://inbox.dpdk.org/dev/1985242.AXpOyGb66D@thomas/


> The commit log says that he is a "new developer". So am I technically
> to the community.
> 
> Also the thing that puzzles me most is its a driver specific to
> Marvell and both the previous maintainers are ok with the transfer but
> a strange rule that probably applies to generic things of dpdk code
> (which really makes sense there) comes as a blocker.

Did I say it is a blocker?

> And how does new driver go?

For new drivers, the new maintainers arrive by contributing new code.

> Lets say if either myself or veerasena have pushed a new driver now
> who has to ack it for inclusion ? Isn't that like a chicken and egg
> problem.

Nobody has to ack for a new driver.

> I am looking for clarifications as things are different in other open
> source communities.
> 
> > > Kind of makes odd sense as these drivers are specific to our chip and we
> > > are changing ownership for maintaining them.
> > > I do not understand why you have an issue here?
> > > You don't like reminding then I understand.
> >
> > I don't like how you push new unconfirmed maintainers.
> 
> Could you please explain above commit made into new maintainer?

Listen: I say I don't like how pushy you are, that's all.
In general it's very good to have new contributors.
But please think how you can help instead of just requesting.
We have a lot more important things to care at the moment
to close the big release 20.11. If you want to help, you are welcome.
Radha Mohan Nov. 18, 2020, 9:31 p.m. UTC | #10
On Wed, Nov 18, 2020 at 1:15 AM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 18/11/2020 05:15, Radha Mohan:
> > On Mon, Nov 16, 2020 at 12:28 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> > > 16/11/2020 19:28, Radha Mohan:
> > > > On Fri, Nov 13, 2020 at 2:39 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> > > > > 13/11/2020 20:18, Radha Mohan:
> > > > > > On Tue, Nov 10, 2020 at 11:57 PM Mahipal Challa <mchalla@marvell.com> wrote:
> > > > > > From: Radha Mohan <mohun106@gmail.com>
> > > > > > Sent: Tuesday, November 10, 2020 11:44 PM
> > > > > > > On Mon, Nov 9, 2020 at 4:20 PM Radha Mohan Chintakuntla <radhac@marvell.com> wrote:
> > > > > > > >
> > > > > > > > Replace the maintainers for OcteonTx2 DMA and EP drivers.
> > > > > > > >
> > > > > > > > Signed-off-by: Radha Mohan Chintakuntla <radhac@marvell.com>
> > > > > [...]
> > > > > > > >Adding previous maintainers to ack.
> > > > > > > Acked-by: Mahipal Challa <mchalla@marvell.com
> > > > > > >
> > > > > > > Thanks,
> > > > > > > Mahipal
> > > > > >
> > > > > > Hi Thomas,
> > > > > > Could you please pick this patch ?
> > > > >
> > > > > This low-priority patch has been sent 4 days ago,
> > > > > and was acked by only 1 maintainer 3 days ago.
> > > > >
> > > >
> > > > It was acked by both the old maintainers Satha Koteshwar and Mahipal
> > > > Challa. Maybe both of those emails didn't come on top of each other.
> > >
> > > I missed one.
> > >
> > > > > Why pushing? What is your fear exactly?
> > > >
> > > > Just want to make the transfer of ownership official in the mainline.
> > > > There's no fear I just normally wanted to send a reminder to you to
> > > > pick as it might be missed inclusion. If there's a guarantee that all
> > > > ack'ed patches will go automatically then I won't be sending any
> > > > reminder emails in future.
> > >
> > > It's OK to send reminder, but please wait at least a week.
> > >
> > > > > Why the new maintainers candidates have 0 and 2 contributions
> > > > > in git history?
> > > > >
> > > > These drivers requires some maintenance and likely expanded to support
> > > > future chips from Marvell. So you will not see contributions right
> > > > away.
> > > > So to become a maintainer one has to have prior contributions ?
> > >
> > > Yes: http://doc.dpdk.org/guides/contributing/patches.html#maintainers-and-sub-trees
> > > "
> > > Maintainers should have demonstrated a reasonable level of contributions or reviews to the component area. The maintainer should be confirmed by an ack from an established contributor.
> > > "
> >
> > How was this done without prior contributions?
> > http://git.dpdk.org/dpdk/commit/MAINTAINERS?id=238e3167ca869abf44fa50ead022d7fc3b99605b
>
> I asked a confirmation:
> http://inbox.dpdk.org/dev/1985242.AXpOyGb66D@thomas/

Right. But in this case I got different.

>
>
> > The commit log says that he is a "new developer". So am I technically
> > to the community.
> >
> > Also the thing that puzzles me most is its a driver specific to
> > Marvell and both the previous maintainers are ok with the transfer but
> > a strange rule that probably applies to generic things of dpdk code
> > (which really makes sense there) comes as a blocker.
>
> Did I say it is a blocker?

Maybe I got that impression from your comments.

>
> > And how does new driver go?
>
> For new drivers, the new maintainers arrive by contributing new code.
>
> > Lets say if either myself or veerasena have pushed a new driver now
> > who has to ack it for inclusion ? Isn't that like a chicken and egg
> > problem.
>
> Nobody has to ack for a new driver.
>
> > I am looking for clarifications as things are different in other open
> > source communities.
> >
> > > > Kind of makes odd sense as these drivers are specific to our chip and we
> > > > are changing ownership for maintaining them.
> > > > I do not understand why you have an issue here?
> > > > You don't like reminding then I understand.
> > >
> > > I don't like how you push new unconfirmed maintainers.
> >
> > Could you please explain above commit made into new maintainer?
>
> Listen: I say I don't like how pushy you are, that's all.
> In general it's very good to have new contributors.
> But please think how you can help instead of just requesting.
> We have a lot more important things to care at the moment
> to close the big release 20.11. If you want to help, you are welcome.
>

ok fair enough. For my defence i wasn't being pushy. So hopefully this
updation can be taken once you are able to do after 20.11.

>
Thomas Monjalon Nov. 22, 2020, 11:28 a.m. UTC | #11
> > Replace the maintainers for OcteonTx2 DMA and EP drivers.
> >
> > Signed-off-by: Radha Mohan Chintakuntla <radhac@marvell.com>
> > ---
> >  Marvell OCTEON TX2 DMA
> > -M: Satha Rao <skoteshwar@marvell.com>
> > +M: Radha Mohan Chintakuntla <radhac@marvell.com>
> > +M: Veerasenareddy Burru <vburru@marvell.com>
> >  F: drivers/raw/octeontx2_dma/
> >  F: doc/guides/rawdevs/octeontx2_dma.rst
> >
> >  Marvell OCTEON TX2 EP
> > -M: Mahipal Challa <mchalla@marvell.com>
> > +M: Radha Mohan Chintakuntla <radhac@marvell.com>
> > +M: Veerasenareddy Burru <vburru@marvell.com>
> >  F: drivers/raw/octeontx2_ep/
> >  F: doc/guides/rawdevs/octeontx2_ep.rst
> >
> Acked-by: Satha Rao <skoteshwar@marvell.com>
> Acked-by: Mahipal Challa <mchalla@marvell.com

Applied

Patch
diff mbox series

diff --git a/MAINTAINERS b/MAINTAINERS
index a720cf672e..214515060a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1258,12 +1258,14 @@  F: drivers/raw/dpaa2_cmdif/
 F: doc/guides/rawdevs/dpaa2_cmdif.rst
 
 Marvell OCTEON TX2 DMA
-M: Satha Rao <skoteshwar@marvell.com>
+M: Radha Mohan Chintakuntla <radhac@marvell.com>
+M: Veerasenareddy Burru <vburru@marvell.com>
 F: drivers/raw/octeontx2_dma/
 F: doc/guides/rawdevs/octeontx2_dma.rst
 
 Marvell OCTEON TX2 EP
-M: Mahipal Challa <mchalla@marvell.com>
+M: Radha Mohan Chintakuntla <radhac@marvell.com>
+M: Veerasenareddy Burru <vburru@marvell.com>
 F: drivers/raw/octeontx2_ep/
 F: doc/guides/rawdevs/octeontx2_ep.rst